From: Tavis Ormandy <taviso@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: stack buffer overflow in fbdev
Date: Fri, 19 Jul 2019 14:03:43 +0000 [thread overview]
Message-ID: <20190719140343.GA12952@thinkstation> (raw)
Hello, during a conversation on twitter we noticed a stack buffer
overflow in fbdev with malicious edid data:
https://github.com/torvalds/linux/blob/22051d9c4a57d3b4a8b5a7407efc80c71c7bfb16/drivers/video/fbdev/core/fbmon.c#L1033
There is enough space to have 52 1-byte length values, which makes svd_n
52, then make the final value length 0x1f (the maximum), which makes
svd_n 83 and overflows the 64 byte stack buffer svd[] with controlled
data.
This requires a malicious monitor / projector / etc, so pretty low impact.
I pulled out the code to make a demo (I removed the checksum, but it
doesnt prevent the bug):
https://gist.github.com/taviso/923776e633cb8fb1ab847cce761a0f10
This was discovered by Nico Waisman of Semmle.
Tavis.
--
-------------------------------------
taviso@sdf.lonestar.org | finger me for my pgp key.
-------------------------------------------------------
reply other threads:[~2019-07-19 14:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719140343.GA12952@thinkstation \
--to=taviso@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).