From: Douglas Anderson <dianders@chromium.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>,
linux-fbdev@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Russell King <linux@armlinux.org.uk>,
Daniel Vetter <daniel@ffwll.ch>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing()
Date: Mon, 22 Jul 2019 18:24:35 +0000 [thread overview]
Message-ID: <20190722182439.44844-1-dianders@chromium.org> (raw)
As reported by Sam Ravnborg [1], after commit b8a2948fa2b3
("drm/panel: simple: Add ability to override typical timing") we now
see a pointless error message printed on every boot for many systems.
Let's fix that by adjusting who is responsible for printing error
messages when of_get_display_timing() is used.
Most certainly we can bikeshed the topic about whether this is the
right fix or we should instead add logic to panel_simple_probe() to
avoid calling of_get_display_timing() in the case where there is no
"panel-timing" sub-node. If there is consensus that I should move the
fix to panel_simple_probe() I'm happy to spin this series. In that
case we probably should _remove_ the extra prints that were already
present in the other two callers of of_get_display_timing().
While at it, fix a missing of_node_put() found by code inspection.
NOTE: amba-clcd and panel-lvds were only compile-tested.
[1] https://lkml.kernel.org/r/20190721093815.GA4375@ravnborg.org
Douglas Anderson (4):
video: of: display_timing: Add of_node_put() in
of_get_display_timing()
video: of: display_timing: Don't yell if no timing node is present
drm: panel-lvds: Spout an error if of_get_display_timing() gives an
error
video: amba-clcd: Spout an error if of_get_display_timing() gives an
error
drivers/gpu/drm/panel/panel-lvds.c | 5 ++++-
drivers/video/fbdev/amba-clcd.c | 4 +++-
drivers/video/of_display_timing.c | 11 +++++++----
3 files changed, 14 insertions(+), 6 deletions(-)
--
2.22.0.657.g960e92d24f-goog
next reply other threads:[~2019-07-22 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:24 Douglas Anderson [this message]
2019-07-22 18:24 ` [PATCH 1/4] video: of: display_timing: Add of_node_put() in of_get_display_timing() Douglas Anderson
2019-07-27 2:51 ` Laurent Pinchart
2019-07-22 18:24 ` [PATCH 2/4] video: of: display_timing: Don't yell if no timing node is present Douglas Anderson
2019-07-22 18:24 ` [PATCH 3/4] drm: panel-lvds: Spout an error if of_get_display_timing() gives an error Douglas Anderson
2019-07-22 18:24 ` [PATCH 4/4] video: amba-clcd: " Douglas Anderson
2019-07-23 8:27 ` Linus Walleij
2019-07-23 8:38 ` [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing() Sam Ravnborg
2019-07-26 14:42 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722182439.44844-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=p.zabel@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).