* [RFC] Staging: fbtft: Typo in
@ 2019-07-21 18:54 Christophe JAILLET
2019-07-25 7:16 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2019-07-21 18:54 UTC (permalink / raw)
To: linux-fbdev
Hi,
looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems
to be some typos.
At the end of the file, we can find:
FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display);
...
MODULE_ALIAS("spi:pdc8544");
It is likely that the 2 pdc8544 should be pcd8544. (d and c switched)
As I don't know the implication of such a change, I prefer to first
report the potential issue, before proposing a patch for it.
Any feedback back appreciated.
Best regards,
Christophe JAILLET
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] Staging: fbtft: Typo in
2019-07-21 18:54 [RFC] Staging: fbtft: Typo in Christophe JAILLET
@ 2019-07-25 7:16 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-07-25 7:16 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: linux-fbdev, Kernel Janitors, dri-devel, nishadkamdar
On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote:
> Hi,
>
> looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to
> be some typos.
>
> At the end of the file, we can find:
>
> FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display);
> ...
> MODULE_ALIAS("spi:pdc8544");
>
>
> It is likely that the 2 pdc8544 should be pcd8544. (d and c switched)
>
> As I don't know the implication of such a change, I prefer to first report
> the potential issue, before proposing a patch for it.
Submit a patch, that's the best way to discuss it!
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-21 18:54 [RFC] Staging: fbtft: Typo in Christophe JAILLET
2019-07-25 7:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).