linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
	kvm@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Sudeep Dutt" <sudeep.dutt@intel.com>,
	dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	sparclinux@vger.kernel.org, ceph-devel@vger.kernel.org,
	devel@driverdev.osuosl.org,
	"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
	rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
	x86@kernel.org, amd-gfx@lists.freedesktop.org,
	"Christoph Hellwig" <hch@infradead.org>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	xen-devel@lists.xenproject.org, devel@lists.orangefs.org,
	linux-media@vger.kernel.org, "Joerg Roedel" <jroedel@suse.de>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"John Hubbard" <jhubbard@nvidia.com>,
	intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org,
	"Jérôme Glisse" <jglisse@redhat.com>,
	linux-rpi-kernel@lists.infradead
Subject: [PATCH 11/34] scif: convert put_page() to put_user_page*()
Date: Fri, 02 Aug 2019 02:19:42 +0000	[thread overview]
Message-ID: <20190802022005.5117-12-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190802022005.5117-1-jhubbard@nvidia.com>

From: John Hubbard <jhubbard@nvidia.com>

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 drivers/misc/mic/scif/scif_rma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c
index 01e27682ea30..d84ed9466920 100644
--- a/drivers/misc/mic/scif/scif_rma.c
+++ b/drivers/misc/mic/scif/scif_rma.c
@@ -113,13 +113,14 @@ static int scif_destroy_pinned_pages(struct scif_pinned_pages *pin)
 	int writeable = pin->prot & SCIF_PROT_WRITE;
 	int kernel = SCIF_MAP_KERNEL & pin->map_flags;
 
-	for (j = 0; j < pin->nr_pages; j++) {
-		if (pin->pages[j] && !kernel) {
+	if (kernel) {
+		for (j = 0; j < pin->nr_pages; j++) {
 			if (writeable)
-				SetPageDirty(pin->pages[j]);
+				set_page_dirty_lock(pin->pages[j]);
 			put_page(pin->pages[j]);
 		}
-	}
+	} else
+		put_user_pages_dirty_lock(pin->pages, pin->nr_pages, writeable);
 
 	scif_free(pin->pages,
 		  pin->nr_pages * sizeof(*pin->pages));
@@ -1385,11 +1386,9 @@ int __scif_pin_pages(void *addr, size_t len, int *out_prot,
 				if (ulimit)
 					__scif_dec_pinned_vm_lock(mm, nr_pages);
 				/* Roll back any pinned pages */
-				for (i = 0; i < pinned_pages->nr_pages; i++) {
-					if (pinned_pages->pages[i])
-						put_page(
-						pinned_pages->pages[i]);
-				}
+				put_user_pages(pinned_pages->pages,
+					       pinned_pages->nr_pages);
+
 				prot &= ~SCIF_PROT_WRITE;
 				try_upgrade = false;
 				goto retry;
-- 
2.22.0

  parent reply	other threads:[~2019-08-02  2:19 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02  2:16 [PATCH 00/34] put_user_pages(): miscellaneous call sites john.hubbard
2019-08-02  2:16 ` [PATCH 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() john.hubbard
2019-08-02  2:16 ` [PATCH 02/34] net/rds: convert put_page() to put_user_page*() john.hubbard
2019-08-02  2:19 ` [PATCH 00/34] put_user_pages(): miscellaneous call sites john.hubbard
2019-08-02  2:19   ` [PATCH 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() john.hubbard
2019-08-02  2:19   ` [PATCH 02/34] net/rds: convert put_page() to put_user_page*() john.hubbard
2019-08-02  2:19   ` [PATCH 03/34] net/ceph: " john.hubbard
2019-08-02 22:32     ` Jeff Layton
2019-08-02  2:19   ` [PATCH 04/34] x86/kvm: " john.hubbard
2019-08-02  2:19   ` [PATCH 05/34] drm/etnaviv: convert release_pages() to put_user_pages() john.hubbard
2019-08-02  2:19   ` [PATCH 06/34] drm/i915: convert put_page() to put_user_page*() john.hubbard
2019-08-02  9:19     ` Joonas Lahtinen
2019-08-02 18:48       ` John Hubbard
2019-08-03 20:03         ` John Hubbard
2019-08-02  2:19   ` [PATCH 07/34] drm/radeon: " john.hubbard
2019-08-02  2:19   ` [PATCH 08/34] media/ivtv: " john.hubbard
2019-08-02  2:19   ` [PATCH 09/34] media/v4l2-core/mm: " john.hubbard
2019-08-02  2:19   ` [PATCH 10/34] genwqe: " john.hubbard
2019-08-03  7:06     ` Greg Kroah-Hartman
2019-08-02  2:19   ` john.hubbard [this message]
2019-08-02  2:19   ` [PATCH 12/34] vmci: " john.hubbard
2019-08-02  2:19   ` [PATCH 13/34] rapidio: " john.hubbard
2019-08-02  2:19   ` [PATCH 14/34] oradax: " john.hubbard
2019-08-02  2:19   ` [PATCH 15/34] staging/vc04_services: " john.hubbard
2019-08-03  7:06     ` Greg Kroah-Hartman
2019-08-02  2:19   ` [PATCH 16/34] drivers/tee: " john.hubbard
2019-08-02  6:29     ` Jens Wiklander
2019-08-02 18:51       ` John Hubbard
2019-08-02  2:19   ` [PATCH 17/34] vfio: " john.hubbard
2019-08-02  2:19   ` [PATCH 18/34] fbdev/pvr2fb: " john.hubbard
2019-08-02  2:19   ` [PATCH 19/34] fsl_hypervisor: " john.hubbard
2019-08-02  2:19   ` [PATCH 20/34] xen: " john.hubbard
2019-08-02  4:36     ` Juergen Gross
2019-08-02  5:48       ` John Hubbard
2019-08-02  6:10         ` Juergen Gross
2019-08-02 16:09           ` Weiny, Ira
2019-08-02 19:25             ` John Hubbard
2019-08-02  2:19   ` [PATCH 21/34] fs/exec.c: " john.hubbard
2019-08-02  2:19   ` [PATCH 22/34] orangefs: " john.hubbard
2019-08-02  2:19   ` [PATCH 23/34] uprobes: " john.hubbard
2019-08-02  2:19   ` [PATCH 24/34] futex: " john.hubbard
2019-08-02  2:19   ` [PATCH 25/34] mm/frame_vector.c: " john.hubbard
2019-08-02  2:19   ` [PATCH 26/34] mm/gup_benchmark.c: " john.hubbard
2019-08-02 14:19     ` Keith Busch
2019-08-02  2:19   ` [PATCH 27/34] mm/memory.c: " john.hubbard
2019-08-02  2:19   ` [PATCH 28/34] mm/madvise.c: " john.hubbard
2019-08-02  2:20   ` [PATCH 29/34] mm/process_vm_access.c: " john.hubbard
2019-08-02  2:20   ` [PATCH 30/34] crypt: " john.hubbard
2019-08-02  2:20   ` [PATCH 31/34] nfs: " john.hubbard
2019-08-03  1:27     ` Calum Mackay
2019-08-03  1:41       ` John Hubbard
2019-08-04 23:28         ` Calum Mackay
2019-08-02  2:20   ` [PATCH 32/34] goldfish_pipe: " john.hubbard
2019-08-02  2:20   ` [PATCH 33/34] kernel/events/core.c: " john.hubbard
2019-08-02  2:20   ` [PATCH 34/34] fs/binfmt_elf: " john.hubbard
     [not found]   ` <20190802022005.5117-1-jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-08-02  9:12     ` [PATCH 00/34] put_user_pages(): miscellaneous call sites Michal Hocko
2019-08-02 12:41       ` Jan Kara
2019-08-02 14:24         ` Matthew Wilcox
2019-08-02 14:52           ` Jan Kara
2019-08-02 19:14             ` John Hubbard
2019-08-07  8:37               ` Jan Kara
2019-08-07  8:46                 ` Michal Hocko
2019-08-08  2:36                   ` Ira Weiny
2019-08-08  3:46                     ` John Hubbard
2019-08-08 16:25                       ` Weiny, Ira
2019-08-08 18:18                         ` John Hubbard
2019-08-09  8:34                     ` Jan Kara
2019-08-02  2:39 ` John Hubbard
2019-08-02  8:05 ` Peter Zijlstra
2019-08-02 19:33   ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190802022005.5117-12-jhubbard@nvidia.com \
    --to=john.hubbard@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=arnd@arndb.de \
    --cc=ashutosh.dixit@intel.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@fromorbit.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devel@lists.orangefs.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@infradead.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=jroedel@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead \
    --cc=rds-devel@oss.oracle.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=sudeep.dutt@intel.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).