From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Sat, 03 Aug 2019 07:06:40 +0000 Subject: Re: [PATCH 10/34] genwqe: convert put_page() to put_user_page*() Message-Id: <20190803070640.GB2508@kroah.com> List-Id: References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-11-jhubbard@nvidia.com> In-Reply-To: <20190802022005.5117-11-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: john.hubbard@gmail.com Cc: linux-fbdev@vger.kernel.org, Jan Kara , kvm@vger.kernel.org, Dave Hansen , Dave Chinner , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, Dan Williams , devel@driverdev.osuosl.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, x86@kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , xen-devel@lists.xenproject.org, devel@lists.orangefs.org, linux-media@vger.kernel.org, Arnd Bergmann , "Guilherme G. Piccoli" , John Hubbard , intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, linux-arm-kerne On Thu, Aug 01, 2019 at 07:19:41PM -0700, john.hubbard@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > This changes the release code slightly, because each page slot in the > page_list[] array is no longer checked for NULL. However, that check > was wrong anyway, because the get_user_pages() pattern of usage here > never allowed for NULL entries within a range of pinned pages. > > Cc: Frank Haverkamp > Cc: "Guilherme G. Piccoli" > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Signed-off-by: John Hubbard > --- > drivers/misc/genwqe/card_utils.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) Acked-by: Greg Kroah-Hartman