* [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata [not found] <20190808212234.2213262-1-arnd@arndb.de> @ 2019-08-08 21:22 ` Arnd Bergmann 2019-08-09 11:29 ` Bartlomiej Zolnierkiewicz 2019-08-08 21:22 ` [PATCH 09/22] fbdev: omap: avoid using mach/*.h files Arnd Bergmann 1 sibling, 1 reply; 4+ messages in thread From: Arnd Bergmann @ 2019-08-08 21:22 UTC (permalink / raw) To: Tony Lindgren, Aaro Koskinen, Bartlomiej Zolnierkiewicz Cc: linux-fbdev, Arnd Bergmann, Greg Kroah-Hartman, linux-kernel, dri-devel, Tomi Valkeinen, linux-omap, linux-arm-kernel To avoid using the mach/omap1510.h header file, pass the correct address as platform data. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-omap1/board-innovator.c | 3 +++ drivers/video/fbdev/omap/lcd_inn1510.c | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap1/board-innovator.c b/arch/arm/mach-omap1/board-innovator.c index cbe093f969d5..2425f1bacb33 100644 --- a/arch/arm/mach-omap1/board-innovator.c +++ b/arch/arm/mach-omap1/board-innovator.c @@ -194,6 +194,9 @@ static struct platform_device innovator1510_smc91x_device = { static struct platform_device innovator1510_lcd_device = { .name = "lcd_inn1510", .id = -1, + .dev = { + .platform_data = (void __force *)OMAP1510_FPGA_LCD_PANEL_CONTROL, + } }; static struct platform_device innovator1510_spi_device = { diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c index 776e7f8d656e..37ed0c14aa5a 100644 --- a/drivers/video/fbdev/omap/lcd_inn1510.c +++ b/drivers/video/fbdev/omap/lcd_inn1510.c @@ -14,15 +14,17 @@ #include "omapfb.h" +static void __iomem *omap1510_fpga_lcd_panel_control; + static int innovator1510_panel_enable(struct lcd_panel *panel) { - __raw_writeb(0x7, OMAP1510_FPGA_LCD_PANEL_CONTROL); + __raw_writeb(0x7, omap1510_fpga_lcd_panel_control); return 0; } static void innovator1510_panel_disable(struct lcd_panel *panel) { - __raw_writeb(0x0, OMAP1510_FPGA_LCD_PANEL_CONTROL); + __raw_writeb(0x0, omap1510_fpga_lcd_panel_control); } static struct lcd_panel innovator1510_panel = { @@ -48,6 +50,7 @@ static struct lcd_panel innovator1510_panel = { static int innovator1510_panel_probe(struct platform_device *pdev) { + omap1510_fpga_lcd_panel_control = (void __iomem *)pdev->dev.platform_data; omapfb_register_panel(&innovator1510_panel); return 0; } -- 2.20.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata 2019-08-08 21:22 ` [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata Arnd Bergmann @ 2019-08-09 11:29 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-08-09 11:29 UTC (permalink / raw) To: Arnd Bergmann Cc: Tony Lindgren, Aaro Koskinen, linux-omap, linux-arm-kernel, Greg Kroah-Hartman, Linus Walleij, Tomi Valkeinen, linux-kernel, linux-fbdev, dri-devel On 8/8/19 11:22 PM, Arnd Bergmann wrote: > To avoid using the mach/omap1510.h header file, pass the correct > address as platform data. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> For fbdev part: Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > arch/arm/mach-omap1/board-innovator.c | 3 +++ > drivers/video/fbdev/omap/lcd_inn1510.c | 7 +++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap1/board-innovator.c b/arch/arm/mach-omap1/board-innovator.c > index cbe093f969d5..2425f1bacb33 100644 > --- a/arch/arm/mach-omap1/board-innovator.c > +++ b/arch/arm/mach-omap1/board-innovator.c > @@ -194,6 +194,9 @@ static struct platform_device innovator1510_smc91x_device = { > static struct platform_device innovator1510_lcd_device = { > .name = "lcd_inn1510", > .id = -1, > + .dev = { > + .platform_data = (void __force *)OMAP1510_FPGA_LCD_PANEL_CONTROL, > + } > }; > > static struct platform_device innovator1510_spi_device = { > diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c > index 776e7f8d656e..37ed0c14aa5a 100644 > --- a/drivers/video/fbdev/omap/lcd_inn1510.c > +++ b/drivers/video/fbdev/omap/lcd_inn1510.c > @@ -14,15 +14,17 @@ > > #include "omapfb.h" > > +static void __iomem *omap1510_fpga_lcd_panel_control; > + > static int innovator1510_panel_enable(struct lcd_panel *panel) > { > - __raw_writeb(0x7, OMAP1510_FPGA_LCD_PANEL_CONTROL); > + __raw_writeb(0x7, omap1510_fpga_lcd_panel_control); > return 0; > } > > static void innovator1510_panel_disable(struct lcd_panel *panel) > { > - __raw_writeb(0x0, OMAP1510_FPGA_LCD_PANEL_CONTROL); > + __raw_writeb(0x0, omap1510_fpga_lcd_panel_control); > } > > static struct lcd_panel innovator1510_panel = { > @@ -48,6 +50,7 @@ static struct lcd_panel innovator1510_panel = { > > static int innovator1510_panel_probe(struct platform_device *pdev) > { > + omap1510_fpga_lcd_panel_control = (void __iomem *)pdev->dev.platform_data; > omapfb_register_panel(&innovator1510_panel); > return 0; > } ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 09/22] fbdev: omap: avoid using mach/*.h files [not found] <20190808212234.2213262-1-arnd@arndb.de> 2019-08-08 21:22 ` [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata Arnd Bergmann @ 2019-08-08 21:22 ` Arnd Bergmann 2019-08-09 11:34 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 4+ messages in thread From: Arnd Bergmann @ 2019-08-08 21:22 UTC (permalink / raw) To: Tony Lindgren, Aaro Koskinen, Lee Jones, Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz Cc: linux-fbdev, Arnd Bergmann, Greg Kroah-Hartman, linux-kernel, dri-devel, Tomi Valkeinen, linux-omap, linux-arm-kernel All the headers we actually need are now in include/linux/soc, so use those versions instead and allow compile-testing on other architectures. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/video/backlight/Kconfig | 4 ++-- drivers/video/backlight/omap1_bl.c | 4 ++-- drivers/video/fbdev/omap/Kconfig | 4 ++-- drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- drivers/video/fbdev/omap/lcd_dma.c | 3 ++- drivers/video/fbdev/omap/lcd_inn1510.c | 2 +- drivers/video/fbdev/omap/lcd_osk.c | 4 ++-- drivers/video/fbdev/omap/lcdc.c | 2 ++ drivers/video/fbdev/omap/omapfb_main.c | 3 +-- drivers/video/fbdev/omap/sossi.c | 1 + 10 files changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 8b081d61773e..195c71130827 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -213,8 +213,8 @@ config BACKLIGHT_LOCOMO config BACKLIGHT_OMAP1 tristate "OMAP1 PWL-based LCD Backlight" - depends on ARCH_OMAP1 - default y + depends on ARCH_OMAP1 || COMPILE_TEST + default ARCH_OMAP1 help This driver controls the LCD backlight level and power for the PWL module of OMAP1 processors. Say Y if your board diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c index 74263021b1b3..69a49384b3de 100644 --- a/drivers/video/backlight/omap1_bl.c +++ b/drivers/video/backlight/omap1_bl.c @@ -14,8 +14,8 @@ #include <linux/slab.h> #include <linux/platform_data/omap1_bl.h> -#include <mach/hardware.h> -#include <mach/mux.h> +#include <linux/soc/ti/omap1-io.h> +#include <linux/soc/ti/omap1-mux.h> #define OMAPBL_MAX_INTENSITY 0xff diff --git a/drivers/video/fbdev/omap/Kconfig b/drivers/video/fbdev/omap/Kconfig index df2a5d0d4aa2..b1786cf1b486 100644 --- a/drivers/video/fbdev/omap/Kconfig +++ b/drivers/video/fbdev/omap/Kconfig @@ -2,7 +2,7 @@ config FB_OMAP tristate "OMAP frame buffer support" depends on FB - depends on ARCH_OMAP1 + depends on ARCH_OMAP1 || (ARM && COMPILE_TEST) select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT @@ -42,7 +42,7 @@ config FB_OMAP_LCD_MIPID config FB_OMAP_LCD_H3 bool "TPS65010 LCD controller on OMAP-H3" - depends on MACH_OMAP_H3 + depends on MACH_OMAP_H3 || COMPILE_TEST depends on TPS65010=y default y help diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c index 8e54aae544a0..da2e32615abe 100644 --- a/drivers/video/fbdev/omap/lcd_ams_delta.c +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c @@ -14,7 +14,7 @@ #include <linux/gpio/consumer.h> #include <linux/lcd.h> -#include <mach/hardware.h> +#include <linux/soc/ti/omap1-io.h> #include "omapfb.h" diff --git a/drivers/video/fbdev/omap/lcd_dma.c b/drivers/video/fbdev/omap/lcd_dma.c index 867a63c06f42..f85817635a8c 100644 --- a/drivers/video/fbdev/omap/lcd_dma.c +++ b/drivers/video/fbdev/omap/lcd_dma.c @@ -25,7 +25,8 @@ #include <linux/omap-dma.h> -#include <mach/hardware.h> +#include <linux/soc/ti/omap1-soc.h> +#include <linux/soc/ti/omap1-io.h> #include "lcdc.h" #include "lcd_dma.h" diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c index 37ed0c14aa5a..bb915637e9b6 100644 --- a/drivers/video/fbdev/omap/lcd_inn1510.c +++ b/drivers/video/fbdev/omap/lcd_inn1510.c @@ -10,7 +10,7 @@ #include <linux/platform_device.h> #include <linux/io.h> -#include <mach/hardware.h> +#include <linux/soc/ti/omap1-soc.h> #include "omapfb.h" diff --git a/drivers/video/fbdev/omap/lcd_osk.c b/drivers/video/fbdev/omap/lcd_osk.c index 5d5762128c8d..8168ba0d47fd 100644 --- a/drivers/video/fbdev/omap/lcd_osk.c +++ b/drivers/video/fbdev/omap/lcd_osk.c @@ -11,8 +11,8 @@ #include <linux/platform_device.h> #include <linux/gpio.h> -#include <mach/hardware.h> -#include <mach/mux.h> +#include <linux/soc/ti/omap1-io.h> +#include <linux/soc/ti/omap1-mux.h> #include "omapfb.h" diff --git a/drivers/video/fbdev/omap/lcdc.c b/drivers/video/fbdev/omap/lcdc.c index 65953b7fbdb9..3af758f12afd 100644 --- a/drivers/video/fbdev/omap/lcdc.c +++ b/drivers/video/fbdev/omap/lcdc.c @@ -17,6 +17,8 @@ #include <linux/clk.h> #include <linux/gfp.h> +#include <linux/soc/ti/omap1-io.h> +#include <linux/soc/ti/omap1-soc.h> #include <linux/omap-dma.h> #include <asm/mach-types.h> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index dc06057de91d..af73a3f9ac53 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -19,8 +19,7 @@ #include <linux/omap-dma.h> -#include <mach/hardware.h> - +#include <linux/soc/ti/omap1-soc.h> #include "omapfb.h" #include "lcdc.h" diff --git a/drivers/video/fbdev/omap/sossi.c b/drivers/video/fbdev/omap/sossi.c index ade9d452254c..6b99d89fbe6e 100644 --- a/drivers/video/fbdev/omap/sossi.c +++ b/drivers/video/fbdev/omap/sossi.c @@ -13,6 +13,7 @@ #include <linux/interrupt.h> #include <linux/omap-dma.h> +#include <linux/soc/ti/omap1-io.h> #include "omapfb.h" #include "lcd_dma.h" -- 2.20.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 09/22] fbdev: omap: avoid using mach/*.h files 2019-08-08 21:22 ` [PATCH 09/22] fbdev: omap: avoid using mach/*.h files Arnd Bergmann @ 2019-08-09 11:34 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-08-09 11:34 UTC (permalink / raw) To: Arnd Bergmann Cc: Tony Lindgren, Aaro Koskinen, Lee Jones, Daniel Thompson, Jingoo Han, linux-omap, linux-arm-kernel, Greg Kroah-Hartman, Linus Walleij, Tomi Valkeinen, dri-devel, linux-fbdev, linux-kernel On 8/8/19 11:22 PM, Arnd Bergmann wrote: > All the headers we actually need are now in include/linux/soc, > so use those versions instead and allow compile-testing on > other architectures. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> For fbdev part: Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/backlight/Kconfig | 4 ++-- > drivers/video/backlight/omap1_bl.c | 4 ++-- > drivers/video/fbdev/omap/Kconfig | 4 ++-- > drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- > drivers/video/fbdev/omap/lcd_dma.c | 3 ++- > drivers/video/fbdev/omap/lcd_inn1510.c | 2 +- > drivers/video/fbdev/omap/lcd_osk.c | 4 ++-- > drivers/video/fbdev/omap/lcdc.c | 2 ++ > drivers/video/fbdev/omap/omapfb_main.c | 3 +-- > drivers/video/fbdev/omap/sossi.c | 1 + > 10 files changed, 16 insertions(+), 13 deletions(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 8b081d61773e..195c71130827 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -213,8 +213,8 @@ config BACKLIGHT_LOCOMO > > config BACKLIGHT_OMAP1 > tristate "OMAP1 PWL-based LCD Backlight" > - depends on ARCH_OMAP1 > - default y > + depends on ARCH_OMAP1 || COMPILE_TEST > + default ARCH_OMAP1 > help > This driver controls the LCD backlight level and power for > the PWL module of OMAP1 processors. Say Y if your board > diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c > index 74263021b1b3..69a49384b3de 100644 > --- a/drivers/video/backlight/omap1_bl.c > +++ b/drivers/video/backlight/omap1_bl.c > @@ -14,8 +14,8 @@ > #include <linux/slab.h> > #include <linux/platform_data/omap1_bl.h> > > -#include <mach/hardware.h> > -#include <mach/mux.h> > +#include <linux/soc/ti/omap1-io.h> > +#include <linux/soc/ti/omap1-mux.h> > > #define OMAPBL_MAX_INTENSITY 0xff > > diff --git a/drivers/video/fbdev/omap/Kconfig b/drivers/video/fbdev/omap/Kconfig > index df2a5d0d4aa2..b1786cf1b486 100644 > --- a/drivers/video/fbdev/omap/Kconfig > +++ b/drivers/video/fbdev/omap/Kconfig > @@ -2,7 +2,7 @@ > config FB_OMAP > tristate "OMAP frame buffer support" > depends on FB > - depends on ARCH_OMAP1 > + depends on ARCH_OMAP1 || (ARM && COMPILE_TEST) > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -42,7 +42,7 @@ config FB_OMAP_LCD_MIPID > > config FB_OMAP_LCD_H3 > bool "TPS65010 LCD controller on OMAP-H3" > - depends on MACH_OMAP_H3 > + depends on MACH_OMAP_H3 || COMPILE_TEST > depends on TPS65010=y > default y > help > diff --git a/drivers/video/fbdev/omap/lcd_ams_delta.c b/drivers/video/fbdev/omap/lcd_ams_delta.c > index 8e54aae544a0..da2e32615abe 100644 > --- a/drivers/video/fbdev/omap/lcd_ams_delta.c > +++ b/drivers/video/fbdev/omap/lcd_ams_delta.c > @@ -14,7 +14,7 @@ > #include <linux/gpio/consumer.h> > #include <linux/lcd.h> > > -#include <mach/hardware.h> > +#include <linux/soc/ti/omap1-io.h> > > #include "omapfb.h" > > diff --git a/drivers/video/fbdev/omap/lcd_dma.c b/drivers/video/fbdev/omap/lcd_dma.c > index 867a63c06f42..f85817635a8c 100644 > --- a/drivers/video/fbdev/omap/lcd_dma.c > +++ b/drivers/video/fbdev/omap/lcd_dma.c > @@ -25,7 +25,8 @@ > > #include <linux/omap-dma.h> > > -#include <mach/hardware.h> > +#include <linux/soc/ti/omap1-soc.h> > +#include <linux/soc/ti/omap1-io.h> > > #include "lcdc.h" > #include "lcd_dma.h" > diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c > index 37ed0c14aa5a..bb915637e9b6 100644 > --- a/drivers/video/fbdev/omap/lcd_inn1510.c > +++ b/drivers/video/fbdev/omap/lcd_inn1510.c > @@ -10,7 +10,7 @@ > #include <linux/platform_device.h> > #include <linux/io.h> > > -#include <mach/hardware.h> > +#include <linux/soc/ti/omap1-soc.h> > > #include "omapfb.h" > > diff --git a/drivers/video/fbdev/omap/lcd_osk.c b/drivers/video/fbdev/omap/lcd_osk.c > index 5d5762128c8d..8168ba0d47fd 100644 > --- a/drivers/video/fbdev/omap/lcd_osk.c > +++ b/drivers/video/fbdev/omap/lcd_osk.c > @@ -11,8 +11,8 @@ > #include <linux/platform_device.h> > #include <linux/gpio.h> > > -#include <mach/hardware.h> > -#include <mach/mux.h> > +#include <linux/soc/ti/omap1-io.h> > +#include <linux/soc/ti/omap1-mux.h> > > #include "omapfb.h" > > diff --git a/drivers/video/fbdev/omap/lcdc.c b/drivers/video/fbdev/omap/lcdc.c > index 65953b7fbdb9..3af758f12afd 100644 > --- a/drivers/video/fbdev/omap/lcdc.c > +++ b/drivers/video/fbdev/omap/lcdc.c > @@ -17,6 +17,8 @@ > #include <linux/clk.h> > #include <linux/gfp.h> > > +#include <linux/soc/ti/omap1-io.h> > +#include <linux/soc/ti/omap1-soc.h> > #include <linux/omap-dma.h> > > #include <asm/mach-types.h> > diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c > index dc06057de91d..af73a3f9ac53 100644 > --- a/drivers/video/fbdev/omap/omapfb_main.c > +++ b/drivers/video/fbdev/omap/omapfb_main.c > @@ -19,8 +19,7 @@ > > #include <linux/omap-dma.h> > > -#include <mach/hardware.h> > - > +#include <linux/soc/ti/omap1-soc.h> > #include "omapfb.h" > #include "lcdc.h" > > diff --git a/drivers/video/fbdev/omap/sossi.c b/drivers/video/fbdev/omap/sossi.c > index ade9d452254c..6b99d89fbe6e 100644 > --- a/drivers/video/fbdev/omap/sossi.c > +++ b/drivers/video/fbdev/omap/sossi.c > @@ -13,6 +13,7 @@ > #include <linux/interrupt.h> > > #include <linux/omap-dma.h> > +#include <linux/soc/ti/omap1-io.h> > > #include "omapfb.h" > #include "lcd_dma.h" ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-09 11:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190808212234.2213262-1-arnd@arndb.de>
2019-08-08 21:22 ` [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata Arnd Bergmann
2019-08-09 11:29 ` Bartlomiej Zolnierkiewicz
2019-08-08 21:22 ` [PATCH 09/22] fbdev: omap: avoid using mach/*.h files Arnd Bergmann
2019-08-09 11:34 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).