public inbox for linux-fbdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fbdev@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] fbdev/sa1100fb: Remove even more dead code
Date: Fri, 06 Sep 2019 18:36:15 +0000	[thread overview]
Message-ID: <20190906183615.GH3958@phenom.ffwll.local> (raw)
In-Reply-To: <20190906151307.1127187-1-arnd@arndb.de>

On Fri, Sep 06, 2019 at 05:13:00PM +0200, Arnd Bergmann wrote:
> This function lost its only call site as part of
> earlier dead code removal, so remove it as well:
> 
> drivers/video/fbdev/sa1100fb.c:975:21: error: unused function 'sa1100fb_min_dma_period' [-Werror,-Wunused-function]
> 
> Fixes: 390e5de11284 ("fbdev/sa1100fb: Remove dead code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Queud for 5.5 in drm-misc-next since Bart is away from merge duties until
end of this month.
-Daniel
> ---
>  drivers/video/fbdev/sa1100fb.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
> index ae2bcfee338a..81ad3aa1ca06 100644
> --- a/drivers/video/fbdev/sa1100fb.c
> +++ b/drivers/video/fbdev/sa1100fb.c
> @@ -967,19 +967,6 @@ static void sa1100fb_task(struct work_struct *w)
>  }
>  
>  #ifdef CONFIG_CPU_FREQ
> -/*
> - * Calculate the minimum DMA period over all displays that we own.
> - * This, together with the SDRAM bandwidth defines the slowest CPU
> - * frequency that can be selected.
> - */
> -static unsigned int sa1100fb_min_dma_period(struct sa1100fb_info *fbi)
> -{
> -	/*
> -	 * FIXME: we need to verify _all_ consoles.
> -	 */
> -	return sa1100fb_display_dma_period(&fbi->fb.var);
> -}
> -
>  /*
>   * CPU clock speed change handler.  We need to adjust the LCD timing
>   * parameters when the CPU clock is adjusted by the power management
> -- 
> 2.20.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

      reply	other threads:[~2019-09-06 18:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 15:13 [PATCH] fbdev/sa1100fb: Remove even more dead code Arnd Bergmann
2019-09-06 18:36 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906183615.GH3958@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox