* [PATCH] backlight: lm3630a: fix module aliases
@ 2019-09-10 15:23 Andreas Kemnade
2019-09-11 10:51 ` Daniel Thompson
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Kemnade @ 2019-09-10 15:23 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1, b.zolnierkie, dri-devel,
linux-fbdev, linux-kernel, hns
Cc: Andreas Kemnade
Devicetree aliases are missing, so that module autoloading
does not work properly.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/video/backlight/lm3630a_bl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index 3b45a1733198..9d67c07db2f2 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = {
{}
};
+MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+
static const struct of_device_id lm3630a_match_table[] = {
{ .compatible = "ti,lm3630a", },
{ },
};
-MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+MODULE_DEVICE_TABLE(of, lm3630a_match_table);
static struct i2c_driver lm3630a_i2c_driver = {
.driver = {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] backlight: lm3630a: fix module aliases
2019-09-10 15:23 [PATCH] backlight: lm3630a: fix module aliases Andreas Kemnade
@ 2019-09-11 10:51 ` Daniel Thompson
2019-10-05 18:19 ` Andreas Kemnade
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Thompson @ 2019-09-11 10:51 UTC (permalink / raw)
To: Andreas Kemnade
Cc: lee.jones, jingoohan1, b.zolnierkie, dri-devel, linux-fbdev,
linux-kernel, hns
On Tue, Sep 10, 2019 at 05:23:59PM +0200, Andreas Kemnade wrote:
> Devicetree aliases are missing, so that module autoloading
> does not work properly.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/lm3630a_bl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index 3b45a1733198..9d67c07db2f2 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = {
> {}
> };
>
> +MODULE_DEVICE_TABLE(i2c, lm3630a_id);
> +
> static const struct of_device_id lm3630a_match_table[] = {
> { .compatible = "ti,lm3630a", },
> { },
> };
>
> -MODULE_DEVICE_TABLE(i2c, lm3630a_id);
> +MODULE_DEVICE_TABLE(of, lm3630a_match_table);
>
> static struct i2c_driver lm3630a_i2c_driver = {
> .driver = {
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] backlight: lm3630a: fix module aliases
2019-09-11 10:51 ` Daniel Thompson
@ 2019-10-05 18:19 ` Andreas Kemnade
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Kemnade @ 2019-10-05 18:19 UTC (permalink / raw)
To: Daniel Thompson
Cc: lee.jones, jingoohan1, b.zolnierkie, dri-devel, linux-fbdev,
linux-kernel, hns
Hi,
hmm, this bugfix has not arrived in -next or any -fixes branch I am
aware of yet. I hope it is not forgotten...
so a friendly ping.
Regards,
Andreas
On Wed, 11 Sep 2019 11:51:48 +0100
Daniel Thompson <daniel.thompson@linaro.org> wrote:
> On Tue, Sep 10, 2019 at 05:23:59PM +0200, Andreas Kemnade wrote:
> > Devicetree aliases are missing, so that module autoloading
> > does not work properly.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>
> > ---
> > drivers/video/backlight/lm3630a_bl.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> > index 3b45a1733198..9d67c07db2f2 100644
> > --- a/drivers/video/backlight/lm3630a_bl.c
> > +++ b/drivers/video/backlight/lm3630a_bl.c
> > @@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = {
> > {}
> > };
> >
> > +MODULE_DEVICE_TABLE(i2c, lm3630a_id);
> > +
> > static const struct of_device_id lm3630a_match_table[] = {
> > { .compatible = "ti,lm3630a", },
> > { },
> > };
> >
> > -MODULE_DEVICE_TABLE(i2c, lm3630a_id);
> > +MODULE_DEVICE_TABLE(of, lm3630a_match_table);
> >
> > static struct i2c_driver lm3630a_i2c_driver = {
> > .driver = {
> > --
> > 2.11.0
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-05 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-10 15:23 [PATCH] backlight: lm3630a: fix module aliases Andreas Kemnade
2019-09-11 10:51 ` Daniel Thompson
2019-10-05 18:19 ` Andreas Kemnade
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).