From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 14 Oct 2019 07:27:34 +0000 Subject: Re: [PATCH v2 3/4] backlight: pwm_bl: drop use of int_pow() Message-Id: <20191014072734.GG4545@dell> List-Id: References: <20191008120327.24208-1-linux@rasmusvillemoes.dk> <20191008120327.24208-4-linux@rasmusvillemoes.dk> In-Reply-To: <20191008120327.24208-4-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Rasmus Villemoes Cc: Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 08 Oct 2019, Rasmus Villemoes wrote: > For a fixed small exponent of 3, it is more efficient to simply use > two explicit multiplications rather than calling the int_pow() library > function: Aside from the function call overhead, its implementation > using repeated squaring means it ends up doing four 64x64 > multiplications. > > Reviewed-by: Daniel Thompson > Signed-off-by: Rasmus Villemoes > --- > drivers/video/backlight/pwm_bl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog