From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jacopo Mondi <jacopo@jmondi.org>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v6 0/9] backlight: gpio: simplify the driver
Date: Sat, 19 Oct 2019 08:35:47 +0000 [thread overview]
Message-ID: <20191019083556.19466-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
While working on my other series related to gpio-backlight[1] I noticed
that we could simplify the driver if we made the only user of platform
data use GPIO lookups and device properties. This series tries to do
that.
First two patches contain minor fixes. Third patch makes the driver
explicitly drive the GPIO line. Fourth patch adds all necessary data
structures to ecovec24. Patch 5/9 unifies much of the code for both
pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
fields. Last two patches contain additional improvements for the GPIO
backlight driver while we're already modifying it.
I don't have access to this HW but hopefully this works. Only compile
tested.
[1] https://lkml.org/lkml/2019/6/25/900
v1 -> v2:
- rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
- added additional two patches with minor improvements
v2 -> v3:
- in patch 7/7: used initializers to set values for pdata and dev local vars
v3 -> v4:
- rebased on top of v5.4-rc1
- removed changes that are no longer relevant after commit ec665b756e6f
("backlight: gpio-backlight: Correct initial power state handling")
- added patch 7/7
v4 -> v5:
- in patch 7/7: added a comment replacing the name of the function being
pulled into probe()
v5 -> v6:
- added a patch making the driver explicitly set the direction of the GPIO
to output
- added a patch removing a redundant newline
Bartosz Golaszewski (9):
backlight: gpio: remove unneeded include
backlight: gpio: remove stray newline
backlight: gpio: explicitly set the direction of the GPIO
sh: ecovec24: add additional properties to the backlight device
backlight: gpio: simplify the platform data handling
sh: ecovec24: don't set unused fields in platform data
backlight: gpio: remove unused fields from platform data
backlight: gpio: use a helper variable for &pdev->dev
backlight: gpio: pull gpio_backlight_initial_power_state() into probe
arch/sh/boards/mach-ecovec24/setup.c | 33 +++--
drivers/video/backlight/gpio_backlight.c | 128 +++++++------------
include/linux/platform_data/gpio_backlight.h | 3 -
3 files changed, 69 insertions(+), 95 deletions(-)
--
2.23.0
next reply other threads:[~2019-10-19 8:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 8:35 Bartosz Golaszewski [this message]
2019-10-19 8:35 ` [PATCH v6 1/9] backlight: gpio: remove unneeded include Bartosz Golaszewski
2019-10-19 8:35 ` [PATCH v6 2/9] backlight: gpio: remove stray newline Bartosz Golaszewski
2019-10-19 11:02 ` Andy Shevchenko
2019-10-21 10:35 ` Daniel Thompson
2019-10-19 8:35 ` [PATCH v6 3/9] backlight: gpio: explicitly set the direction of the GPIO Bartosz Golaszewski
2019-10-21 10:45 ` Daniel Thompson
2019-10-21 12:21 ` Bartosz Golaszewski
2019-10-19 8:35 ` [PATCH v6 4/9] sh: ecovec24: add additional properties to the backlight device Bartosz Golaszewski
2019-10-19 8:35 ` [PATCH v6 5/9] backlight: gpio: simplify the platform data handling Bartosz Golaszewski
2019-10-19 8:35 ` [PATCH v6 6/9] sh: ecovec24: don't set unused fields in platform data Bartosz Golaszewski
2019-10-19 8:35 ` [PATCH v6 7/9] backlight: gpio: remove unused fields from " Bartosz Golaszewski
2019-10-19 8:35 ` [PATCH v6 8/9] backlight: gpio: use a helper variable for &pdev->dev Bartosz Golaszewski
2019-10-19 8:35 ` [PATCH v6 9/9] backlight: gpio: pull gpio_backlight_initial_power_state() into probe Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019083556.19466-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=dalias@libc.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo@jmondi.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).