From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Tue, 05 Nov 2019 10:17:44 +0000 Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table Message-Id: <20191105101744.kzdpopq25slbfuue@holly.lan> List-Id: References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Walleij Cc: Arnd Bergmann , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Linux ARM , "linux-kernel@vger.kernel.org" , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , "open list:DRM PANEL DRIVERS" , Linux Fbdev development list On Tue, Nov 05, 2019 at 11:04:44AM +0100, Linus Walleij wrote: > On Fri, Oct 18, 2019 at 5:43 PM Arnd Bergmann wrote: > > > The driver should not require a machine specific header. Change > > it to pass the gpio line through a lookup table, and move the > > timing generator definitions into the drivers itself. > > > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Cc: Bartlomiej Zolnierkiewicz > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-fbdev@vger.kernel.org > > Signed-off-by: Arnd Bergmann > > > > --- > > I'm not overly confident that I got the correct device names > > for the lookup table, it would be good if someone could > > double-check. > > You're anyway doing more than required for the people who > may or may not be using this platform. Brokenness can surely > be fixed later, it's not like we are taking down the entire Amazon > cloud or something. > > Reviewed-by: Linus Walleij Same here. I read, I did't see anything wrong but I can't test. Reviewed-by: Daniel Thompson Daniel.