From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Chamberlain Date: Wed, 13 Nov 2019 18:45:05 +0000 Subject: Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Message-Id: <20191113184505.GW11244@42.do-not-panic.com> List-Id: References: <20191111192258.2234502-1-arnd@arndb.de> <20191112105507.GA7122@lst.de> <20191112140631.GA10922@lst.de> <20191112222423.GO11244@42.do-not-panic.com> <20191113072708.GA3213@lst.de> <20191113093154.GB32742@smile.fi.intel.com> In-Reply-To: <20191113093154.GB32742@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andy Shevchenko Cc: Linux Fbdev development list , linux-ia64@vger.kernel.org, Daniel Vetter , dri-devel , "H. Peter Anvin" , Lee Jones , Christoph Hellwig , X86 ML , Ingo Molnar , Tuowen Zhao , Fenghua Yu , Arnd Bergmann , Bartlomiej Zolnierkiewicz , "Luis R. Rodriguez" , Borislav Petkov , Thomas Gleixner , Mika Westerberg , Juergen Gross , Tony Luck , Linux Kernel Mailing List , AceLan Kao , Souptick Joarder , Roman Gilg On Wed, Nov 13, 2019 at 11:31:54AM +0200, Andy Shevchenko wrote: > On Wed, Nov 13, 2019 at 08:38:15AM +0100, Arnd Bergmann wrote: > > On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig wrote: > > > > > > On Tue, Nov 12, 2019 at 10:24:23PM +0000, Luis Chamberlain wrote: > > > > I think this would be possible if we could flop ioremap_nocache() to UC > > > > instead of UC- on x86. Otherwise, I can't see how we can remove this by > > > > still not allowing direct MTRR calls. > > > > > > If everything goes well ioremap_nocache will be gone as of 5.5. > > > > As ioremap_nocache() just an alias for ioremap(), I suppose the idea would > > then be to make x86 ioremap be UC instead of UC-, again matching what the > > other architectures do already. > > I think it's right thing to do, i.e. assume that ioremap() always does strong > UC independently on MTRR settings. Agreed wholeheartedly. What are the blockers from making that happen? Do we have any left? Luis