Re: [PATCH 08/13] video: fbdev: make fbops member of struct fb_info a const pointer

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3344 bytes --]

Hi Jani,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.4 next-20191127]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jani-Nikula/video-drm-constify-fbops-in-struct-fb_info/20191128-022047
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/udl/udl_fb.c: In function 'udl_fb_release':
>> drivers/gpu/drm/udl/udl_fb.c:256:24: error: assignment of member 'fb_mmap' in read-only object
      info->fbops->fb_mmap = udl_fb_mmap;
                           ^

vim +/fb_mmap +256 drivers/gpu/drm/udl/udl_fb.c

5320918b9a8786 Dave Airlie     2010-12-15  240  
5320918b9a8786 Dave Airlie     2010-12-15  241  
5320918b9a8786 Dave Airlie     2010-12-15  242  /*
5320918b9a8786 Dave Airlie     2010-12-15  243   * Assumes caller is holding info->lock mutex (for open and release at least)
5320918b9a8786 Dave Airlie     2010-12-15  244   */
5320918b9a8786 Dave Airlie     2010-12-15  245  static int udl_fb_release(struct fb_info *info, int user)
5320918b9a8786 Dave Airlie     2010-12-15  246  {
5320918b9a8786 Dave Airlie     2010-12-15  247  	struct udl_fbdev *ufbdev = info->par;
5320918b9a8786 Dave Airlie     2010-12-15  248  
5320918b9a8786 Dave Airlie     2010-12-15  249  	ufbdev->fb_count--;
5320918b9a8786 Dave Airlie     2010-12-15  250  
2b721f20770ccb Daniel Vetter   2016-08-10  251  #ifdef CONFIG_DRM_FBDEV_EMULATION
5320918b9a8786 Dave Airlie     2010-12-15  252  	if ((ufbdev->fb_count == 0) && (info->fbdefio)) {
5320918b9a8786 Dave Airlie     2010-12-15  253  		fb_deferred_io_cleanup(info);
5320918b9a8786 Dave Airlie     2010-12-15  254  		kfree(info->fbdefio);
5320918b9a8786 Dave Airlie     2010-12-15  255  		info->fbdefio = NULL;
5320918b9a8786 Dave Airlie     2010-12-15 @256  		info->fbops->fb_mmap = udl_fb_mmap;
5320918b9a8786 Dave Airlie     2010-12-15  257  	}
2b721f20770ccb Daniel Vetter   2016-08-10  258  #endif
5320918b9a8786 Dave Airlie     2010-12-15  259  
90991209837ab6 Mikulas Patocka 2018-06-03  260  	pr_debug("released /dev/fb%d user=%d count=%d\n",
5320918b9a8786 Dave Airlie     2010-12-15  261  		info->node, user, ufbdev->fb_count);
5320918b9a8786 Dave Airlie     2010-12-15  262  
5320918b9a8786 Dave Airlie     2010-12-15  263  	return 0;
5320918b9a8786 Dave Airlie     2010-12-15  264  }
5320918b9a8786 Dave Airlie     2010-12-15  265  

:::::: The code at line 256 was first introduced by commit
:::::: 5320918b9a87865223fd6b228e530bf30bc64d9d drm/udl: initial UDL driver (v4)

:::::: TO: Dave Airlie <airlied@gmail.com>
:::::: CC: Dave Airlie <airlied@redhat.com>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70378 bytes --]