* [PATCH] fbdev: remove object duplication in Makefile
@ 2020-01-06 8:13 ` Masahiro Yamada
2020-01-15 16:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2020-01-06 8:13 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, dri-devel
Cc: Masahiro Yamada, linux-fbdev, linux-kernel
The objects in $(fb-objs) $(fb-y) $(fb-m) are linked to fb.ko .
This line adds $(fb-y) to fb-objs, so the objects from $(fb-y) are
listed twice as the dependency of the module.
It works because Kbuild trims the duplicated objects from linking,
but there is no good reason to have this line.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
drivers/video/fbdev/core/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/Makefile
index 37710316a680..26cbc965497c 100644
--- a/drivers/video/fbdev/core/Makefile
+++ b/drivers/video/fbdev/core/Makefile
@@ -16,7 +16,6 @@ fb-y += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \
fbcon_ccw.o
endif
endif
-fb-objs := $(fb-y)
obj-$(CONFIG_FB_CFB_FILLRECT) += cfbfillrect.o
obj-$(CONFIG_FB_CFB_COPYAREA) += cfbcopyarea.o
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: remove object duplication in Makefile
2020-01-06 8:13 ` [PATCH] fbdev: remove object duplication in Makefile Masahiro Yamada
@ 2020-01-15 16:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-15 16:15 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-fbdev, linux-kernel, dri-devel
On 1/6/20 9:13 AM, Masahiro Yamada wrote:
> The objects in $(fb-objs) $(fb-y) $(fb-m) are linked to fb.ko .
>
> This line adds $(fb-y) to fb-objs, so the objects from $(fb-y) are
> listed twice as the dependency of the module.
>
> It works because Kbuild trims the duplicated objects from linking,
> but there is no good reason to have this line.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Patch queued for v5.6, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
>
> drivers/video/fbdev/core/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/Makefile
> index 37710316a680..26cbc965497c 100644
> --- a/drivers/video/fbdev/core/Makefile
> +++ b/drivers/video/fbdev/core/Makefile
> @@ -16,7 +16,6 @@ fb-y += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \
> fbcon_ccw.o
> endif
> endif
> -fb-objs := $(fb-y)
>
> obj-$(CONFIG_FB_CFB_FILLRECT) += cfbfillrect.o
> obj-$(CONFIG_FB_CFB_COPYAREA) += cfbcopyarea.o
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200106081436epcas5p3dc6a4023510ef179e9ce94a056c75fb8@epcas5p3.samsung.com>
2020-01-06 8:13 ` [PATCH] fbdev: remove object duplication in Makefile Masahiro Yamada
2020-01-15 16:15 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).