From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Wed, 22 Jan 2020 10:55:40 +0000 Subject: Re: [PATCH -next v2] backlight: qcom-wled: fix unsigned comparison to zero Message-Id: <20200122105540.w5vrvs34zxmhkjae@holly.lan> List-Id: References: <20200122013240.132861-1-chenzhou10@huawei.com> In-Reply-To: <20200122013240.132861-1-chenzhou10@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chen Zhou Cc: linux-fbdev@vger.kernel.org, kgunda@codeaurora.org, b.zolnierkie@samsung.com, jingoohan1@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, lee.jones@linaro.org On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote: > Fixes coccicheck warning: > ./drivers/video/backlight/qcom-wled.c:1104:5-15: > WARNING: Unsigned expression compared with zero: string_len > 0 > > The unsigned variable string_len is assigned a return value from the call > to of_property_count_elems_of_size(), which may return negative error code. > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") > Signed-off-by: Chen Zhou > Reviewed-by: Bjorn Andersson Reviewed-by: Daniel Thompson > --- > > changes in v2: > - fix commit message description. > > --- > drivers/video/backlight/qcom-wled.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index d46052d..3d276b3 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version) > struct wled_config *cfg = &wled->cfg; > struct device *dev = wled->dev; > const __be32 *prop_addr; > - u32 size, val, c, string_len; > - int rc, i, j; > + u32 size, val, c; > + int rc, i, j, string_len; > > const struct wled_u32_opts *u32_opts = NULL; > const struct wled_u32_opts wled3_opts[] = { > -- > 2.7.4 >