From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oliver Graute <oliver.graute@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
gregkh@linuxfoundation.org,
Oliver Graute <oliver.graute@kococonnector.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
Date: Thu, 09 Apr 2020 10:14:16 +0000 [thread overview]
Message-ID: <20200409101416.GN2001@kadam> (raw)
In-Reply-To: <1586424250-25897-1-git-send-email-oliver.graute@gmail.com>
On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> From: Oliver Graute <oliver.graute@kococonnector.com>
>
> Enable inversion mode
>
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> ---
> drivers/staging/fbtft/fb_st7789v.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
> index 3c3f387936e8..84c5af2dc9a0 100644
> --- a/drivers/staging/fbtft/fb_st7789v.c
> +++ b/drivers/staging/fbtft/fb_st7789v.c
> @@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, PWCTRL1, 0xA4, 0xA1);
>
> write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
> +
> + /* enable inversion mode */
> + write_reg(par, 0x21);
Use the define and delete the comment.
write_reg(par, MIPI_DCS_ENTER_INVERT_MODE);
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-09 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 9:24 [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion Oliver Graute
2020-04-09 10:14 ` Dan Carpenter [this message]
2020-04-27 8:31 ` Oliver Graute
2020-04-09 10:15 ` Dan Carpenter
2020-04-27 8:29 ` Oliver Graute
2020-04-28 18:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409101416.GN2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.graute@gmail.com \
--cc=oliver.graute@kococonnector.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).