From: Daniel Thompson <daniel.thompson@linaro.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: linux-fbdev@vger.kernel.org, kgunda@codeaurora.org,
b.zolnierkie@samsung.com, jingoohan1@gmail.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
bjorn.andersson@linaro.org, Hulk Robot <hulkci@huawei.com>,
agross@kernel.org, linux-arm-msm@vger.kernel.org,
lee.jones@linaro.org
Subject: Re: [PATCH] backlight: qcom-wled: remove 'wled4_string_cfg' and 'wled3_string_cfg'
Date: Mon, 20 Apr 2020 15:21:14 +0000 [thread overview]
Message-ID: <20200420152114.b7licril3r6itd45@holly.lan> (raw)
In-Reply-To: <20200417092335.14163-1-yanaijie@huawei.com>
On Fri, Apr 17, 2020 at 05:23:35PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/video/backlight/qcom-wled.c:939:34: warning: ‘wled4_string_cfg’
> defined but not used [-Wunused-const-variable=]
> static const struct wled_var_cfg wled4_string_cfg = {
> ^~~~~~~~~~~~~~~~
> drivers/video/backlight/qcom-wled.c:935:34: warning: ‘wled3_string_cfg’
> defined but not used [-Wunused-const-variable=]
> static const struct wled_var_cfg wled3_string_cfg = {
> ^~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/qcom-wled.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
> index 3d276b30a78c..df53fbd5cd03 100644
> --- a/drivers/video/backlight/qcom-wled.c
> +++ b/drivers/video/backlight/qcom-wled.c
> @@ -932,14 +932,6 @@ static const struct wled_var_cfg wled4_string_i_limit_cfg = {
> .size = ARRAY_SIZE(wled4_string_i_limit_values),
> };
>
> -static const struct wled_var_cfg wled3_string_cfg = {
> - .size = 8,
> -};
> -
> -static const struct wled_var_cfg wled4_string_cfg = {
> - .size = 16,
> -};
> -
> static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx)
> {
> if (idx >= cfg->size)
> --
> 2.21.1
>
prev parent reply other threads:[~2020-04-20 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 8:59 [PATCH] backlight: qcom-wled: remove 'wled4_string_cfg' and 'wled3_string_cfg' Jason Yan
2020-04-20 15:21 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420152114.b7licril3r6itd45@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=agross@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hulkci@huawei.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).