From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dejin Zheng Date: Wed, 22 Apr 2020 16:07:19 +0000 Subject: [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address Message-Id: <20200422160719.27763-1-zhengdejin5@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, b.zolnierkie@samsung.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Dejin Zheng , Andy Shevchenko , linux-kernel@vger.kernel.org the sfb->fb->screen_base is not save the value get by iounmap() when the chip id is 0x720. so iounmap() for address sfb->fb->screen_base is not right. Fixes: 1461d6672864854 ("staging: sm7xxfb: merge sm712fb with fbdev") CC: Andy Shevchenko Signed-off-by: Dejin Zheng --- drivers/video/fbdev/sm712fb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c index 6a1b4a853d9e..8cd655d6d628 100644 --- a/drivers/video/fbdev/sm712fb.c +++ b/drivers/video/fbdev/sm712fb.c @@ -1429,6 +1429,8 @@ static int smtc_map_smem(struct smtcfb_info *sfb, static void smtc_unmap_smem(struct smtcfb_info *sfb) { if (sfb && sfb->fb->screen_base) { + if (sfb->chip_id = 0x720) + sfb->fb->screen_base -= 0x00200000; iounmap(sfb->fb->screen_base); sfb->fb->screen_base = NULL; } -- 2.25.0