From: Dejin Zheng <zhengdejin5@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-fbdev@vger.kernel.org,
"Thomas Bogendörfer" <tsbogend@alpha.franken.de>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Florian Tobias Schandinat" <FlorianSchandinat@gmx.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Ralf Bächle" <ralf@linux-mips.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [PATCH v1] console: fix an issue about ioremap leak.
Date: Thu, 23 Apr 2020 14:29:09 +0000 [thread overview]
Message-ID: <20200423142909.GB1562@nuc8i5> (raw)
In-Reply-To: <c62ec54f-348b-2eae-59eb-374dde4d49ad@web.de>
On Thu, Apr 23, 2020 at 01:10:14PM +0200, Markus Elfring wrote:
> > if do_take_over_console() return an error in the newport_probe(),
> > due to the io virtual address is not released, it will cause a leak.
>
> How do you think about a wording variant like the following?
>
> Subject:
> [PATCH v2] console: Complete exception handling in newport_probe()
>
> Change description:
> A call of the function “do_take_over_console” can fail here.
> The corresponding system resources were not released then.
> Thus add a call of the function “iounmap” together with the check
> of a failure predicate.
>
Thanks!
>
> I would like to point out that there is a script for the semantic
> patch language which would detect other questionable source code.
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci
>
> How do you think about to extend presented software analysis approaches?
>
Sorry, I am not familiar with it, I don't know.
BR,
Dejin
> Regards,
> Markus
next prev parent reply other threads:[~2020-04-23 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:53 [PATCH v1] console: fix an issue about ioremap leak Dejin Zheng
2020-04-23 11:10 ` Markus Elfring
2020-04-23 14:29 ` Dejin Zheng [this message]
2020-04-23 15:23 ` console: Complete exception handling in newport_probe() Markus Elfring
2020-04-23 17:02 ` Dejin Zheng
2020-04-23 17:22 ` Markus Elfring
2020-04-23 17:32 ` Greg Kroah-Hartman
2020-04-23 17:43 ` Markus Elfring
2020-04-24 7:46 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423142909.GB1562@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=FlorianSchandinat@gmx.de \
--cc=Markus.Elfring@web.de \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=cocci@systeme.lip6.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).