From: Sam Ravnborg <sam@ravnborg.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, b.zolnierkie@samsung.com
Subject: Re: [PATCH] video: fbdev: i810: use true,false for bool variables
Date: Wed, 06 May 2020 17:40:52 +0000 [thread overview]
Message-ID: <20200506174052.GF19296@ravnborg.org> (raw)
In-Reply-To: <20200422071826.49038-1-yanaijie@huawei.com>
On Wed, Apr 22, 2020 at 03:18:26PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/video/fbdev/i810/i810_main.c:1969:3-7: WARNING: Assignment of
> 0/1 to bool variable
> drivers/video/fbdev/i810/i810_main.c:1971:3-8: WARNING: Assignment of
> 0/1 to bool variable
> drivers/video/fbdev/i810/i810_main.c:1973:3-9: WARNING: Assignment of
> 0/1 to bool variable
> drivers/video/fbdev/i810/i810_main.c:1975:3-7: WARNING: Assignment of
> 0/1 to bool variable
> drivers/video/fbdev/i810/i810_main.c:2001:3-9: WARNING: Assignment of
> 0/1 to bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Thanks.
I have pushed this and your other three patches to drm-misc-next.
They will show up in the mainline kernel in the next merge window.
Sam
> ---
> drivers/video/fbdev/i810/i810_main.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
> index aa7583d963ac..13bbf7fe13bf 100644
> --- a/drivers/video/fbdev/i810/i810_main.c
> +++ b/drivers/video/fbdev/i810/i810_main.c
> @@ -1966,13 +1966,13 @@ static int i810fb_setup(char *options)
>
> while ((this_opt = strsep(&options, ",")) != NULL) {
> if (!strncmp(this_opt, "mtrr", 4))
> - mtrr = 1;
> + mtrr = true;
> else if (!strncmp(this_opt, "accel", 5))
> - accel = 1;
> + accel = true;
> else if (!strncmp(this_opt, "extvga", 6))
> - extvga = 1;
> + extvga = true;
> else if (!strncmp(this_opt, "sync", 4))
> - sync = 1;
> + sync = true;
> else if (!strncmp(this_opt, "vram:", 5))
> vram = (simple_strtoul(this_opt+5, NULL, 0));
> else if (!strncmp(this_opt, "voffset:", 8))
> @@ -1998,7 +1998,7 @@ static int i810fb_setup(char *options)
> else if (!strncmp(this_opt, "vsync2:", 7))
> vsync2 = simple_strtoul(this_opt+7, NULL, 0);
> else if (!strncmp(this_opt, "dcolor", 6))
> - dcolor = 1;
> + dcolor = true;
> else if (!strncmp(this_opt, "ddc3", 4))
> ddc3 = true;
> else
> --
> 2.21.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-05-06 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:18 [PATCH] video: fbdev: i810: use true,false for bool variables Jason Yan
2020-05-06 17:40 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506174052.GF19296@ravnborg.org \
--to=sam@ravnborg.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).