From: Emil Velikov <emil.l.velikov@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org, emil.l.velikov@gmail.com,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete
Date: Sun, 17 May 2020 22:05:23 +0000 [thread overview]
Message-ID: <20200517220524.4036334-1-emil.l.velikov@gmail.com> (raw)
Drivers have not seen any love for years.
Be that fixes or improvements, or cosmetics like introducing symbolic
names, style and code-flow polish.
Seemingly the maintainer has also disappeared years ago :-\
Considering nouveau supports all that hardware (modulo nv03) just mark
these as obsolete/broken, referring to nouveau in the help text.
v2 (Bartlomiej):
- split config changes into separate patch
- spell out nouveau DRM driver
- don't use BROKEN
- add runtime warning
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v1)
---
MAINTAINERS | 3 +--
drivers/video/fbdev/Kconfig | 4 ++++
drivers/video/fbdev/nvidia/nvidia.c | 3 +++
drivers/video/fbdev/riva/fbdev.c | 3 +++
4 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 938316092634..c9498dd15e4a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12055,9 +12055,8 @@ F: include/linux/nubus.h
F: include/uapi/linux/nubus.h
NVIDIA (rivafb and nvidiafb) FRAMEBUFFER DRIVER
-M: Antonino Daplas <adaplas@gmail.com>
L: linux-fbdev@vger.kernel.org
-S: Maintained
+S: Obsolete
F: drivers/video/fbdev/nvidia/
F: drivers/video/fbdev/riva/
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index fa88e8b9a83d..ccddd06ab430 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -881,6 +881,8 @@ config FB_NVIDIA
select BITREVERSE
select VGASTATE
help
+ Obsolete, use the nouveau DRM driver instead.
+
This driver supports graphics boards with the nVidia chips, TNT
and newer. For very old chipsets, such as the RIVA128, then use
the rivafb.
@@ -928,6 +930,8 @@ config FB_RIVA
select BITREVERSE
select VGASTATE
help
+ Obsolete, use the nouveau DRM driver instead.
+
This driver supports graphics boards with the nVidia Riva/Geforce
chips.
Say Y if you have such a graphics board.
diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c
index c24de9107958..a958612ef75b 100644
--- a/drivers/video/fbdev/nvidia/nvidia.c
+++ b/drivers/video/fbdev/nvidia/nvidia.c
@@ -1512,6 +1512,9 @@ static struct pci_driver nvidiafb_driver = {
static int nvidiafb_init(void)
{
+ pr_warn("Legacy nvidiafb framebuffer driver will be removed in 2022\n"
+ "Please switch to nouveau DRM driver\n");
+
#ifndef MODULE
char *option = NULL;
diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index 764ec3285e62..c2788e22f5c1 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c
@@ -2160,6 +2160,9 @@ static struct pci_driver rivafb_driver = {
static int rivafb_init(void)
{
+ pr_warn("Legacy rivafb framebuffer driver will be removed in 2022\n"
+ "Please switch to nouveau DRM driver\n");
+
#ifndef MODULE
char *option = NULL;
--
2.25.1
next reply other threads:[~2020-05-17 22:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 22:05 Emil Velikov [this message]
2020-05-17 22:05 ` [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau Emil Velikov
2020-05-18 0:44 ` Benjamin Herrenschmidt
2020-05-18 11:00 ` Emil Velikov
2020-05-18 12:39 ` Benjamin Herrenschmidt
2020-05-18 7:30 ` Michael Ellerman
2020-05-18 11:19 ` Emil Velikov
2020-05-18 12:46 ` Benjamin Herrenschmidt
2020-05-18 12:48 ` Bartlomiej Zolnierkiewicz
2020-05-18 13:19 ` Emil Velikov
2020-05-18 13:48 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517220524.4036334-1-emil.l.velikov@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).