From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Tue, 16 Jun 2020 14:41:22 +0000 Subject: Re: [RFC PATCH 0/4] DirectX on Linux Message-Id: <20200616144122.GA18447@duo.ucw.cz> MIME-Version: 1 Content-Type: multipart/mixed; boundary="BOKacYhQ+x31HxR3" List-Id: References: <20200519163234.226513-1-sashal@kernel.org> <55c57049-1869-7421-aa0f-3ce0b6a133cf@suse.de> <20200616105112.GC1718@bug> <20200616132819.GP1931@sasha-vm> In-Reply-To: <20200616132819.GP1931@sasha-vm> To: Sasha Levin Cc: linux-hyperv@vger.kernel.org, sthemmin@microsoft.com, tvrtko.ursulin@intel.com, gregkh@linuxfoundation.org, haiyangz@microsoft.com, spronovo@microsoft.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, linux-fbdev@vger.kernel.org, wei.liu@kernel.org, Thomas Zimmermann , iourit@microsoft.com, alexander.deucher@amd.com, kys@microsoft.com, Hawking.Zhang@amd.com --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2020-06-16 09:28:19, Sasha Levin wrote: > On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote: > > Hi! > >=20 > > > > The driver creates the /dev/dxg device, which can be opened by user= mode > > > > application and handles their ioctls. The IOCTL interface to the dr= iver > > > > is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl > > > > definitions). The interface matches the D3DKMT interface on Windows. > > > > Ioctls are implemented in ioctl.c. > > >=20 > > > Echoing what others said, you're not making a DRM driver. The driver = should live outside > > > of the DRM code. > > >=20 > >=20 > > Actually, this sounds to me like "this should not be merged into linux = kernel". I mean, > > we already have DRM API on Linux. We don't want another one, do we? >=20 > This driver doesn't have any display functionality. Graphics cards without displays connected are quite common. I may be wrong, but I believe we normally handle them using DRM... > > And at the very least... this misses API docs for /dev/dxg. Code can't = really > > be reviewed without that. >=20 > The docs live here: https://docs.microsoft.com/en-us/windows-hardware/dri= vers/ddi/d3dkmthk/ I don't see "/dev/dxg" being metioned there. Plus, kernel API documentation should really go to Documentation, and be suitably licensed. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXujaEgAKCRAw5/Bqldv6 8q/JAKCQjRPnkrFqnsMWU0xDN/FHE1enzwCeMHA4YAkm0yQfrg+8eKiMWa/ARU8= =bHer -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--