From: Sam Ravnborg <sam@ravnborg.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Jason Yan <yanaijie@huawei.com>
Subject: Re: [PATCH v2] video: fbdev: uvesafb: fix "noblank" option handling
Date: Sun, 21 Jun 2020 08:13:54 +0000 [thread overview]
Message-ID: <20200621081354.GI74146@ravnborg.org> (raw)
In-Reply-To: <81c9f140-d6fb-803a-18c8-04dae1007ab3@samsung.com>
On Tue, Jun 09, 2020 at 11:29:43AM +0200, Bartlomiej Zolnierkiewicz wrote:
> Fix the recent regression.
>
> Fixes: dbc7ece12a38 ("video: uvesafb: use true,false for bool variables")
> Cc: Jason Yan <yanaijie@huawei.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Hi Bartlomiej
I was processing drm-misc-fixes patches so I went ahead and applied
this.
Thanks for fixing this up.
Sam
> ---
> v2:
> - added Reviewed-by tag from Sam
> - removed no longer working Michal's email address from Cc:
>
> drivers/video/fbdev/uvesafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/video/fbdev/uvesafb.c
> =================================> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -1836,7 +1836,7 @@ static int uvesafb_setup(char *options)
> else if (!strcmp(this_opt, "noedid"))
> noedid = true;
> else if (!strcmp(this_opt, "noblank"))
> - blank = true;
> + blank = false;
> else if (!strncmp(this_opt, "vtotal:", 7))
> vram_total = simple_strtoul(this_opt + 7, NULL, 0);
> else if (!strncmp(this_opt, "vremap:", 7))
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-06-21 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200422071952eucas1p219bc9ef0a74220149966ecb03688681c@eucas1p2.samsung.com>
2020-04-22 7:18 ` [PATCH] video: uvesafb: use true,false for bool variables Jason Yan
2020-06-01 10:37 ` Bartlomiej Zolnierkiewicz
2020-06-02 20:50 ` Sam Ravnborg
2020-06-09 9:29 ` [PATCH v2] video: fbdev: uvesafb: fix "noblank" option handling Bartlomiej Zolnierkiewicz
2020-06-21 8:13 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200621081354.GI74146@ravnborg.org \
--to=sam@ravnborg.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).