From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Thu, 25 Jun 2020 09:41:26 +0000 Subject: Re: [PATCH 4/8] backlight: ili922x: Remove invalid use of kerneldoc syntax Message-Id: <20200625094126.jp5e7x64sjdu7med@holly.lan> List-Id: References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-5-lee.jones@linaro.org> In-Reply-To: <20200624145721.2590327-5-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org On Wed, Jun 24, 2020 at 03:57:17PM +0100, Lee Jones wrote: > Kerneldoc is for documenting function arguments and return values. > > Prevents warnings like: > > drivers/video/backlight/ili922x.c:127: warning: cannot understand function prototype: 'int ili922x_id = 1; ' > drivers/video/backlight/ili922x.c:136: warning: cannot understand function prototype: 'struct ili922x ' > > Cc: > Cc: Bartlomiej Zolnierkiewicz > Cc: Software Engineering > Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/ili922x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > index 8cb4b9d3c3bba..cd41433b87aeb 100644 > --- a/drivers/video/backlight/ili922x.c > +++ b/drivers/video/backlight/ili922x.c > @@ -123,7 +123,7 @@ > > #define set_tx_byte(b) (tx_invert ? ~(b) : b) > > -/** > +/* > * ili922x_id - id as set by manufacturer > */ > static int ili922x_id = 1; > @@ -132,7 +132,7 @@ module_param(ili922x_id, int, 0); > static int tx_invert; > module_param(tx_invert, int, 0); > > -/** > +/* > * driver's private structure > */ > struct ili922x { > -- > 2.25.1 >