* [PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity'
@ 2020-07-21 13:48 Wei Yongjun
2020-07-21 14:47 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-21 13:48 UTC (permalink / raw)
To: Hulk Robot, Lee Jones, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Sam Ravnborg
Cc: linux-fbdev, Wei Yongjun, dri-devel
Gcc report unused-variable warning as follows:
drivers/video/backlight/cr_bllcd.c:62:6: warning:
unused variable 'intensity' [-Wunused-variable]
62 | int intensity = bd->props.brightness;
| ^~~~~~~~~
After commit 24d34617c24f ("backlight: cr_bllcd: Introduce
gpio-backlight semantics"), this variable is never used, this
commit removing it.
Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/video/backlight/cr_bllcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c
index a24d42e1ea3c..4ad0a72531fe 100644
--- a/drivers/video/backlight/cr_bllcd.c
+++ b/drivers/video/backlight/cr_bllcd.c
@@ -59,7 +59,6 @@ struct cr_panel {
static int cr_backlight_set_intensity(struct backlight_device *bd)
{
- int intensity = bd->props.brightness;
u32 addr = gpio_bar + CRVML_PANEL_PORT;
u32 cur = inl(addr);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity'
2020-07-21 13:48 [PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity' Wei Yongjun
@ 2020-07-21 14:47 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-07-21 14:47 UTC (permalink / raw)
To: Wei Yongjun
Cc: Daniel Thompson, Bartlomiej Zolnierkiewicz, Jingoo Han,
linux-fbdev, dri-devel, Hulk Robot, Sam Ravnborg
On Tue, 21 Jul 2020, Wei Yongjun wrote:
> Gcc report unused-variable warning as follows:
>
> drivers/video/backlight/cr_bllcd.c:62:6: warning:
> unused variable 'intensity' [-Wunused-variable]
> 62 | int intensity = bd->props.brightness;
> | ^~~~~~~~~
>
> After commit 24d34617c24f ("backlight: cr_bllcd: Introduce
> gpio-backlight semantics"), this variable is never used, this
> commit removing it.
>
> Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/video/backlight/cr_bllcd.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks for the patch, but this has already been fixed.
> diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c
> index a24d42e1ea3c..4ad0a72531fe 100644
> --- a/drivers/video/backlight/cr_bllcd.c
> +++ b/drivers/video/backlight/cr_bllcd.c
> @@ -59,7 +59,6 @@ struct cr_panel {
>
> static int cr_backlight_set_intensity(struct backlight_device *bd)
> {
> - int intensity = bd->props.brightness;
> u32 addr = gpio_bar + CRVML_PANEL_PORT;
> u32 cur = inl(addr);
>
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-21 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-21 13:48 [PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity' Wei Yongjun
2020-07-21 14:47 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).