* [PATCH] video: backlight: sky81452-backlight: Fix refcount imbalance on error
@ 2020-08-19 3:04 Dinghao Liu
2020-08-19 10:36 ` Daniel Thompson
0 siblings, 1 reply; 2+ messages in thread
From: Dinghao Liu @ 2020-08-19 3:04 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Daniel Thompson, Bartlomiej Zolnierkiewicz, Jingoo Han, Bryan Wu,
Gyungoh Yoo, linux-fbdev, dri-devel, linux-kernel, Lee Jones
When of_property_read_u32_array() returns an error code, a
pairing refcount decrement is needed to keep np's refcount
balanced.
Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
drivers/video/backlight/sky81452-backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
index 0ce181585008..8268ac43d54f 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
num_entry);
if (ret < 0) {
dev_err(dev, "led-sources node is invalid.\n");
+ of_node_put(np);
return ERR_PTR(-EINVAL);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] video: backlight: sky81452-backlight: Fix refcount imbalance on error
2020-08-19 3:04 [PATCH] video: backlight: sky81452-backlight: Fix refcount imbalance on error Dinghao Liu
@ 2020-08-19 10:36 ` Daniel Thompson
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Thompson @ 2020-08-19 10:36 UTC (permalink / raw)
To: Dinghao Liu
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, kjlu, Bryan Wu,
Gyungoh Yoo, linux-kernel, dri-devel, Jingoo Han, Lee Jones
On Wed, Aug 19, 2020 at 11:04:56AM +0800, Dinghao Liu wrote:
> When of_property_read_u32_array() returns an error code, a
> pairing refcount decrement is needed to keep np's refcount
> balanced.
>
> Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/sky81452-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
> index 0ce181585008..8268ac43d54f 100644
> --- a/drivers/video/backlight/sky81452-backlight.c
> +++ b/drivers/video/backlight/sky81452-backlight.c
> @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> num_entry);
> if (ret < 0) {
> dev_err(dev, "led-sources node is invalid.\n");
> + of_node_put(np);
> return ERR_PTR(-EINVAL);
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-19 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-19 3:04 [PATCH] video: backlight: sky81452-backlight: Fix refcount imbalance on error Dinghao Liu
2020-08-19 10:36 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).