From: Daniel Thompson <daniel.thompson@linaro.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
kjlu@umn.edu, Bryan Wu <cooloney@gmail.com>,
Gyungoh Yoo <jack.yoo@skyworksinc.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix refcount imbalance on error
Date: Wed, 19 Aug 2020 10:36:31 +0000 [thread overview]
Message-ID: <20200819103631.bptd34ij3fid4ych@holly.lan> (raw)
In-Reply-To: <20200819030456.7054-1-dinghao.liu@zju.edu.cn>
On Wed, Aug 19, 2020 at 11:04:56AM +0800, Dinghao Liu wrote:
> When of_property_read_u32_array() returns an error code, a
> pairing refcount decrement is needed to keep np's refcount
> balanced.
>
> Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/sky81452-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
> index 0ce181585008..8268ac43d54f 100644
> --- a/drivers/video/backlight/sky81452-backlight.c
> +++ b/drivers/video/backlight/sky81452-backlight.c
> @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> num_entry);
> if (ret < 0) {
> dev_err(dev, "led-sources node is invalid.\n");
> + of_node_put(np);
> return ERR_PTR(-EINVAL);
> }
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-08-19 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 3:04 [PATCH] video: backlight: sky81452-backlight: Fix refcount imbalance on error Dinghao Liu
2020-08-19 10:36 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819103631.bptd34ij3fid4ych@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=cooloney@gmail.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=dri-devel@lists.freedesktop.org \
--cc=jack.yoo@skyworksinc.com \
--cc=jingoohan1@gmail.com \
--cc=kjlu@umn.edu \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).