From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bhaskar Chowdhury Date: Wed, 16 Sep 2020 03:16:16 +0000 Subject: Re: [PATCH] docs: fb: Remove framebuffer scrollback option for boot Message-Id: <20200916030416.GA20404@Gentoo> MIME-Version: 1 Content-Type: multipart/mixed; boundary="NzB8fVQJ5HfG6fxh" List-Id: References: <20200915222511.17140-1-unixbhaskar@gmail.com> <20200916022552.GB13409@1wt.eu> In-Reply-To: <20200916022552.GB13409@1wt.eu> To: Willy Tarreau Cc: b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, rdunlap@infradead.org, gregkh@linuxfoundation.org, daniel@ffwll.ch, yuanmingbuaa@gmail.com, nopitydays@gmail.com, zhangyunhai@nsfocus.com, luto@amacapital.net, torvalds@linux-foundation.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04:25 Wed 16 Sep 2020, Willy Tarreau wrote: Thank you so much Willy. I am trying to get the essence of your mail ...few responses below.. >Bhaskar, > >your patches still all use very similar subjects and commit messages >which are pretty confusing as they only differ by words unrelated to >their real differences. It is important that the commit messages help >the reader guess what is being touched, so if you're splitting your >work into multiple patches, you need to indicate the difference in >each message. What I can propose to make things clearer: > > docs: fb: Remove framebuffer scrollback boot option > docs: fb: Remove matroxfb scrollback boot option > docs: fb: Remove sstfb scrollback boot option > docs: fb: Remove vesafb scrollback boot option > I would prefer to stick with this model , what you suggested with differe= nt subject and more relevant text. >Alternately they can all be merged into the first one under the same >name, but then the detailed commit message should specifically list >them. > >In addition below: > >On Wed, Sep 16, 2020 at 03:55:11AM +0530, Bhaskar Chowdhury wrote: >> This patch remove the scrollback option under boot options. >> Plus readjust the numbers for the options in that section. >>=20 >> Commit 973c096f6a85(vgacon: remove software scrollback support) >> Commit 50145474f6ef(fbcon: remove soft scrollback code) > >This is still not clear. The message should indicate the "why" more >than the "what" which can be figured from the patch. In addition, >only the fbcon commit is a cause for these changes. Last, Greg >mentioned that the format is 'commit xxx ("subject")'. > >What about this: > > The "scrollback" boot option was removed by commit 50145474f6ef > ("fbcon: remove soft scrollback code"), but the doc for fbcon was > not updated. This patch updates the fbcon doc and renumbers the > sections. > I lost it ...by head failed me ...do you want me copy more information text =66rom the actual commit?? >If you merge all your patches together, you can have this: > > The "scrollback" boot option was removed by commit 50145474f6ef > ("fbcon: remove soft scrollback code"), but the fb docs were not > updated. This patch removes reference to this option in the fbcon, > matroxfb, sstfb and vesafb docs and renumbers the sections as needed. > >And please increase your version so that it's more obvious that this >replaces previous series. Call it v3 or v4 or whatever higher than >the highest you've ever sent so that it's easier for your readers to >ignore the older ones. Ideally after your signed-off-by you should >add a "---" line with a quick changelog indicating what changed from >the previous ones (just for reviewers, this will not be merged), for >example: > Okay, before sending this new set ...yesterday I wrote a mail to everyone , that I wanted to get rid of this damn versioning thing and will sent patches afresh. So, ask everyone involved please ignore what have sent previously a= nd that mail too. I am sure that missed your eyes ...and I understand why :) But I am still reluctant to bump up the version number and would like to se= nt all the 4 patches AFRESH(which has nothing to do with the previous patchtes= I have sent) . Can I do that Willy???=20 > Signed-off-by: Bhaskar Chowdhury > --- > v3: clarify message description, update all fb drivers in the same patch > v2: reword commit message > This chainlog of information in the patch getting spirial and not helpful AFAIK. I mean, the version bumping and provide information appended to every other following mail. If that is significant then I understand ...but for t= his thing....I hope you get me... >Hoping this helps, >Willy --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAl9hgK0ACgkQsjqdtxFL KRVkZwgAjsi1Ci5jZXb9PSeHKrUiPeRimqYki9dhWdT6OprOtsISaI0wgKMo+sVO dDZFI3q79XXzSfWWnUein9YphuggOYL7AqaDl4iNF6v9XnGfJa9kOyQjKzLTdlq3 Uk4bHGCNOs+3KIlbK0Fqj1xldFoHquYcFEXURK4jEIJ35kEs5tdI5jgSMU6QLBK9 VKPJFbkX79VvYC8UUMNvSVtY4XI5jL53NXxmV+hA6jHc/OdmVzfeThmrbkfwwWDP P+t0U5l7tf6ZkWNi8bD6AXBa7a/QAuUYmgXf2xn7qj+Dc+Bo+i4SZniz1GALEWNm tbuVvN9Zne8EcQImopPMEpayfI6lxw== =4n40 -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--