From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Fri, 18 Sep 2020 12:42:03 +0000 Subject: Re: [PATCH v1] fbdev: aty: remove CONFIG_PM container Message-Id: <20200918124203.GY438822@phenom.ffwll.local> List-Id: References: <20200917115313.725622-1-vaibhavgupta40@gmail.com> In-Reply-To: <20200917115313.725622-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vaibhav Gupta Cc: linux-fbdev@vger.kernel.org, kernel test robot , Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andres Salomon , Bjorn Helgaas , Paul Mackerras , Sam Ravnborg , linux-geode@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org On Thu, Sep 17, 2020 at 05:23:14PM +0530, Vaibhav Gupta wrote: > The changes made in below mentioned commit removed CONFIG_PM containers > from drivers/video/fbdev/aty/atyfb_base.c but not from > drivers/video/fbdev/aty/atyfb.h for respective callbacks. > > This resulted in error for implicit declaration for those callbacks. > > Fixes: 348b2956d5e6 ("fbdev: aty: use generic power management") > > Signed-off-by: Vaibhav Gupta > Reported-by: kernel test robot Applied, thanks. -Daniel > --- > drivers/video/fbdev/aty/atyfb.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h > index a7833bc98225..551372f9b9aa 100644 > --- a/drivers/video/fbdev/aty/atyfb.h > +++ b/drivers/video/fbdev/aty/atyfb.h > @@ -287,8 +287,8 @@ static inline void aty_st_8(int regindex, u8 val, const struct atyfb_par *par) > #endif > } > > -#if defined(CONFIG_PM) || defined(CONFIG_PMAC_BACKLIGHT) || \ > -defined (CONFIG_FB_ATY_GENERIC_LCD) || defined (CONFIG_FB_ATY_BACKLIGHT) > +#if defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) || \ > +defined (CONFIG_FB_ATY_BACKLIGHT) > extern void aty_st_lcd(int index, u32 val, const struct atyfb_par *par); > extern u32 aty_ld_lcd(int index, const struct atyfb_par *par); > #endif > -- > 2.28.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch