From: Sam Ravnborg <sam@ravnborg.org>
To: Arnd Bergmann <arnd@arndb.de>,
linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"David S . Miller" <davem@davemloft.net>,
hch@lst.de, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] fbdev: stop using compat_alloc_user_space
Date: Thu, 24 Sep 2020 20:54:36 +0000 [thread overview]
Message-ID: <20200924205436.GP1223313@ravnborg.org> (raw)
In-Reply-To: <20200918124808.GD438822@phenom.ffwll.local>
Hi Daniel/Arnd.
On Fri, Sep 18, 2020 at 02:48:08PM +0200, Daniel Vetter wrote:
> On Fri, Sep 18, 2020 at 12:08:10PM +0200, Arnd Bergmann wrote:
> > The fbdev code uses compat_alloc_user_space in a few of its
> > compat_ioctl handlers, which tends to be a bit more complicated
> > and error-prone than calling the underlying handlers directly,
> > so I would like to remove it completely.
> >
> > This modifies two such functions in fbdev, and removes another
> > one that is completely unused.
> >
> > Arnd
> >
> > Arnd Bergmann (3):
> > fbdev: simplify fb_getput_cmap()
> > fbdev: sbuslib: remove unused FBIOSCURSOR32 helper
> > fbdev: sbuslib: remove compat_alloc_user_space usage
>
> Looks all good, but we're also kinda looking for a new volunteer for
> handling fbdev patches ... drm-misc commit rights, still not interested?
Hi Daniel - I read the above as an a-b. And Arnd did not take the bait
it seems.
Hi Arnd. checkpatch complained about some whitespace, which I fixed
while applying.
Will push to drm-misc-next tomorrow unless I hear anything else.
Sam
> -Daniel
>
> >
> > drivers/video/fbdev/core/fbmem.c | 44 +++++------
> > drivers/video/fbdev/sbuslib.c | 124 ++++++++++++++++++-------------
> > 2 files changed, 90 insertions(+), 78 deletions(-)
> >
> > --
> > 2.27.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-24 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 10:08 [PATCH 0/3] fbdev: stop using compat_alloc_user_space Arnd Bergmann
2020-09-18 10:09 ` [PATCH 1/3] fbdev: simplify fb_getput_cmap() Arnd Bergmann
2020-09-18 10:09 ` [PATCH 2/3] fbdev: sbuslib: remove unused FBIOSCURSOR32 helper Arnd Bergmann
2020-09-18 10:09 ` [PATCH 3/3] fbdev: sbuslib: remove compat_alloc_user_space usage Arnd Bergmann
2020-09-18 12:48 ` [PATCH 0/3] fbdev: stop using compat_alloc_user_space Daniel Vetter
2020-09-24 20:54 ` Sam Ravnborg [this message]
2020-09-25 11:31 ` Arnd Bergmann
2020-09-25 14:39 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924205436.GP1223313@ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).