* [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable
@ 2020-10-14 8:21 Xu Wang
2020-10-15 8:05 ` Thomas Zimmermann
2020-10-19 7:21 ` Thomas Zimmermann
0 siblings, 2 replies; 4+ messages in thread
From: Xu Wang @ 2020-10-14 8:21 UTC (permalink / raw)
To: b.zolnierkie, jani.nikula, daniel.vetter
Cc: linux-fbdev, linux-kernel, dri-devel
Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already
checked NULL clock parameter, so the additional checks are unnecessary,
just remove them.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/video/fbdev/au1100fb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
index 37a6512feda0..3659dfbb81c1 100644
--- a/drivers/video/fbdev/au1100fb.c
+++ b/drivers/video/fbdev/au1100fb.c
@@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
/* Blank the LCD */
au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info);
- if (fbdev->lcdclk)
- clk_disable(fbdev->lcdclk);
+ clk_disable(fbdev->lcdclk);
memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
@@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev)
memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs));
- if (fbdev->lcdclk)
- clk_enable(fbdev->lcdclk);
+ clk_enable(fbdev->lcdclk);
/* Unblank the LCD */
au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable
2020-10-14 8:21 [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Xu Wang
@ 2020-10-15 8:05 ` Thomas Zimmermann
2020-10-19 7:21 ` Thomas Zimmermann
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2020-10-15 8:05 UTC (permalink / raw)
To: Xu Wang
Cc: linux-fbdev, b.zolnierkie, jani.nikula, daniel.vetter,
linux-kernel, dri-devel
Hi
On Wed, 14 Oct 2020 08:21:37 +0000 Xu Wang <vulab@iscas.ac.cn> wrote:
> Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already
> checked NULL clock parameter, so the additional checks are unnecessary,
> just remove them.
All clk_*() functions seem to handle NULL pointers gracefully, so you can
also remove these checks from the driver's _probe and _remove functions.
Best regards
Thomas
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/video/fbdev/au1100fb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
> index 37a6512feda0..3659dfbb81c1 100644
> --- a/drivers/video/fbdev/au1100fb.c
> +++ b/drivers/video/fbdev/au1100fb.c
> @@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev,
> pm_message_t state) /* Blank the LCD */
> au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info);
>
> - if (fbdev->lcdclk)
> - clk_disable(fbdev->lcdclk);
> + clk_disable(fbdev->lcdclk);
>
> memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
>
> @@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev)
>
> memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs));
>
> - if (fbdev->lcdclk)
> - clk_enable(fbdev->lcdclk);
> + clk_enable(fbdev->lcdclk);
>
> /* Unblank the LCD */
> au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable
2020-10-14 8:21 [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Xu Wang
2020-10-15 8:05 ` Thomas Zimmermann
@ 2020-10-19 7:21 ` Thomas Zimmermann
2020-10-19 7:21 ` Thomas Zimmermann
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Zimmermann @ 2020-10-19 7:21 UTC (permalink / raw)
To: Xu Wang, b.zolnierkie, jani.nikula, daniel.vetter
Cc: linux-fbdev, linux-kernel, dri-devel
Hi
On 14.10.20 10:21, Xu Wang wrote:
> Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already
> checked NULL clock parameter, so the additional checks are unnecessary,
> just remove them.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Sam convinced me to merge this patch as-is with out the additional
cleanup of the driver. So
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
I'll merge it into drm-misc-next.
I'd still like to encourage you to send a patch for the other clk_*
calls in au1100fb.
Best regard
Thomas
> ---
> drivers/video/fbdev/au1100fb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
> index 37a6512feda0..3659dfbb81c1 100644
> --- a/drivers/video/fbdev/au1100fb.c
> +++ b/drivers/video/fbdev/au1100fb.c
> @@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
> /* Blank the LCD */
> au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info);
>
> - if (fbdev->lcdclk)
> - clk_disable(fbdev->lcdclk);
> + clk_disable(fbdev->lcdclk);
>
> memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
>
> @@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev)
>
> memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs));
>
> - if (fbdev->lcdclk)
> - clk_enable(fbdev->lcdclk);
> + clk_enable(fbdev->lcdclk);
>
> /* Unblank the LCD */
> au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable
2020-10-19 7:21 ` Thomas Zimmermann
@ 2020-10-19 7:21 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2020-10-19 7:21 UTC (permalink / raw)
To: Xu Wang, b.zolnierkie, jani.nikula, daniel.vetter
Cc: dri-devel, linux-fbdev, linux-kernel
Hi
On 14.10.20 10:21, Xu Wang wrote:
> Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already
> checked NULL clock parameter, so the additional checks are unnecessary,
> just remove them.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Sam convinced me to merge this patch as-is with out the additional
cleanup of the driver. So
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
I'll merge it into drm-misc-next.
I'd still like to encourage you to send a patch for the other clk_*
calls in au1100fb.
Best regard
Thomas
> ---
> drivers/video/fbdev/au1100fb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
> index 37a6512feda0..3659dfbb81c1 100644
> --- a/drivers/video/fbdev/au1100fb.c
> +++ b/drivers/video/fbdev/au1100fb.c
> @@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
> /* Blank the LCD */
> au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info);
>
> - if (fbdev->lcdclk)
> - clk_disable(fbdev->lcdclk);
> + clk_disable(fbdev->lcdclk);
>
> memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
>
> @@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev)
>
> memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs));
>
> - if (fbdev->lcdclk)
> - clk_enable(fbdev->lcdclk);
> + clk_enable(fbdev->lcdclk);
>
> /* Unblank the LCD */
> au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-19 7:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-14 8:21 [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Xu Wang
2020-10-15 8:05 ` Thomas Zimmermann
2020-10-19 7:21 ` Thomas Zimmermann
2020-10-19 7:21 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).