From: Sam Ravnborg <sam@ravnborg.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH -next] fbdev: nvidia: use for_each_child_of_node() macro
Date: Fri, 16 Oct 2020 21:44:20 +0000 [thread overview]
Message-ID: <20201016214420.GC1962741@ravnborg.org> (raw)
In-Reply-To: <20200916062123.190636-1-miaoqinglang@huawei.com>
Hi Qinglang Miao
On Wed, Sep 16, 2020 at 02:21:23PM +0800, Qinglang Miao wrote:
> Use for_each_child_of_node() macro instead of open coding it.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Applied to drm-misc-next.
Sam
> ---
> drivers/video/fbdev/nvidia/nv_of.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/nvidia/nv_of.c b/drivers/video/fbdev/nvidia/nv_of.c
> index 5f3e5179c..d20b8779b 100644
> --- a/drivers/video/fbdev/nvidia/nv_of.c
> +++ b/drivers/video/fbdev/nvidia/nv_of.c
> @@ -42,8 +42,7 @@ int nvidia_probe_of_connector(struct fb_info *info, int conn, u8 **out_edid)
> const char *pname;
> int len;
>
> - for (dp = NULL;
> - (dp = of_get_next_child(parent, dp)) != NULL;) {
> + for_each_child_of_node(parent, dp) {
> pname = of_get_property(dp, "name", NULL);
> if (!pname)
> continue;
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Antonino Daplas <adaplas@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] fbdev: nvidia: use for_each_child_of_node() macro
Date: Fri, 16 Oct 2020 23:44:20 +0200 [thread overview]
Message-ID: <20201016214420.GC1962741@ravnborg.org> (raw)
Message-ID: <20201016214420.WtXVfGBnFQm2Am3C6olzv2AAepNdbR-up4WZL4zOY1M@z> (raw)
In-Reply-To: <20200916062123.190636-1-miaoqinglang@huawei.com>
Hi Qinglang Miao
On Wed, Sep 16, 2020 at 02:21:23PM +0800, Qinglang Miao wrote:
> Use for_each_child_of_node() macro instead of open coding it.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Applied to drm-misc-next.
Sam
> ---
> drivers/video/fbdev/nvidia/nv_of.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/nvidia/nv_of.c b/drivers/video/fbdev/nvidia/nv_of.c
> index 5f3e5179c..d20b8779b 100644
> --- a/drivers/video/fbdev/nvidia/nv_of.c
> +++ b/drivers/video/fbdev/nvidia/nv_of.c
> @@ -42,8 +42,7 @@ int nvidia_probe_of_connector(struct fb_info *info, int conn, u8 **out_edid)
> const char *pname;
> int len;
>
> - for (dp = NULL;
> - (dp = of_get_next_child(parent, dp)) != NULL;) {
> + for_each_child_of_node(parent, dp) {
> pname = of_get_property(dp, "name", NULL);
> if (!pname)
> continue;
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-16 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 6:21 [PATCH -next] fbdev: nvidia: use for_each_child_of_node() macro Qinglang Miao
2020-10-16 21:44 ` Sam Ravnborg [this message]
2020-10-16 21:44 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016214420.GC1962741@ravnborg.org \
--to=sam@ravnborg.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox