From: Sam Ravnborg <sam@ravnborg.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: linux-fbdev@vger.kernel.org, timur@kernel.org,
b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, gustavoars@kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res'
Date: Sat, 17 Oct 2020 06:28:50 +0000 [thread overview]
Message-ID: <20201017062850.GH2242298@ravnborg.org> (raw)
In-Reply-To: <20200910140558.1191423-1-yanaijie@huawei.com>
On Thu, Sep 10, 2020 at 10:05:58PM +0800, Jason Yan wrote:
> Eliminate the following coccicheck warning:
>
> drivers/video/fbdev/fsl-diu-fb.c:1428:5-8: Unneeded variable: "res".
> Return "0" on line 1450
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Hi Jason,
applied to drm-misc-next too.
Sam
> ---
> drivers/video/fbdev/fsl-diu-fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
> index a547c21c7e92..e332017c6af6 100644
> --- a/drivers/video/fbdev/fsl-diu-fb.c
> +++ b/drivers/video/fbdev/fsl-diu-fb.c
> @@ -1425,7 +1425,6 @@ static int fsl_diu_open(struct fb_info *info, int user)
> static int fsl_diu_release(struct fb_info *info, int user)
> {
> struct mfb_info *mfbi = info->par;
> - int res = 0;
>
> spin_lock(&diu_lock);
> mfbi->count--;
> @@ -1447,7 +1446,7 @@ static int fsl_diu_release(struct fb_info *info, int user)
> }
>
> spin_unlock(&diu_lock);
> - return res;
> + return 0;
> }
>
> static const struct fb_ops fsl_diu_ops = {
> --
> 2.25.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: timur@kernel.org, b.zolnierkie@samsung.com,
gustavoars@kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res'
Date: Sat, 17 Oct 2020 08:28:50 +0200 [thread overview]
Message-ID: <20201017062850.GH2242298@ravnborg.org> (raw)
Message-ID: <20201017062850.GTd9ex-dlCkVq0bd7N1ePh6h6RwAYqGEzozeXYHJEDg@z> (raw)
In-Reply-To: <20200910140558.1191423-1-yanaijie@huawei.com>
On Thu, Sep 10, 2020 at 10:05:58PM +0800, Jason Yan wrote:
> Eliminate the following coccicheck warning:
>
> drivers/video/fbdev/fsl-diu-fb.c:1428:5-8: Unneeded variable: "res".
> Return "0" on line 1450
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Hi Jason,
applied to drm-misc-next too.
Sam
> ---
> drivers/video/fbdev/fsl-diu-fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
> index a547c21c7e92..e332017c6af6 100644
> --- a/drivers/video/fbdev/fsl-diu-fb.c
> +++ b/drivers/video/fbdev/fsl-diu-fb.c
> @@ -1425,7 +1425,6 @@ static int fsl_diu_open(struct fb_info *info, int user)
> static int fsl_diu_release(struct fb_info *info, int user)
> {
> struct mfb_info *mfbi = info->par;
> - int res = 0;
>
> spin_lock(&diu_lock);
> mfbi->count--;
> @@ -1447,7 +1446,7 @@ static int fsl_diu_release(struct fb_info *info, int user)
> }
>
> spin_unlock(&diu_lock);
> - return res;
> + return 0;
> }
>
> static const struct fb_ops fsl_diu_ops = {
> --
> 2.25.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-17 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 18:46 [PATCH] video: fbdev: fsl-diu-fb: Remove VLA usage Kees Cook
2018-06-30 15:59 ` Timur Tabi
2018-07-24 15:11 ` Bartlomiej Zolnierkiewicz
2020-09-10 14:05 ` [PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res' Jason Yan
2020-09-10 14:39 ` Gustavo A. R. Silva
2020-10-17 6:28 ` Sam Ravnborg [this message]
2020-10-17 6:28 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201017062850.GH2242298@ravnborg.org \
--to=sam@ravnborg.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=hulkci@huawei.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).