From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 016A5C55178 for ; Tue, 27 Oct 2020 18:46:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A333720760 for ; Tue, 27 Oct 2020 18:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="IACCIP29" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1829016AbgJ0SqG (ORCPT ); Tue, 27 Oct 2020 14:46:06 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:52245 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1766456AbgJ0Sos (ORCPT ); Tue, 27 Oct 2020 14:44:48 -0400 Received: by mail-wm1-f67.google.com with SMTP id c194so2348654wme.2 for ; Tue, 27 Oct 2020 11:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=yq3mNzKnnS784nsQFC2uDIJSO3VSvUZkuyXz2yHmGdg=; b=IACCIP29UjFLYDYxCaky7/HBTtI2UNwwbCcpjcks7uKU4tAvtd5mGAnvGHmjidVDwH zP9iwtcti5gtYzQkactAV1pPQ4L2E0iotqMM1GS/1KXB6pzebnPe1RL7UfhRVRcHl7GD X8AcNVcDBhj3fsVeK3Wxl5L2lGS2fr21qPFWs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=yq3mNzKnnS784nsQFC2uDIJSO3VSvUZkuyXz2yHmGdg=; b=eNRtKbupYEDlTSZfOb3AuRJGniuUKZeeS7Zp+iC/ugE4Yl8Iv9KVbTBaijFRyCzRtN wZW1bbAicCUoSnr+RNDBjC4yto+iQY5ZnNg8vENfy9ucPraOlt55+H19fbD0JB63Lr1I +QLZDbmaTQuEq+jnSdKMn1rInuKoSNNxyBawUyx0SweB6fC6a4KMCsS5mBgB+RO2o0PY uYBFQINiTv8ZcCDV73RxliCbHnyQPawNoj5CvFXFtTLNVu4EOw9rtFFAqgGQBrnifdNV VBR1pO5NHIr5ZATHopRclDnIDWWOBKTLXwQ44n5Zgwk+07yYtvKgyXaUsoH426B9SeUg p0Tw== X-Gm-Message-State: AOAM531SkDgFXeP5WZVETxWOWdXMOsbK0nq/iRmg6ofD2EX6OLg3KS/S jk1JQ+QpJn64ECtrVaURFvZZmfhRAvo4+ItL X-Google-Smtp-Source: ABdhPJyNv9utLUbtl13nhVFLMe2DbQzNiipDgdzSnVahx9c+HevjO+Z5XoZ2J7OZUBZRFF03CNYYtg== X-Received: by 2002:a7b:cc09:: with SMTP id f9mr4109018wmh.93.1603824285879; Tue, 27 Oct 2020 11:44:45 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l26sm2755765wmi.41.2020.10.27.11.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 11:44:44 -0700 (PDT) Date: Tue, 27 Oct 2020 19:44:42 +0100 From: Daniel Vetter To: Peilin Ye Cc: Daniel Vetter , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Mike Rapoport , Andrew Morton , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] fbdev/atafb: Remove unused extern variables Message-ID: <20201027184442.GL401619@phenom.ffwll.local> Mail-Followup-To: Peilin Ye , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Mike Rapoport , Andrew Morton , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Oct 27, 2020 at 12:31:08PM -0400, Peilin Ye wrote: > Remove 6 unused extern variables to reduce confusion. It is worth > mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also > declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file > has nothing to do with them. > > Signed-off-by: Peilin Ye This was unused ever since this driver was merged into 2.1.67 (I looked at historical linux git trees quickly). Save to delete I'd say, probably just copypasted from some outdated driver template that was even older. Applied to drm-misc-next. -Daniel > --- > $ # Build-tested (Ubuntu 20.04) > $ sudo apt install gcc-m68k-linux-gnu > $ cp arch/m68k/configs/atari_defconfig .config > $ make ARCH=m68k menuconfig > $ make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- -j`nproc` all > > drivers/video/fbdev/atafb.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c > index f253daa05d9d..e3812a8ff55a 100644 > --- a/drivers/video/fbdev/atafb.c > +++ b/drivers/video/fbdev/atafb.c > @@ -240,14 +240,6 @@ static int *MV300_reg = MV300_reg_8bit; > > static int inverse; > > -extern int fontheight_8x8; > -extern int fontwidth_8x8; > -extern unsigned char fontdata_8x8[]; > - > -extern int fontheight_8x16; > -extern int fontwidth_8x16; > -extern unsigned char fontdata_8x16[]; > - > /* > * struct fb_ops { > * * open/release and usage marking > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch