From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271FEC00A89 for ; Mon, 2 Nov 2020 15:03:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D74CF2084C for ; Mon, 2 Nov 2020 15:03:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="XXugjq9A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725961AbgKBPD2 (ORCPT ); Mon, 2 Nov 2020 10:03:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbgKBPD2 (ORCPT ); Mon, 2 Nov 2020 10:03:28 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05757C0617A6 for ; Mon, 2 Nov 2020 07:03:28 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h22so9828729wmb.0 for ; Mon, 02 Nov 2020 07:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=dJViYluzyjRZysYd1WNbgOJn/HhY4VHwfAV/4FIXe6w=; b=XXugjq9A63BNiHXr+V09ATFS1VCLYo6+jafx7iEYz+bNK/A3Inwv1tHlE2ah80+PUz vXrgo9y71KREm6//ajlYEXzC77w4nJOGJW8hKWKCXx5gEcLwLj6xhfN/kPPM2wnbrbMS x+iN+q3xNMVON7cpextfccfCQbZ2AfH8mshfE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=dJViYluzyjRZysYd1WNbgOJn/HhY4VHwfAV/4FIXe6w=; b=fBBsxZqBbkKQHmGK4eG4T+zSMKXEWIBJ/B9Q1Vu7t2VAyH8Ysl2T6gQl3KoI3wWoWS /FObSL0Cx5ptAqXB35ckLnsXz27JNiLB6nyL7tDsxg5k8RI2tLDOWWod74qBUsDcLJtc jOGNKBg4DKKnmOUjJlyrDrPzPPCJbep23Snab/DdxlyOZPQB+XJXs5VYv7+xVqHkl2j8 Tz6DH2cbE4fVEyX7xEzwbZ9xpkndB5CA3O8EOAaNSK2nS5C2lXt8J//TC5Rw/sqY3P08 mCJDibVgjw7moTDpbtKxm8yTudzrM5cgpiuoh1ARZVC6ML7ukXTAE9+/X2TXZ6qaBXrP dwtQ== X-Gm-Message-State: AOAM531B9lNYavTJIOOoFOjQ7dyKQ8R2B2i+dLXqXqlRbnTlzIbYAOzP FIHGqdPEyGqukd0npsaMj0fTbg== X-Google-Smtp-Source: ABdhPJxcXU2IVisDLOi1mXtv8okUtL8WOu9oDyx1FEypZo3YXEvPMBplDp1qDpoRWh0iWKvk3twfhA== X-Received: by 2002:a05:600c:216:: with SMTP id 22mr17360409wmi.149.1604329406704; Mon, 02 Nov 2020 07:03:26 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j127sm16037075wma.31.2020.11.02.07.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 07:03:25 -0800 (PST) Date: Mon, 2 Nov 2020 16:03:24 +0100 From: Daniel Vetter To: Peilin Ye Cc: Daniel Vetter , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Jiri Slaby , Sascha Hauer , Sven Schneider , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5 v2] Fonts: Add charcount field to font_desc Message-ID: <20201102150324.GU401619@phenom.ffwll.local> Mail-Followup-To: Peilin Ye , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Jiri Slaby , Sascha Hauer , Sven Schneider , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <6c28279a10dbe7a7e5ac3e3a8dd7c67f8d63a9f2.1603788512.git.yepeilin.cs@gmail.com> <20201028060533.1206307-1-yepeilin.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028060533.1206307-1-yepeilin.cs@gmail.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, Oct 28, 2020 at 02:05:33AM -0400, Peilin Ye wrote: > Subsystems are assuming the number of characters of our built-in fonts. > Include that information in our kernel font descriptor, `struct > font_desc`. > > Signed-off-by: Peilin Ye > Reviewed-by: Daniel Vetter > --- > Change in v2: > - Rebase onto 5.10-rc1. Hm there's a tiny conflict now with this because of the unsigned vs signed discussion we've had. Can you please rebase the remaining 3 patches onto linux-next or drm-misc-next or so and then resubmit? Thanks, Daniel > > include/linux/font.h | 1 + > lib/fonts/font_10x18.c | 1 + > lib/fonts/font_6x10.c | 1 + > lib/fonts/font_6x11.c | 1 + > lib/fonts/font_6x8.c | 1 + > lib/fonts/font_7x14.c | 1 + > lib/fonts/font_8x16.c | 1 + > lib/fonts/font_8x8.c | 1 + > lib/fonts/font_acorn_8x8.c | 1 + > lib/fonts/font_mini_4x6.c | 1 + > lib/fonts/font_pearl_8x8.c | 1 + > lib/fonts/font_sun12x22.c | 1 + > lib/fonts/font_sun8x16.c | 1 + > lib/fonts/font_ter16x32.c | 1 + > 14 files changed, 14 insertions(+) > > diff --git a/include/linux/font.h b/include/linux/font.h > index b5b312c19e46..54e60ad2252b 100644 > --- a/include/linux/font.h > +++ b/include/linux/font.h > @@ -17,6 +17,7 @@ struct font_desc { > int idx; > const char *name; > int width, height; > + unsigned int charcount; > const void *data; > int pref; > }; > diff --git a/lib/fonts/font_10x18.c b/lib/fonts/font_10x18.c > index 0e2deac97da0..4096c6562494 100644 > --- a/lib/fonts/font_10x18.c > +++ b/lib/fonts/font_10x18.c > @@ -5137,6 +5137,7 @@ const struct font_desc font_10x18 = { > .name = "10x18", > .width = 10, > .height = 18, > + .charcount = 256, > .data = fontdata_10x18.data, > #ifdef __sparc__ > .pref = 5, > diff --git a/lib/fonts/font_6x10.c b/lib/fonts/font_6x10.c > index 87da8acd07db..32786674cf65 100644 > --- a/lib/fonts/font_6x10.c > +++ b/lib/fonts/font_6x10.c > @@ -3083,6 +3083,7 @@ const struct font_desc font_6x10 = { > .name = "6x10", > .width = 6, > .height = 10, > + .charcount = 256, > .data = fontdata_6x10.data, > .pref = 0, > }; > diff --git a/lib/fonts/font_6x11.c b/lib/fonts/font_6x11.c > index 5e975dfa10a5..81e4a3aed44a 100644 > --- a/lib/fonts/font_6x11.c > +++ b/lib/fonts/font_6x11.c > @@ -3346,6 +3346,7 @@ const struct font_desc font_vga_6x11 = { > .name = "ProFont6x11", > .width = 6, > .height = 11, > + .charcount = 256, > .data = fontdata_6x11.data, > /* Try avoiding this font if possible unless on MAC */ > .pref = -2000, > diff --git a/lib/fonts/font_6x8.c b/lib/fonts/font_6x8.c > index 700039a9ceae..5618ae7ef9fa 100644 > --- a/lib/fonts/font_6x8.c > +++ b/lib/fonts/font_6x8.c > @@ -2571,6 +2571,7 @@ const struct font_desc font_6x8 = { > .name = "6x8", > .width = 6, > .height = 8, > + .charcount = 256, > .data = fontdata_6x8.data, > .pref = 0, > }; > diff --git a/lib/fonts/font_7x14.c b/lib/fonts/font_7x14.c > index 86d298f38505..7708e73d491f 100644 > --- a/lib/fonts/font_7x14.c > +++ b/lib/fonts/font_7x14.c > @@ -4113,6 +4113,7 @@ const struct font_desc font_7x14 = { > .name = "7x14", > .width = 7, > .height = 14, > + .charcount = 256, > .data = fontdata_7x14.data, > .pref = 0, > }; > diff --git a/lib/fonts/font_8x16.c b/lib/fonts/font_8x16.c > index 37cedd36ca5e..74125d3570cf 100644 > --- a/lib/fonts/font_8x16.c > +++ b/lib/fonts/font_8x16.c > @@ -4627,6 +4627,7 @@ const struct font_desc font_vga_8x16 = { > .name = "VGA8x16", > .width = 8, > .height = 16, > + .charcount = 256, > .data = fontdata_8x16.data, > .pref = 0, > }; > diff --git a/lib/fonts/font_8x8.c b/lib/fonts/font_8x8.c > index 8ab695538395..96da4bb31ae4 100644 > --- a/lib/fonts/font_8x8.c > +++ b/lib/fonts/font_8x8.c > @@ -2578,6 +2578,7 @@ const struct font_desc font_vga_8x8 = { > .name = "VGA8x8", > .width = 8, > .height = 8, > + .charcount = 256, > .data = fontdata_8x8.data, > .pref = 0, > }; > diff --git a/lib/fonts/font_acorn_8x8.c b/lib/fonts/font_acorn_8x8.c > index 069b3e80c434..ba74053fec7b 100644 > --- a/lib/fonts/font_acorn_8x8.c > +++ b/lib/fonts/font_acorn_8x8.c > @@ -270,6 +270,7 @@ const struct font_desc font_acorn_8x8 = { > .name = "Acorn8x8", > .width = 8, > .height = 8, > + .charcount = 256, > .data = acorndata_8x8.data, > #ifdef CONFIG_ARCH_ACORN > .pref = 20, > diff --git a/lib/fonts/font_mini_4x6.c b/lib/fonts/font_mini_4x6.c > index 1449876c6a27..637708e8c67e 100644 > --- a/lib/fonts/font_mini_4x6.c > +++ b/lib/fonts/font_mini_4x6.c > @@ -2152,6 +2152,7 @@ const struct font_desc font_mini_4x6 = { > .name = "MINI4x6", > .width = 4, > .height = 6, > + .charcount = 256, > .data = fontdata_mini_4x6.data, > .pref = 3, > }; > diff --git a/lib/fonts/font_pearl_8x8.c b/lib/fonts/font_pearl_8x8.c > index 32d65551e7ed..06cde43c7bd2 100644 > --- a/lib/fonts/font_pearl_8x8.c > +++ b/lib/fonts/font_pearl_8x8.c > @@ -2582,6 +2582,7 @@ const struct font_desc font_pearl_8x8 = { > .name = "PEARL8x8", > .width = 8, > .height = 8, > + .charcount = 256, > .data = fontdata_pearl8x8.data, > .pref = 2, > }; > diff --git a/lib/fonts/font_sun12x22.c b/lib/fonts/font_sun12x22.c > index 641a6b4dca42..d0290d79df2c 100644 > --- a/lib/fonts/font_sun12x22.c > +++ b/lib/fonts/font_sun12x22.c > @@ -6156,6 +6156,7 @@ const struct font_desc font_sun_12x22 = { > .name = "SUN12x22", > .width = 12, > .height = 22, > + .charcount = 256, > .data = fontdata_sun12x22.data, > #ifdef __sparc__ > .pref = 5, > diff --git a/lib/fonts/font_sun8x16.c b/lib/fonts/font_sun8x16.c > index 193fe6d988e0..7d83760354a6 100644 > --- a/lib/fonts/font_sun8x16.c > +++ b/lib/fonts/font_sun8x16.c > @@ -268,6 +268,7 @@ const struct font_desc font_sun_8x16 = { > .name = "SUN8x16", > .width = 8, > .height = 16, > + .charcount = 256, > .data = fontdata_sun8x16.data, > #ifdef __sparc__ > .pref = 10, > diff --git a/lib/fonts/font_ter16x32.c b/lib/fonts/font_ter16x32.c > index 91b9c283bd9c..a2cc25b9f8e3 100644 > --- a/lib/fonts/font_ter16x32.c > +++ b/lib/fonts/font_ter16x32.c > @@ -2062,6 +2062,7 @@ const struct font_desc font_ter_16x32 = { > .name = "TER16x32", > .width = 16, > .height = 32, > + .charcount = 256, > .data = fontdata_ter16x32.data, > #ifdef __sparc__ > .pref = 5, > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch