From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9BDC388F7 for ; Tue, 10 Nov 2020 12:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C80D320797 for ; Tue, 10 Nov 2020 12:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Af/MIMAK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730193AbgKJMtv (ORCPT ); Tue, 10 Nov 2020 07:49:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbgKJMtv (ORCPT ); Tue, 10 Nov 2020 07:49:51 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A0FBC0613CF for ; Tue, 10 Nov 2020 04:49:50 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id 19so1336559wmf.1 for ; Tue, 10 Nov 2020 04:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Fd0rvLSxv3w0DGSQl7/MR8nNwRxQn2EkK7Jf55cFZrE=; b=Af/MIMAKTQFyxeHZZ16ClAESfRN5kB3gwq1ekyEsJw9VWZtvXazxaHfDBudJlv5Yfe sG+w67uZ1tV0fV0JuRrShzclzjjo1v5Hk4cDXOlThxui7dlxO690C+LdlsHAN7Go4jz4 9QN0p1pD7iRWnebbIfEOspzjTobQjXBHaVga8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Fd0rvLSxv3w0DGSQl7/MR8nNwRxQn2EkK7Jf55cFZrE=; b=E/VTjO152/W1iK8Utm43cp1Lh91pGvhrMn0tNt/KVOfC/rKa+j48U6TbxR/DHGfaFf 5ellWOSNPPp0NZ5PNohbd9MdMNNpZFOZzH16WSg/JQl8EWEDsFMfgT+Rhvwq2vEJRWk1 mMYO24Ehxvcp42V+3YuiUX771pE7EfitZx5JEslzwVkqI8lOanLB7qiVQBS2SzArp7tR OUf1I4Ti6qMp2CkoPKz660ekJmJlR7VjoAaSLrvY3KN/fPNiBml/1I4GGP8WHRCQszsV pCRH6O9AAizpTm7LwPpFivJ7lHOJyXQJd9Yd3MOK+wTh/+KNeSZ+vZo9Tkh7biWZTCgM 2Y+w== X-Gm-Message-State: AOAM530bKbFpBm/CjAWWsMKT0VSQs+4FjljWH4hBBViWzm+ci0YN7JOj 7/ahiDLUFNKiL9qIij3bR5mQig== X-Google-Smtp-Source: ABdhPJzPchZV3CYprZV/WF3ChAiYPcWT+V/aERZoo0KWm+pFd7h/KOdwCODP/u/gnKrwWH9ItChKBw== X-Received: by 2002:a1c:1b43:: with SMTP id b64mr4458160wmb.64.1605012589235; Tue, 10 Nov 2020 04:49:49 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h81sm2905596wmf.44.2020.11.10.04.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 04:49:48 -0800 (PST) Date: Tue, 10 Nov 2020 13:49:46 +0100 From: Daniel Vetter To: Greg Kroah-Hartman Cc: Peilin Ye , Daniel Vetter , Jiri Slaby , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Nicolas Pitre , "Gustavo A . R . Silva" , Tetsuo Handa , George Kennedy , Nathan Chancellor , Peter Rosin , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 1/2] console: Remove dummy con_font_op() callback implementations Message-ID: <20201110124946.GF401619@phenom.ffwll.local> Mail-Followup-To: Greg Kroah-Hartman , Peilin Ye , Jiri Slaby , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Nicolas Pitre , "Gustavo A . R . Silva" , Tetsuo Handa , George Kennedy , Nathan Chancellor , Peter Rosin , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20201106105058.GA2801856@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106105058.GA2801856@kroah.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, Nov 06, 2020 at 11:50:58AM +0100, Greg Kroah-Hartman wrote: > On Sat, Oct 31, 2020 at 03:24:41AM -0400, Peilin Ye wrote: > > `struct console_font` is a UAPI structure, thus ideally should not be > > used for kernel internal abstraction. Remove some dummy .con_font_set, > > .con_font_default and .con_font_copy `struct consw` callback > > implementations, to make it cleaner. > > > > Patch "fbcon: Prevent global-out-of-bounds read in fbcon_copy_font()" > > depends on this patch, so Cc: stable. > > > > Cc: stable@vger.kernel.org > > Suggested-by: Daniel Vetter > > Signed-off-by: Peilin Ye > > --- > > Context: https://lore.kernel.org/lkml/CAKMK7uFY2zv0adjKJ_ORVFT7Zzwn075MaU0rEU7_FuqENLR=UA@mail.gmail.com/ > > > > drivers/usb/misc/sisusbvga/sisusb_con.c | 21 --------------------- > > drivers/video/console/dummycon.c | 20 -------------------- > > 2 files changed, 41 deletions(-) > > Reviewed-by: Greg Kroah-Hartman Peilin, can you pls resend this together with all the other pending patches from you? I think that's better than me trying to cherry-pick the bits we decided to keep from random places. Greg, ok if I just pull these in through drm-misc-next? It's a pretty bad hairball anyway and that avoids the tree coordination issues. Only thing that might get in the way is the vt font_copy removal, but that's in -rc3 so easy to backmerge. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch