From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E936BC4742C for ; Mon, 16 Nov 2020 15:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46B5E2076E for ; Mon, 16 Nov 2020 15:34:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="fYbtOv2C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730379AbgKPPeD (ORCPT ); Mon, 16 Nov 2020 10:34:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730294AbgKPPeC (ORCPT ); Mon, 16 Nov 2020 10:34:02 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B2D0C0613D1 for ; Mon, 16 Nov 2020 07:34:02 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id h21so3226111wmb.2 for ; Mon, 16 Nov 2020 07:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=bftfhnX/eEwrSLEmEZfOTDJhOE+yWsLG0tNmcvU7v9E=; b=fYbtOv2CeJtUdxBkmjy1CRIrtst5PAeupiQlzB2MeNjjoMegwo0SgZEVQkQdQ43obg X+DUfSWkUXn+hncJ4JX4zYyvXil9jKWfKTHhHIBw757ucMDEKevCM7NnLjGTvA6SeOGP u9g6Br/jg48FNO6DoFVwX0/csmOtsw3XQMWjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=bftfhnX/eEwrSLEmEZfOTDJhOE+yWsLG0tNmcvU7v9E=; b=Uvp4Huhwsg0JOIBVbhNtx2kva6rLQLDi2AEbIDS2llyhOGuvBAr3O/OusrBclEkYpc dNYC1oOMhgSye8bYPbI+pA9m83HWApzm8TERUvMBujAMJWpwaOQmqVLlhAY0f7hmVJ/m E0suHvoWdfMRyXXxt5Bo1KXsQV2JrLrigWXM9CoghsrFw723PvjiU7fUQFuWMg0e9K20 F1LmDwzLqMZudVBYid6fnw619pkMtIF93l17LZhWnYxJ4mRJHMADlbxwK80HSlB/2mrD t4eCwp9oAWE3Trx6Qlu30xwcyWXyPNLRzaHnUl2gG+0SNGyKBbH6J1SR3ErzOx3QuOLD YGnQ== X-Gm-Message-State: AOAM530nLFJDyL2sThBT6DpSfMJz4KrDX+GLauk6w3GXPB/GsVvbd/8S +ZkEzEsz6jdutfzGUy2JRf5mOw== X-Google-Smtp-Source: ABdhPJwRHdcSIoZEQay/4i4vu3XsVboTEU14GHj8xaq/PyiThVNWOLos8TYaBnFM/vBqNuPVAAftyg== X-Received: by 2002:a7b:c772:: with SMTP id x18mr17074781wmk.185.1605540840938; Mon, 16 Nov 2020 07:34:00 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x2sm17710549wru.44.2020.11.16.07.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 07:34:00 -0800 (PST) Date: Mon, 16 Nov 2020 16:33:58 +0100 From: Daniel Vetter To: Greg Kroah-Hartman Cc: Peilin Ye , Jiri Slaby , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 0/5] console: Miscellaneous clean-ups, do not use FNTCHARCNT() in fbcon.c Message-ID: <20201116153358.GB401619@phenom.ffwll.local> Mail-Followup-To: Greg Kroah-Hartman , Peilin Ye , Jiri Slaby , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20201113211633.GY401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, Nov 13, 2020 at 11:47:51PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 13, 2020 at 10:16:33PM +0100, Daniel Vetter wrote: > > On Thu, Nov 12, 2020 at 07:02:21AM -0500, Peilin Ye wrote: > > > Hi all, > > > > > > This is a collection of some miscellaneous clean-ups for fbcon and some > > > console drivers. Since v2, I rebased them on linux-next, added some > > > Reviewed-by: tags from Daniel and Greg, and rewrote the commit messages as > > > suggested by Jiri. See [1] for v2 links. > > > > > > It does the following: > > > > > > - Garbage collect KD_FONT_OP_COPY callbacks since we disabled it > > > recently. Mark it as obsolete. > > > - Delete dummy con_font_op() callbacks. (Reviewed by Greg) > > > > > > - Add a charcount field to our new font descriptor, `struct font_desc`. > > > (Reviewed by Daniel) > > > - Do not use a hard-coded 256 for built-in font charcount in > > > console/sticore.c, use the new charcount field of `struct font_desc` > > > instead. (Reviewed by Daniel) > > > - Similarly, in fbcon.c, avoid using the magic negative-indexing macro, > > > FNTCHARCNT(). Set `vc->vc_font.charcount` properly and always use that > > > instead. > > > > > > Daniel, hopefully [5/5] removes FNTCHARCNT() for ever, but I have not > > > tested it sufficiently yet. I remember you mentioned elsewhere that > > > "fbtest.c" is insufficient for framebuffer testing, then how should we > > > test it? The first 4 patches should be fine. > > > > > > Please reference commit messages for more information. Thank you! > > > > > > [1] v2 links: > > > > > > 2/5: https://lore.kernel.org/lkml/c5563eeea36aae7bd72ea2e985bc610d585ece40.1604306433.git.yepeilin.cs@gmail.com/ > > > 3/5: https://lore.kernel.org/lkml/20201028060533.1206307-1-yepeilin.cs@gmail.com/ > > > 4/5: https://lore.kernel.org/lkml/c38042bbf5c9777c84900d56c09f3c156b32af48.1603788512.git.yepeilin.cs@gmail.com/ > > > 5/5: https://lore.kernel.org/lkml/20201028155139.1220549-1-yepeilin.cs@gmail.com/ > > > > > > Peilin Ye (5): > > > console: Delete unused con_font_copy() callback implementations > > > console: Delete dummy con_font_set() and con_font_default() callback implementations > > > Fonts: Add charcount field to font_desc > > > parisc/sticore: Avoid hard-coding built-in font charcount > > > fbcon: Avoid using FNTCHARCNT() and hard-coded built-in font charcount > > > > Patches all look good to me, if Greg is ok with me applying the entire > > pile to drm-misc-next I'll do that next week. > > Yes, please do! > > Reviewed-by: Greg Kroah-Hartman Pulled entire series into drm-misc-next. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch