From: Dan Carpenter <dan.carpenter@oracle.com>
To: carlis <zhangxuezhi3@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
mh12gx2825@gmail.com, gregkh@linuxfoundation.org,
oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, sbrivio@redhat.com,
colin.king@canonical.com, zhangxuezhi1@yulong.com
Subject: Re: [PATCH v5] fbtft: add tearing signal detect
Date: Wed, 27 Jan 2021 09:49:16 +0300 [thread overview]
Message-ID: <20210127064916.GD2696@kadam> (raw)
In-Reply-To: <20210127141927.00004472@gmail.com>
On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote:
> hi,i will fix it like below:
> par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0,
> GPIOD_IN); if (IS_ERR(par->gpio.te)) {
> rc = PTR_ERR(par->gpio.te);
> pr_err("Failed to request te gpio: %d\n", rc);
> par->gpio.te = NULL;
> }
I wish you would just copy and paste the code that I sent you instead,
but this also fixes the crash...
regards,
dan carpenter
next prev parent reply other threads:[~2021-01-27 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 1:32 [PATCH v5] fbtft: add tearing signal detect Carlis
2021-01-27 5:45 ` Dan Carpenter
2021-01-27 6:19 ` carlis
2021-01-27 6:49 ` Dan Carpenter [this message]
2021-01-27 8:48 ` Geert Uytterhoeven
2021-01-27 6:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127064916.GD2696@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=oliver.graute@kococonnector.com \
--cc=sbrivio@redhat.com \
--cc=zhangxuezhi1@yulong.com \
--cc=zhangxuezhi3@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).