From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DDFEC433ED for ; Fri, 7 May 2021 05:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7D0B613E3 for ; Fri, 7 May 2021 05:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232704AbhEGFGR (ORCPT ); Fri, 7 May 2021 01:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232410AbhEGFGQ (ORCPT ); Fri, 7 May 2021 01:06:16 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 053E9C061574 for ; Thu, 6 May 2021 22:05:14 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lesfi-0003g4-Cs; Fri, 07 May 2021 07:05:06 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lesff-0007eK-8B; Fri, 07 May 2021 07:05:03 +0200 Date: Fri, 7 May 2021 07:05:03 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Christophe JAILLET Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com, linux-imx@nxp.com, j.beisert@pengutronix.de, krzysztof.h1@poczta.fm, linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message Message-ID: <20210507050503.iwrcis2xzhjjthmp@pengutronix.de> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fchy7hv2sjxcax73" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-fbdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org --fchy7hv2sjxcax73 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Christophe, On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote: > 'ret' is known to be 0 here. > No error code is available, so just remove it from the error message. >=20 > Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direc= t pointer deref") > Signed-off-by: Christophe JAILLET > --- > drivers/video/fbdev/imxfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c > index 7f8debd2da06..ad598257ab38 100644 > --- a/drivers/video/fbdev/imxfb.c > +++ b/drivers/video/fbdev/imxfb.c > @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev) > info->screen_buffer =3D dma_alloc_wc(&pdev->dev, fbi->map_size, > &fbi->map_dma, GFP_KERNEL); > if (!info->screen_buffer) { > - dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret); > + dev_err(&pdev->dev, "Failed to allocate video RAM\n"); > ret =3D -ENOMEM; > goto failed_map; > } Reviewed-by: Uwe Kleine-K=F6nig Are you using this driver, or did you find that problem using some static checker? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --fchy7hv2sjxcax73 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCUynsACgkQwfwUeK3K 7Akw+QgAibPO6IbkA1icCBx3pbmkEnH1NGD7B1YrSwgKWeQlnCqqfv67hRrjvs1u s2PTr3bd7cE3G7YnWnWWLEC9/7xew8nNKv89KFGSQa1pzRFBc/FGpaeTMDvkO8PK miGiZbBAl240AtvS87ODzAIDqB2vQkJ6UzinynVbHTN4j+1FKjwnmag05qugFDvx nYGaNPop0x4BzwcBVVKGTwCnHjmoWdz+HGw+udY9AnO/N5A+Ms6WGsx2yf6d1Z4f 9i9UwA7LoOM/i8+bEwtgZRnn7CXBhYWPFhNMtU+nKAqeGryeAr4UsO/8Y/O9kN/5 F+yqk+jOjwAAnNq5cNzXm6wxrxN88Q== =KRUx -----END PGP SIGNATURE----- --fchy7hv2sjxcax73--