From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022A6C43470 for ; Mon, 10 May 2021 10:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAEFB619CB for ; Mon, 10 May 2021 10:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231907AbhEJKvL (ORCPT ); Mon, 10 May 2021 06:51:11 -0400 Received: from onstation.org ([52.200.56.107]:33058 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232113AbhEJKsQ (ORCPT ); Mon, 10 May 2021 06:48:16 -0400 X-Greylist: delayed 309 seconds by postgrey-1.27 at vger.kernel.org; Mon, 10 May 2021 06:48:14 EDT Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 3A7E73E9FF; Mon, 10 May 2021 10:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1620643319; bh=6y+Fzt4oWzPMV01Ga2YdSBHuWTVF3ofTAHQn+x+PJmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRE1U8Rj3MLTexBrgPH+cxlh/pQd518l2EkidlivYwlL0QLIWEs+Q/XPyrcTPg0cl d3GxrPsgj7yEbpcP93H6/l3TfKPWhulcdoVQpMVo7ZRnqspkf6ljinyrCx0k2sLvkB a+hApArrdIQRbvrAJNJwBQw786fkrByiVubdkGSw= Date: Mon, 10 May 2021 06:41:58 -0400 From: Brian Masney To: Andy Shevchenko Cc: Lee Jones , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , Jingoo Han , Dan Murphy Subject: Re: [PATCH v1 1/1] backlight: lm3630a_bl: Put fwnode in error case during ->probe() Message-ID: <20210510104158.GA296@onstation.org> References: <20210510095716.3302910-1-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510095716.3302910-1-andy.shevchenko@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, May 10, 2021 at 12:57:16PM +0300, Andy Shevchenko wrote: > device_for_each_child_node() bumps a reference counting of a returned variable. > We have to balance it whenever we return to the caller. > > Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support") > Cc: Brian Masney > Cc: Dan Murphy > Signed-off-by: Andy Shevchenko Reviewed-by: Brian Masney