From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDE24C433F5 for ; Mon, 15 Nov 2021 06:47:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFD7263218 for ; Mon, 15 Nov 2021 06:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbhKOGtv (ORCPT ); Mon, 15 Nov 2021 01:49:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:44618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbhKOGtv (ORCPT ); Mon, 15 Nov 2021 01:49:51 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6AD2A60F5B; Mon, 15 Nov 2021 06:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636958816; bh=XEM+DrVSvNflnPL2o1sMlhGONa8AnyEqQx/59JtGP2c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OVmNgMSmI4+Nmq5m1ncvHF0Pj3HaH4P86AajL8yTBREyzv2d7MxsEzOR148rV7V3s 8ukBCJ3Kat5AJP80t8YnZsq9gpJufOZSbldpEr1ix4FvBTaUEoms36v/yx61XdmK2S kVypfhaOImIJz2nxHa5VqsBmQOPVG1LonLHOQPBiDZq13L5LTh4nxOZvpLARdtHgMD zDzoErjcMoqpIAVrm9Jrj22ZwiK2my/diouWP2doS6bQVObyl4+/o5CpkQZwb6w+J6 zRUkpzFkxAV/oLZZaeSICOaHSlpo1+85aZexKO1N6nwc2GQZZ5Tiyn24XX6F9Pv6CG V/j4pe0XkrQ6g== Date: Mon, 15 Nov 2021 00:51:58 -0600 From: "Gustavo A. R. Silva" To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Nobuhiro Iwamatsu , Manuel Lauss , Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] fbdev: sh7760fb: document fallthrough cases Message-ID: <20211115065158.GA98196@embeddedor> References: <20211115063257.14369-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211115063257.14369-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Sun, Nov 14, 2021 at 10:32:57PM -0800, Randy Dunlap wrote: > Fix fallthrough warnings in sh776fb.c: > > ../drivers/video/fbdev/sh7760fb.c: In function 'sh7760fb_get_color_info': > ../drivers/video/fbdev/sh7760fb.c:138:23: warning: this statement may fall through [-Wimplicit-fallthrough=] > 138 | lgray = 1; > ../drivers/video/fbdev/sh7760fb.c:143:23: warning: this statement may fall through [-Wimplicit-fallthrough=] > 143 | lgray = 1; > > Just document the current state of code execution/flow. > > Fixes: 4a25e41831ee ("video: sh7760fb: SH7760/SH7763 LCDC framebuffer driver") > Signed-off-by: Randy Dunlap > Cc: "Gustavo A. R. Silva" > Cc: Nobuhiro Iwamatsu > Cc: Manuel Lauss > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: linux-sh@vger.kernel.org > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org Reviewed-by: Gustavo A. R. Silva Thanks, Randy. -- Gustavo > --- > drivers/video/fbdev/sh7760fb.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20211112.orig/drivers/video/fbdev/sh7760fb.c > +++ linux-next-20211112/drivers/video/fbdev/sh7760fb.c > @@ -136,11 +136,13 @@ static int sh7760fb_get_color_info(struc > break; > case LDDFR_4BPP_MONO: > lgray = 1; > + fallthrough; > case LDDFR_4BPP: > lbpp = 4; > break; > case LDDFR_6BPP_MONO: > lgray = 1; > + fallthrough; > case LDDFR_8BPP: > lbpp = 8; > break;