* [PATCH] omapfb: add one more "fallthrough" statement
@ 2021-11-16 9:21 Arnd Bergmann
2021-11-16 15:17 ` Nathan Chancellor
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-11-16 9:21 UTC (permalink / raw)
To: linux-fbdev
Cc: Arnd Bergmann, Nathan Chancellor, Nick Desaulniers, linux-omap,
dri-devel, linux-kernel, llvm
From: Arnd Bergmann <arnd@arndb.de>
clang warns about one missing fallthrough that gcc ignores:
drivers/video/fbdev/omap/omapfb_main.c:1558:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
Add it here as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/omap/omapfb_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index 3d090d2d9ed9..a6a8404d1462 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1555,6 +1555,7 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)
case 1:
dev_set_drvdata(fbdev->dev, NULL);
kfree(fbdev);
+ fallthrough;
case 0:
/* nothing to free */
break;
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omapfb: add one more "fallthrough" statement
2021-11-16 9:21 [PATCH] omapfb: add one more "fallthrough" statement Arnd Bergmann
@ 2021-11-16 15:17 ` Nathan Chancellor
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Chancellor @ 2021-11-16 15:17 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-fbdev, Arnd Bergmann, Nick Desaulniers, linux-omap,
dri-devel, linux-kernel, llvm
On Tue, Nov 16, 2021 at 10:21:54AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> clang warns about one missing fallthrough that gcc ignores:
>
> drivers/video/fbdev/omap/omapfb_main.c:1558:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>
> Add it here as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/video/fbdev/omap/omapfb_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index 3d090d2d9ed9..a6a8404d1462 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1555,6 +1555,7 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)
> case 1:
> dev_set_drvdata(fbdev->dev, NULL);
> kfree(fbdev);
> + fallthrough;
> case 0:
> /* nothing to free */
> break;
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-16 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-16 9:21 [PATCH] omapfb: add one more "fallthrough" statement Arnd Bergmann
2021-11-16 15:17 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).