* [PATCH] backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls
@ 2022-01-13 8:48 Xu Wang
2022-01-13 15:02 ` Daniel Thompson
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2022-01-13 8:48 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1
Cc: dri-devel, linux-fbdev, linux-kernel
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/video/backlight/lm3630a_bl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index e8b185bb6f5e..1d17c439430e 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -594,7 +594,6 @@ static int lm3630a_remove(struct i2c_client *client)
if (pchip->irq) {
free_irq(pchip->irq, pchip);
- flush_workqueue(pchip->irqthread);
destroy_workqueue(pchip->irqthread);
}
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls
2022-01-13 8:48 [PATCH] backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls Xu Wang
@ 2022-01-13 15:02 ` Daniel Thompson
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Thompson @ 2022-01-13 15:02 UTC (permalink / raw)
To: Xu Wang; +Cc: lee.jones, jingoohan1, dri-devel, linux-fbdev, linux-kernel
On Thu, Jan 13, 2022 at 08:48:06AM +0000, Xu Wang wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-13 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-13 8:48 [PATCH] backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls Xu Wang
2022-01-13 15:02 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).