From: Gerd Hoffmann <kraxel@redhat.com>
To: Helge Deller <deller@gmx.de>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, Sven Schnelle <svens@stackframe.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Javier Martinez Canillas <javierm@redhat.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Ilia Mirkin <imirkin@alum.mit.edu>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Sam Ravnborg <sam@ravnborg.org>, Claudio Suarez <cssk@net-c.es>
Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"
Date: Fri, 21 Jan 2022 08:20:06 +0100 [thread overview]
Message-ID: <20220121072006.ylw2hdl7jbkbwnre@sirius.home.kraxel.org> (raw)
In-Reply-To: <6c000477-002b-d125-b945-2c4831bad8a5@gmx.de>
Hi,
> > So if this really has to come back then I think the pragmatic approach is
> > to do it behind a CONFIG_FBCON_ACCEL, default n, and with a huge warning
> > that enabling that shouldn't be done for any distro which only enables
> > firmware and drm fbdev drivers.
>
> Thanks for coming back on this, but quite frankly I don't understand
> that request. How should that warning look like, something along:
> "BE WARNED: The framebuffer text console on your non-DRM supported
> graphic card will then run faster and smoother if you enable this option."
> That doesn't make sense. People and distros would want to enable that.
Nope. Most distros want disable fbdev drivers rather sooner than later.
The fbdev drivers enabled in the fedora kernel today:
CONFIG_FB_VGA16=m
CONFIG_FB_VESA=y
CONFIG_FB_EFI=y
CONFIG_FB_SSD1307=m
CONFIG_FB_VESA + CONFIG_FB_EFI will go away soon, with simpledrm taking
over their role.
> And if a distro *just* has firmware and drm fbdev drivers enabled,
> none of the non-DRM graphic cards would be loaded anyway and this code
> wouldn't be executed anyway.
Yes, exactly. That's why there is no point in compiling that code.
take care,
Gerd
next prev parent reply other threads:[~2022-01-21 7:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 11:08 [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Helge Deller
2022-01-19 11:08 ` [PATCH 1/2] Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Helge Deller
2022-01-19 11:08 ` [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Helge Deller
2022-01-19 11:22 ` Greg Kroah-Hartman
2022-01-19 11:28 ` Greg Kroah-Hartman
2022-01-19 11:47 ` Geert Uytterhoeven
2022-01-19 12:28 ` Helge Deller
2022-01-19 14:01 ` Linus Torvalds
2022-01-19 14:11 ` Helge Deller
2022-01-19 14:34 ` Daniel Vetter
2022-01-19 15:05 ` Sven Schnelle
2022-01-19 15:37 ` Thomas Zimmermann
2022-01-19 16:55 ` Helge Deller
2022-01-19 15:42 ` Daniel Vetter
2022-01-19 15:54 ` Helge Deller
2022-01-19 16:13 ` Jani Nikula
2022-01-19 16:31 ` Daniel Vetter
2022-01-19 15:18 ` Helge Deller
2022-01-19 13:01 ` Sven Schnelle
2022-01-19 13:35 ` Greg Kroah-Hartman
2022-01-20 14:30 ` Daniel Vetter
2022-01-20 17:01 ` Helge Deller
2022-01-21 7:20 ` Gerd Hoffmann [this message]
2022-01-24 11:10 ` Helge Deller
2022-01-24 11:28 ` Javier Martinez Canillas
2022-01-24 11:33 ` Thomas Zimmermann
2022-01-24 11:50 ` Javier Martinez Canillas
2022-01-24 15:29 ` Helge Deller
2022-01-24 15:45 ` Thomas Zimmermann
2022-01-24 15:50 ` Geert Uytterhoeven
2022-01-24 15:58 ` Daniel Vetter
2022-01-24 15:50 ` Geert Uytterhoeven
2022-01-24 16:11 ` Thomas Zimmermann
2022-01-19 12:45 ` [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Geert Uytterhoeven
2022-01-19 13:02 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121072006.ylw2hdl7jbkbwnre@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=cssk@net-c.es \
--cc=daniel.vetter@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=imirkin@alum.mit.edu \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sam@ravnborg.org \
--cc=svens@stackframe.org \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).