* [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value [not found] <20220121165436.30956-1-sampaio.ime@gmail.com> @ 2022-01-21 16:54 ` Luiz Sampaio 2022-01-21 17:05 ` Daniel Thompson 0 siblings, 1 reply; 5+ messages in thread From: Luiz Sampaio @ 2022-01-21 16:54 UTC (permalink / raw) To: Michael Hennerich, Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller Cc: linux-kernel, Luiz Sampaio, dri-devel, linux-fbdev The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/video/backlight/adp8860_bl.c | 4 ++-- drivers/video/backlight/adp8870_bl.c | 4 ++-- drivers/video/backlight/led_bl.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 8ec19425671f..063be4189e7e 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c @@ -261,10 +261,10 @@ static int adp8860_led_probe(struct i2c_client *client) led_dat->cdev.name = cur_led->name; led_dat->cdev.default_trigger = cur_led->default_trigger; led_dat->cdev.brightness_set = adp8860_led_set; - led_dat->cdev.brightness = LED_OFF; + led_dat->cdev.brightness = 0; led_dat->flags = cur_led->flags >> FLAG_OFFT_SHIFT; led_dat->client = client; - led_dat->new_brightness = LED_OFF; + led_dat->new_brightness = 0; INIT_WORK(&led_dat->work, adp8860_led_work); ret = led_classdev_register(&client->dev, &led_dat->cdev); diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c index 8b5213a39527..b04faf8d631d 100644 --- a/drivers/video/backlight/adp8870_bl.c +++ b/drivers/video/backlight/adp8870_bl.c @@ -287,10 +287,10 @@ static int adp8870_led_probe(struct i2c_client *client) led_dat->cdev.name = cur_led->name; led_dat->cdev.default_trigger = cur_led->default_trigger; led_dat->cdev.brightness_set = adp8870_led_set; - led_dat->cdev.brightness = LED_OFF; + led_dat->cdev.brightness = 0; led_dat->flags = cur_led->flags >> FLAG_OFFT_SHIFT; led_dat->client = client; - led_dat->new_brightness = LED_OFF; + led_dat->new_brightness = 0; INIT_WORK(&led_dat->work, adp8870_led_work); ret = led_classdev_register(&client->dev, &led_dat->cdev); diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c index f54d256e2d54..1b869624b4f8 100644 --- a/drivers/video/backlight/led_bl.c +++ b/drivers/video/backlight/led_bl.c @@ -46,7 +46,7 @@ static void led_bl_power_off(struct led_bl_data *priv) return; for (i = 0; i < priv->nb_leds; i++) - led_set_brightness(priv->leds[i], LED_OFF); + led_set_brightness(priv->leds[i], 0); priv->enabled = false; } -- 2.34.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value 2022-01-21 16:54 ` [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value Luiz Sampaio @ 2022-01-21 17:05 ` Daniel Thompson 2022-01-21 18:06 ` Luiz Sampaio 2022-01-21 18:09 ` Luiz Sampaio 0 siblings, 2 replies; 5+ messages in thread From: Daniel Thompson @ 2022-01-21 17:05 UTC (permalink / raw) To: Luiz Sampaio Cc: Michael Hennerich, Lee Jones, Jingoo Han, Helge Deller, linux-kernel, dri-devel, linux-fbdev On Fri, Jan 21, 2022 at 01:54:29PM -0300, Luiz Sampaio wrote: > The enum led_brightness, which contains the declaration of LED_OFF, > LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports > max_brightness. Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> BTW it looks like this patch might wants to land in one tree (I can't see since I'm only on copy of this one). If so please discuss with Lee how you want to land it. Put more directly, please don't treat my Reviewed-by: as an Acked-by: ;-) ! Daniel. > --- > drivers/video/backlight/adp8860_bl.c | 4 ++-- > drivers/video/backlight/adp8870_bl.c | 4 ++-- > drivers/video/backlight/led_bl.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c > index 8ec19425671f..063be4189e7e 100644 > --- a/drivers/video/backlight/adp8860_bl.c > +++ b/drivers/video/backlight/adp8860_bl.c > @@ -261,10 +261,10 @@ static int adp8860_led_probe(struct i2c_client *client) > led_dat->cdev.name = cur_led->name; > led_dat->cdev.default_trigger = cur_led->default_trigger; > led_dat->cdev.brightness_set = adp8860_led_set; > - led_dat->cdev.brightness = LED_OFF; > + led_dat->cdev.brightness = 0; > led_dat->flags = cur_led->flags >> FLAG_OFFT_SHIFT; > led_dat->client = client; > - led_dat->new_brightness = LED_OFF; > + led_dat->new_brightness = 0; > INIT_WORK(&led_dat->work, adp8860_led_work); > > ret = led_classdev_register(&client->dev, &led_dat->cdev); > diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c > index 8b5213a39527..b04faf8d631d 100644 > --- a/drivers/video/backlight/adp8870_bl.c > +++ b/drivers/video/backlight/adp8870_bl.c > @@ -287,10 +287,10 @@ static int adp8870_led_probe(struct i2c_client *client) > led_dat->cdev.name = cur_led->name; > led_dat->cdev.default_trigger = cur_led->default_trigger; > led_dat->cdev.brightness_set = adp8870_led_set; > - led_dat->cdev.brightness = LED_OFF; > + led_dat->cdev.brightness = 0; > led_dat->flags = cur_led->flags >> FLAG_OFFT_SHIFT; > led_dat->client = client; > - led_dat->new_brightness = LED_OFF; > + led_dat->new_brightness = 0; > INIT_WORK(&led_dat->work, adp8870_led_work); > > ret = led_classdev_register(&client->dev, &led_dat->cdev); > diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c > index f54d256e2d54..1b869624b4f8 100644 > --- a/drivers/video/backlight/led_bl.c > +++ b/drivers/video/backlight/led_bl.c > @@ -46,7 +46,7 @@ static void led_bl_power_off(struct led_bl_data *priv) > return; > > for (i = 0; i < priv->nb_leds; i++) > - led_set_brightness(priv->leds[i], LED_OFF); > + led_set_brightness(priv->leds[i], 0); > > priv->enabled = false; > } > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value 2022-01-21 17:05 ` Daniel Thompson @ 2022-01-21 18:06 ` Luiz Sampaio 2022-01-21 18:09 ` Luiz Sampaio 1 sibling, 0 replies; 5+ messages in thread From: Luiz Sampaio @ 2022-01-21 18:06 UTC (permalink / raw) To: daniel.thompson Cc: michael.hennerich, lee.jones, jingoohan1, deller, linux-kernel, dri-devel, linux-fbdev, Luiz Sampaio Hello, Daniel Thanks for your reply. This is one of my first patches, so I am still learning. This series of patches affects others subsystems too (hid, leds, sound etc). Should I create series for each subsystem separately, instead of creating one series for everyone? What do you mean by "this patch might wants to land in one tree"? Thank you for your attention! ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value 2022-01-21 17:05 ` Daniel Thompson 2022-01-21 18:06 ` Luiz Sampaio @ 2022-01-21 18:09 ` Luiz Sampaio 2022-01-24 10:53 ` Lee Jones 1 sibling, 1 reply; 5+ messages in thread From: Luiz Sampaio @ 2022-01-21 18:09 UTC (permalink / raw) To: daniel.thompson Cc: michael.hennerich, lee.jones, jingoohan1, deller, linux-kernel, dri-devel, linux-fbdev, Luiz Sampaio Hello, Daniel Thanks for your reply. This is one of my first patches, so I am still learning. This series of patches affects others subsystems too (hid, leds, sound etc). Should I create series for each subsystem separately, instead of creating one series for everyone? What do you mean by "this patch might wants to land in one tree"? Thank you for your attention! ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value 2022-01-21 18:09 ` Luiz Sampaio @ 2022-01-24 10:53 ` Lee Jones 0 siblings, 0 replies; 5+ messages in thread From: Lee Jones @ 2022-01-24 10:53 UTC (permalink / raw) To: Luiz Sampaio Cc: daniel.thompson, michael.hennerich, jingoohan1, deller, linux-kernel, dri-devel, linux-fbdev On Fri, 21 Jan 2022, Luiz Sampaio wrote: > Hello, Daniel > > Thanks for your reply. This is one of my first patches, so I am still > learning. This series of patches affects others subsystems too (hid, > leds, sound etc). Should I create series for each subsystem > separately, instead of creating one series for everyone? > What do you mean by "this patch might wants to land in one tree"? Can the individual patches be applied on their own without causing issues (warnings/errors) with the build? If so, they can be applied separately via their associated subsystem trees. If not, someone will have to collect them all and take them via a single tree with Acks from the other subsystem maintainers. It's difficult to make that decision for ourselves since you didn't share all of the patches with all of the maintainers. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-24 10:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220121165436.30956-1-sampaio.ime@gmail.com>
2022-01-21 16:54 ` [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value Luiz Sampaio
2022-01-21 17:05 ` Daniel Thompson
2022-01-21 18:06 ` Luiz Sampaio
2022-01-21 18:09 ` Luiz Sampaio
2022-01-24 10:53 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).