Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: Javier Martinez Canillas <javierm@redhat.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Sven Schnelle <svens@stackframe.org>,
	Claudio Suarez <cssk@net-c.es>, Pavel Machek <pavel@ucw.cz>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Ilia Mirkin <imirkin@alum.mit.edu>,
	Sam Ravnborg <sam@ravnborg.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH v2 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon
Date: Mon, 24 Jan 2022 22:03:17 +0100	[thread overview]
Message-ID: <20220124210319.325512-1-deller@gmx.de> (raw)

This series reverts two patches which disabled scrolling acceleration in
fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic
cards because of the performance penalty by doing screen scrolling by software
instead of using existing 2D hardware acceleration.

This series has been discussed on linux-fbdev, dri-devel and linux-kernel
mailing lists. The consensus is that they will be reverted, but in addition
it's being worked on to find a solution which allows to disable parts of the
classic fbdev hardware acceleration code which isn't needed in DRM-only
configurations.

The patchset is planned to be kept in fbdev's for-next git branch and later
pushed into kernel v5.18 if no issues are found until then.

Helge

---
Changes in v2 compared to v1:
- adjusted the stable tags (one v5.10+, the other v5.16+)
- moved the analysis and reasoning why those should be reverted into
  the commit message. That simplifies to analyze later why they were
  reverted.
- resorted the To an Cc mail recipient lists

Helge Deller (2):
  Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1
    (from TODO list)"
  Revert "fbcon: Disable accelerated scrolling"

 Documentation/gpu/todo.rst              |  24 --
 drivers/video/fbdev/core/bitblit.c      |  16 +
 drivers/video/fbdev/core/fbcon.c        | 540 +++++++++++++++++++++++-
 drivers/video/fbdev/core/fbcon.h        |  59 +++
 drivers/video/fbdev/core/fbcon_ccw.c    |  28 +-
 drivers/video/fbdev/core/fbcon_cw.c     |  28 +-
 drivers/video/fbdev/core/fbcon_rotate.h |   9 +
 drivers/video/fbdev/core/fbcon_ud.c     |  37 +-
 drivers/video/fbdev/core/tileblit.c     |  16 +
 drivers/video/fbdev/skeletonfb.c        |  12 +-
 include/linux/fb.h                      |   2 +-
 11 files changed, 703 insertions(+), 68 deletions(-)

-- 
2.31.1


             reply	other threads:[~2022-01-24 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 21:03 Helge Deller [this message]
2022-01-24 21:03 ` [PATCH v2 1/2] Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Helge Deller
2022-01-24 21:03 ` [PATCH v2 2/2] Revert "fbcon: Disable accelerated scrolling" Helge Deller
2022-01-24 22:19 ` [PATCH v2 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Daniel Vetter
2022-01-24 22:37   ` Helge Deller
2022-01-24 22:41     ` Daniel Vetter
2022-01-25  8:30 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220124210319.325512-1-deller@gmx.de \
    --to=deller@gmx.de \
    --cc=cssk@net-c.es \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imirkin@alum.mit.edu \
    --cc=jani.nikula@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sam@ravnborg.org \
    --cc=svens@stackframe.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=torvalds@linux-foundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox