From: Michal Suchanek <msuchanek@suse.de>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: Michal Suchanek <msuchanek@suse.de>, Martin Mares <mj@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Helge Deller <deller@gmx.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Arnd Bergmann <arnd@arndb.de>,
Cristian Marussi <cristian.marussi@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Herrmann <dh.herrmann@gmail.com>,
linux-video@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] simplefb: Enable boot time VESA graphic mode selection.
Date: Fri, 18 Feb 2022 11:51:38 +0100 [thread overview]
Message-ID: <20220218105138.5384-1-msuchanek@suse.de> (raw)
In-Reply-To: <14dd85f1-21b1-2ff7-3491-466c077210e6@suse.de>
Since switch to simplefb/simpledrm VESA graphic modes are no longer
available with legacy BIOS.
The x86 realmode boot code enables the VESA graphic modes when option
FB_BOOT_VESA_SUPPORT is enabled.
To enable use of VESA modes with simpledrm in legacy BIOS boot mode drop
dependency of BOOT_VESA_SUPPORT on FB, also drop the FB_ prefix, and
select the option when simpledrm is built-in on x86.
Fixes: e3263ab389a7 ("x86: provide platform-devices for boot-framebuffers")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
v2: Select BOOT_VESA_SUPPORT from simplefb rather than simpledrm. The
simpledrm driver uses the firmware provided video modes only indirectly
through simplefb, and both can be enabled independently.
---
arch/x86/boot/video-vesa.c | 4 ++--
drivers/firmware/Kconfig | 1 +
drivers/video/fbdev/Kconfig | 9 ++++-----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/x86/boot/video-vesa.c b/arch/x86/boot/video-vesa.c
index 7e185977a984..c2c6d35e3a43 100644
--- a/arch/x86/boot/video-vesa.c
+++ b/arch/x86/boot/video-vesa.c
@@ -83,7 +83,7 @@ static int vesa_probe(void)
(vminfo.memory_layout == 4 ||
vminfo.memory_layout == 6) &&
vminfo.memory_planes == 1) {
-#ifdef CONFIG_FB_BOOT_VESA_SUPPORT
+#ifdef CONFIG_BOOT_VESA_SUPPORT
/* Graphics mode, color, linear frame buffer
supported. Only register the mode if
if framebuffer is configured, however,
@@ -121,7 +121,7 @@ static int vesa_set_mode(struct mode_info *mode)
if ((vminfo.mode_attr & 0x15) == 0x05) {
/* It's a supported text mode */
is_graphic = 0;
-#ifdef CONFIG_FB_BOOT_VESA_SUPPORT
+#ifdef CONFIG_BOOT_VESA_SUPPORT
} else if ((vminfo.mode_attr & 0x99) == 0x99) {
/* It's a graphics mode with linear frame buffer */
is_graphic = 1;
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 75cb91055c17..8053c75b8645 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -224,6 +224,7 @@ config SYSFB
config SYSFB_SIMPLEFB
bool "Mark VGA/VBE/EFI FB as generic system framebuffer"
depends on SYSFB
+ select BOOT_VESA_SUPPORT if X86
help
Firmwares often provide initial graphics framebuffers so the BIOS,
bootloader or kernel can show basic video-output during boot for
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 6ed5e608dd04..4f3be9b7a520 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -66,9 +66,8 @@ config FB_DDC
select I2C_ALGOBIT
select I2C
-config FB_BOOT_VESA_SUPPORT
+config BOOT_VESA_SUPPORT
bool
- depends on FB
help
If true, at least one selected framebuffer driver can take advantage
of VESA video modes set at an early boot stage via the vga= parameter.
@@ -627,7 +626,7 @@ config FB_VESA
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_BOOT_VESA_SUPPORT
+ select BOOT_VESA_SUPPORT
help
This is the frame buffer device driver for generic VESA 2.0
compliant graphic cards. The older VESA 1.2 cards are not supported.
@@ -1051,7 +1050,7 @@ config FB_INTEL
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_BOOT_VESA_SUPPORT if FB_INTEL = y
+ select BOOT_VESA_SUPPORT if FB_INTEL = y
depends on !DRM_I915
help
This driver supports the on-board graphics built in to the Intel
@@ -1378,7 +1377,7 @@ config FB_SIS
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_BOOT_VESA_SUPPORT if FB_SIS = y
+ select BOOT_VESA_SUPPORT if FB_SIS = y
select FB_SIS_300 if !FB_SIS_315
help
This is the frame buffer device driver for the SiS 300, 315, 330
--
2.31.1
next prev parent reply other threads:[~2022-02-18 10:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 9:33 [PATCH] simpldrm: Enable boot time VESA graphic mode selection Michal Suchanek
2022-02-18 9:57 ` Thomas Zimmermann
2022-02-18 10:08 ` Michal Suchánek
2022-02-18 10:24 ` Thomas Zimmermann
2022-02-18 10:51 ` Michal Suchanek [this message]
2022-02-18 11:36 ` [PATCH v2] simplefb: " Thomas Zimmermann
2022-02-18 12:05 ` Michal Suchánek
2022-02-18 16:04 ` [PATCH v3] " Michal Suchanek
2022-02-21 9:51 ` Thomas Zimmermann
2022-02-23 18:38 ` Borislav Petkov
2022-02-23 16:34 ` Javier Martinez Canillas
2022-02-23 16:45 ` Michal Suchánek
2022-02-23 16:54 ` Javier Martinez Canillas
2022-02-23 17:07 ` Javier Martinez Canillas
2022-02-23 17:12 ` Michal Suchánek
2022-02-23 18:13 ` Javier Martinez Canillas
2022-02-23 18:23 ` Michal Suchánek
2022-02-23 18:34 ` Javier Martinez Canillas
2022-02-23 19:55 ` Michal Suchánek
2022-02-25 20:51 ` [PATCH v4 1/3] sysfb: Make config option dependencies explicit Michal Suchanek
2022-02-25 22:09 ` Javier Martinez Canillas
2022-02-25 20:51 ` [PATCH v4 2/3] sysfb: Enable boot time VESA graphic mode selection Michal Suchanek
2022-02-25 22:10 ` Javier Martinez Canillas
2022-02-25 20:51 ` [PATCH v4 3/3] efifb: Remove redundant efifb_setup_from_dmi stub Michal Suchanek
2022-02-25 22:11 ` Javier Martinez Canillas
2022-03-02 19:31 ` [PATCH] simpldrm: Enable boot time VESA graphic mode selection Thomas Zimmermann
2022-03-02 19:38 ` Michal Suchánek
2022-03-02 19:47 ` Javier Martinez Canillas
2022-03-04 20:00 ` Thomas Zimmermann
2022-03-04 20:47 ` Javier Martinez Canillas
2022-03-07 14:33 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218105138.5384-1-msuchanek@suse.de \
--to=msuchanek@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=bp@alien8.de \
--cc=cristian.marussi@arm.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-video@atrey.karlin.mff.cuni.cz \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mingo@redhat.com \
--cc=mj@ucw.cz \
--cc=robh@kernel.org \
--cc=simont@opensource.cirrus.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).