* [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger binding documentation
2022-05-31 10:42 [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation ChiaEn Wu
@ 2022-05-31 10:42 ` ChiaEn Wu
2022-05-31 20:14 ` Krzysztof Kozlowski
2022-05-31 10:42 ` [PATCH 11/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 indicator documentation ChiaEn Wu
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: ChiaEn Wu @ 2022-05-31 10:42 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
From: ChiaEn Wu <chiaen_wu@richtek.com>
Add Mediatek MT6370 Charger binding documentation.
Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
---
.../power/supply/mediatek,mt6370-charger.yaml | 60 +++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
new file mode 100644
index 000000000000..9d5c4487ca9c
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT6370 Battery Charger
+
+maintainers:
+ - ChiaEn Wu <chiaen_wu@richtek.com>
+
+description: |
+ This module is part of the MT6370 MFD device.
+ Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
+
+properties:
+ compatible:
+ const: mediatek,mt6370-charger
+
+ interrupts:
+ description: |
+ Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
+ "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
+ are required.
+ items:
+ - description: BC1.2 done irq for mt6370 charger
+ - description: usb plug in irq for mt6370 charger
+ - description: mivr irq for mt6370 charger
+
+ interrupt-names:
+ items:
+ - const: attach_i
+ - const: uvp_d_evt
+ - const: mivr
+
+ io-channels:
+ description: |
+ Use ADC channel to read vbus, ibus, ibat, etc., info. Ibus ADC channel
+ is required.
+
+ usb-otg-vbus:
+ type: object
+ description: OTG boost regulator.
+ $ref: /schemas/regulator/regulator.yaml#
+
+ properties:
+ enable-gpio:
+ maxItems: 1
+ description: |
+ Specify a valid 'enable' gpio for the regulator and it's optional
+
+required:
+ - compatible
+ - interrupts
+ - interrupt-names
+ - io-channels
+
+additionalProperties: false
+
+...
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger binding documentation
2022-05-31 10:42 ` [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger " ChiaEn Wu
@ 2022-05-31 20:14 ` Krzysztof Kozlowski
2022-06-02 18:34 ` ChiaEn Wu
0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 20:14 UTC (permalink / raw)
To: ChiaEn Wu, lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
On 31/05/2022 12:42, ChiaEn Wu wrote:
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
Subject - remove "binding documentation". It's already implied by prefix.
> Add Mediatek MT6370 Charger binding documentation.
>
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
> .../power/supply/mediatek,mt6370-charger.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> new file mode 100644
> index 000000000000..9d5c4487ca9c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6370 Battery Charger
> +
> +maintainers:
> + - ChiaEn Wu <chiaen_wu@richtek.com>
> +
> +description: |
> + This module is part of the MT6370 MFD device.
> + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-charger
> +
> + interrupts:
> + description: |
> + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
> + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
> + are required.
> + items:
> + - description: BC1.2 done irq for mt6370 charger
> + - description: usb plug in irq for mt6370 charger
> + - description: mivr irq for mt6370 charger
s/for mt6370 charger//
in each item
> +
> + interrupt-names:
> + items:
> + - const: attach_i
> + - const: uvp_d_evt
> + - const: mivr
> +
> + io-channels:
> + description: |
> + Use ADC channel to read vbus, ibus, ibat, etc., info. Ibus ADC channel
> + is required.
Constraints (e.g. maxItems) are needed.
> +
> + usb-otg-vbus:
Let's keep the same name as in MT6360:
usb-otg-vbus-regulator
> + type: object
> + description: OTG boost regulator.
> + $ref: /schemas/regulator/regulator.yaml#
> +
> + properties:
> + enable-gpio:
> + maxItems: 1
> + description: |
> + Specify a valid 'enable' gpio for the regulator and it's optional
This description is pointless - does not bring any more information. You
repeat the schema. Please, avoid such descriptions.
> +
> +required:
> + - compatible
> + - interrupts
> + - interrupt-names
> + - io-channels
> +
> +additionalProperties: false
How about example? Or is it going to be in MFD schema?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger binding documentation
2022-05-31 20:14 ` Krzysztof Kozlowski
@ 2022-06-02 18:34 ` ChiaEn Wu
0 siblings, 0 replies; 12+ messages in thread
From: ChiaEn Wu @ 2022-06-02 18:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller,
ChiYuan Huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
Hi Krzysztof,
Thank you for the valuable suggestion.
Sorry for sending the same email again. I forgot to reply to everyone
in my last email..
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年6月1日 週三 上午4:15寫道：
>
> On 31/05/2022 12:42, ChiaEn Wu wrote:
> > From: ChiaEn Wu <chiaen_wu@richtek.com>
> >
>
> Subject - remove "binding documentation". It's already implied by prefix.
>
> > Add Mediatek MT6370 Charger binding documentation.
> >
> > Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> > ---
> > .../power/supply/mediatek,mt6370-charger.yaml | 60 +++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> > new file mode 100644
> > index 000000000000..9d5c4487ca9c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT6370 Battery Charger
> > +
> > +maintainers:
> > + - ChiaEn Wu <chiaen_wu@richtek.com>
> > +
> > +description: |
> > + This module is part of the MT6370 MFD device.
> > + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6370-charger
> > +
> > + interrupts:
> > + description: |
> > + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
> > + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
> > + are required.
> > + items:
> > + - description: BC1.2 done irq for mt6370 charger
> > + - description: usb plug in irq for mt6370 charger
> > + - description: mivr irq for mt6370 charger
>
> s/for mt6370 charger//
> in each item
I got it, this will be refined in the next version. Thanks!
>
> > +
> > + interrupt-names:
> > + items:
> > + - const: attach_i
> > + - const: uvp_d_evt
> > + - const: mivr
> > +
> > + io-channels:
> > + description: |
> > + Use ADC channel to read vbus, ibus, ibat, etc., info. Ibus ADC channel
> > + is required.
>
> Constraints (e.g. maxItems) are needed.
OK, I will add them in the new version!
>
> > +
> > + usb-otg-vbus:
>
> Let's keep the same name as in MT6360:
>
> usb-otg-vbus-regulator
I'll change the name to correspond with MT6360 in the next patch, thanks!
> > + type: object
> > + description: OTG boost regulator.
> > + $ref: /schemas/regulator/regulator.yaml#
> > +
> > + properties:
> > + enable-gpio:
> > + maxItems: 1
> > + description: |
> > + Specify a valid 'enable' gpio for the regulator and it's optional
>
> This description is pointless - does not bring any more information. You
> repeat the schema. Please, avoid such descriptions.
I got it, I will remove them in the next patch.
>
> > +
> > +required:
> > + - compatible
> > + - interrupts
> > + - interrupt-names
> > + - io-channels
> > +
> > +additionalProperties: false
>
>
> How about example? Or is it going to be in MFD schema?
All of MT6370 binding documentation examples are in the MFD schema! Thanks.
>
>
> Best regards,
> Krzysztof
Best regards,
ChiaEn Wu
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 11/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 indicator documentation
2022-05-31 10:42 [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation ChiaEn Wu
2022-05-31 10:42 ` [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger " ChiaEn Wu
@ 2022-05-31 10:42 ` ChiaEn Wu
2022-05-31 20:38 ` Krzysztof Kozlowski
2022-05-31 10:42 ` [PATCH 12/14] dt-bindings: leds: Add Mediatek MT6370 flashlight binding documentation ChiaEn Wu
` (2 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: ChiaEn Wu @ 2022-05-31 10:42 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
From: ChiYuan Huang <cy_huang@richtek.com>
Add Mediatek mt6370 indicator documentation.
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
.../leds/mediatek,mt6370-indicator.yaml | 57 +++++++++++++++++++
1 file changed, 57 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
new file mode 100644
index 000000000000..823be3add097
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LED driver for MT6370 PMIC from MediaTek Integrated.
+
+maintainers:
+ - Alice Chen <alice_chen@richtek.com>
+
+description: |
+ This module is part of the MT6370 MFD device.
+ see Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
+ Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode
+
+properties:
+ compatible:
+ const: mediatek,mt6370-indicator
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^(multi-)?led@[0-3]$":
+ description: |
+ Properties for a single LED.
+ $ref: common.yaml#
+ type: object
+
+ properties:
+ reg:
+ description: |
+ Index of the LED.
+ enum:
+ - 0 # LED output ISINK1
+ - 1 # LED output ISINK2
+ - 2 # LED output ISINK3
+ - 3 # LED output ISINK4
+
+ mediatek,soft-start:
+ description: |
+ soft start step control, support /0.5ms/1ms/1.5ms/2ms.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0, 1, 2, 3]
+
+ unevaluatedProperties: false
+
+required:
+ - compatible
+ - "#address-cells"
+ - "#size-cells"
+
+additionalProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 11/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 indicator documentation
2022-05-31 10:42 ` [PATCH 11/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 indicator documentation ChiaEn Wu
@ 2022-05-31 20:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 20:38 UTC (permalink / raw)
To: ChiaEn Wu, lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
On 31/05/2022 12:42, ChiaEn Wu wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add Mediatek mt6370 indicator documentation.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> .../leds/mediatek,mt6370-indicator.yaml | 57 +++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
> new file mode 100644
> index 000000000000..823be3add097
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for MT6370 PMIC from MediaTek Integrated.
> +
> +maintainers:
> + - Alice Chen <alice_chen@richtek.com>
> +
> +description: |
> + This module is part of the MT6370 MFD device.
> + see Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
> + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-indicator
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^(multi-)?led@[0-3]$":
> + description: |
> + Properties for a single LED.
Not useful description. Just skip it, I think schema allows it.
> + $ref: common.yaml#
> + type: object
> +
> + properties:
> + reg:
> + description: |
> + Index of the LED.
The same, regs are usually not described.
> + enum:
> + - 0 # LED output ISINK1
> + - 1 # LED output ISINK2
> + - 2 # LED output ISINK3
> + - 3 # LED output ISINK4
> +
> + mediatek,soft-start:
> + description: |
> + soft start step control, support /0.5ms/1ms/1.5ms/2ms.
Why here you start sentence lower-case?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 1, 2, 3]
This has to be in logical values, so in ms, not in some register values.
Use proper unit suffix and enumerate the actual values.
> +
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - "#address-cells"
> + - "#size-cells"
> +
> +additionalProperties: false
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 12/14] dt-bindings: leds: Add Mediatek MT6370 flashlight binding documentation
2022-05-31 10:42 [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation ChiaEn Wu
2022-05-31 10:42 ` [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger " ChiaEn Wu
2022-05-31 10:42 ` [PATCH 11/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 indicator documentation ChiaEn Wu
@ 2022-05-31 10:42 ` ChiaEn Wu
2022-05-31 20:40 ` Krzysztof Kozlowski
2022-05-31 10:42 ` [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight " ChiaEn Wu
2022-05-31 10:42 ` [PATCH 14/14] dt-bindings: mfd: Add Mediatek MT6370 " ChiaEn Wu
4 siblings, 1 reply; 12+ messages in thread
From: ChiaEn Wu @ 2022-05-31 10:42 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
From: Alice Chen <alice_chen@richtek.com>
Add Mediatek MT6370 flashlight binding documentation
Signed-off-by: Alice Chen <alice_chen@richtek.com>
---
.../leds/mediatek,mt6370-flashlight.yaml | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
new file mode 100644
index 000000000000..b1b11bd3d410
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-mt6370-flashlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Flash LED driver for MT6370 PMIC from MediaTek Integrated.
+
+maintainers:
+ - Alice Chen <alice_chen@richtek.com>
+
+description: |
+ This module is part of the MT6370 MFD device.
+ see Documentation/devicetree/bindings/mfd/mt6370.yaml
+ Add MT6370 flash LED driver include 2-channel flash LED support Torch/Strobe Mode.
+
+properties:
+ compatible:
+ const: mediatek,mt6370-flashlight
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^led@[0-1]$":
+ type: object
+ $ref: common.yaml#
+ description:
+ Properties for a single flash LED.
+
+ properties:
+ reg:
+ description: Index of the flash LED.
+ enum:
+ - 0 #Address of LED1
+ - 1 #Address of LED2
+
+ unevaluatedProperties: false
+
+required:
+ - compatible
+ - "#address-cells"
+ - "#size-cells"
+
+additionalProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 12/14] dt-bindings: leds: Add Mediatek MT6370 flashlight binding documentation
2022-05-31 10:42 ` [PATCH 12/14] dt-bindings: leds: Add Mediatek MT6370 flashlight binding documentation ChiaEn Wu
@ 2022-05-31 20:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 20:40 UTC (permalink / raw)
To: ChiaEn Wu, lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
On 31/05/2022 12:42, ChiaEn Wu wrote:
> From: Alice Chen <alice_chen@richtek.com>
>
Subject - same comment as previous #10 patch.
> Add Mediatek MT6370 flashlight binding documentation
>
> Signed-off-by: Alice Chen <alice_chen@richtek.com>
> ---
> .../leds/mediatek,mt6370-flashlight.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
> new file mode 100644
> index 000000000000..b1b11bd3d410
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-mt6370-flashlight.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Flash LED driver for MT6370 PMIC from MediaTek Integrated.
> +
> +maintainers:
> + - Alice Chen <alice_chen@richtek.com>
> +
> +description: |
> + This module is part of the MT6370 MFD device.
> + see Documentation/devicetree/bindings/mfd/mt6370.yaml
> + Add MT6370 flash LED driver include 2-channel flash LED support Torch/Strobe Mode.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-flashlight
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^led@[0-1]$":
> + type: object
> + $ref: common.yaml#
> + description:
> + Properties for a single flash LED.
Same as patch #11.
> +
> + properties:
> + reg:
> + description: Index of the flash LED.
As well.
> + enum:
> + - 0 #Address of LED1
> + - 1 #Address of LED2
'#' starts a comment, so there is always a space after '#'
> +
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - "#address-cells"
> + - "#size-cells"
> +
> +additionalProperties: false
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight binding documentation
2022-05-31 10:42 [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation ChiaEn Wu
` (2 preceding siblings ...)
2022-05-31 10:42 ` [PATCH 12/14] dt-bindings: leds: Add Mediatek MT6370 flashlight binding documentation ChiaEn Wu
@ 2022-05-31 10:42 ` ChiaEn Wu
2022-05-31 10:42 ` [PATCH 14/14] dt-bindings: mfd: Add Mediatek MT6370 " ChiaEn Wu
4 siblings, 0 replies; 12+ messages in thread
From: ChiaEn Wu @ 2022-05-31 10:42 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
From: ChiYuan Huang <cy_huang@richtek.com>
Add mt6370 backlight binding documentation.
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
.../backlight/mediatek,mt6370-backlight.yaml | 110 ++++++++++++++++++
1 file changed, 110 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
diff --git a/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
new file mode 100644
index 000000000000..81d72ed44be4
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
@@ -0,0 +1,110 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT6370 Backlight
+
+maintainers:
+ - ChiaEn Wu <chiaen_wu@richtek.com>
+
+description: |
+ MT6370 is a highly-integrated smart power management IC, which includes a
+ single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
+ Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
+ driver, a backlight WLED driver, a display bias driver and a general LDO for
+ portable devices.
+
+ For the LCD backlight, it can provide 4 channel WLED driving capability.
+ Each channel driving current is up to 30mA
+
+allOf:
+ - $ref: common.yaml#
+
+properties:
+ compatible:
+ const: mediatek,mt6370-backlight
+
+ default-brightness:
+ minimum: 0
+ maximum: 2048
+
+ max-brightness:
+ minimum: 0
+ maximum: 2048
+
+ enable-gpios:
+ description: External backlight 'enable' pin
+ maxItems: 1
+
+ mediatek,bled-pwm-enable:
+ description: |
+ Enable external PWM input for backlight dimming
+ type: boolean
+
+ mediatek,bled-pwm-hys-enable:
+ description: |
+ Enable the backlight input-hysteresis for PWM mode
+ type: boolean
+
+ mediatek,bled-pwm-hys-sel:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ enum: [0, 1, 2, 3]
+ description: |
+ Backlight PWM hysteresis input level selection.
+ value mapping:
+ - 0: 1bit
+ - 1: 2bit
+ - 2: 4bit
+ - 3: 6bit
+
+ mediatek,bled-ovp-shutdown:
+ description: |
+ Enable the backlight shutdown when OVP level triggered
+ type: boolean
+
+ mediatek,bled-ovp-level-sel:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ enum: [0, 1, 2, 3]
+ description: |
+ Backlight OVP level selection.
+ value mapping:
+ - 0: 17V
+ - 1: 21V
+ - 2: 25V
+ - 3: 29V
+
+ mediatek,bled-ocp-shutdown:
+ description: |
+ Enable the backlight shutdown when OCP level triggerred.
+ type: boolean
+
+ mediatek,bled-ocp-level-sel:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ enum: [0, 1, 2, 3]
+ description: |
+ Backlight OC level selection.
+ value mapping:
+ - 0: 900mA
+ - 1: 1200mA
+ - 2: 1500mA
+ - 3: 1800mA
+
+ mediatek,bled-channel-use:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ description: |
+ Backlight LED channel to be used.
+ Each bit mapping to:
+ - 0: CH4
+ - 1: CH3
+ - 2: CH2
+ - 3: CH1
+ minimum: 1
+ maximum: 15
+
+required:
+ - compatible
+ - mediatek,bled-channel-use
+
+additionalProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 14/14] dt-bindings: mfd: Add Mediatek MT6370 binding documentation
2022-05-31 10:42 [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation ChiaEn Wu
` (3 preceding siblings ...)
2022-05-31 10:42 ` [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight " ChiaEn Wu
@ 2022-05-31 10:42 ` ChiaEn Wu
4 siblings, 0 replies; 12+ messages in thread
From: ChiaEn Wu @ 2022-05-31 10:42 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
From: ChiYuan Huang <cy_huang@richtek.com>
Add Mediatek MT6370 binding documentation.
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
.../bindings/mfd/mediatek,mt6370.yaml | 282 ++++++++++++++++++
.../dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18 ++
include/dt-bindings/mfd/mediatek,mt6370.h | 83 ++++++
3 files changed, 383 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
create mode 100644 include/dt-bindings/mfd/mediatek,mt6370.h
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
new file mode 100644
index 000000000000..96a12dce0108
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
@@ -0,0 +1,282 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mediatek,mt6370.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT6370 SubPMIC
+
+maintainers:
+ - ChiYuan Huang <cy_huang@richtek.com>
+
+description: |
+ MT6370 is a highly-integrated smart power management IC, which includes a
+ single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
+ Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
+ driver, a backlight WLED driver, a display bias driver and a general LDO for
+ portable devices.
+
+properties:
+ compatible:
+ const: mediatek,mt6370
+
+ reg:
+ maxItems: 1
+
+ wakeup-source: true
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller: true
+
+ '#interrupt-cells':
+ const: 1
+
+ adc:
+ type: object
+ description: |
+ List the compatible configurations of MT6370 ADC.
+
+ properties:
+ compatible:
+ const: mediatek,mt6370-adc
+
+ "#io-channel-cells":
+ const: 1
+
+ required:
+ - compatible
+ - '#io-channel-cells'
+
+ backlight:
+ type: object
+ $ref: /schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
+
+ charger:
+ type: object
+ $ref: /schemas/power/supply/mediatek,mt6370-charger.yaml#
+
+ tcpc:
+ type: object
+ $ref: /schemas/usb/mediatek,mt6370-tcpc.yaml#
+
+ indicator:
+ type: object
+ $ref: /schemas/leds/mediatek,mt6370-indicator.yaml#
+
+ flashlight:
+ type: object
+ $ref: /schemas/leds/mediatek,mt6370-flashlight.yaml#
+
+ regulators:
+ type: object
+ description: |
+ List all supported regulators
+
+ patternProperties:
+ "^(dsvbst|vibldo)$":
+ $ref: /schemas/regulator/regulator.yaml#
+ type: object
+ unevaluatedProperties: false
+
+ "^(dsvpos|dsvneg)$":
+ $ref: /schemas/regulator/regulator.yaml#
+ type: object
+ unevaluatedProperties: false
+
+ properties:
+ enable-gpio:
+ maxItems: 1
+ description: |
+ Specify a valid 'enable' gpio for the regulator and it's optional
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-controller
+ - '#interrupt-cells'
+ - regulators
+ - adc
+ - backlight
+ - indicator
+ - tcpc
+ - charger
+ - flashlight
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/leds/common.h>
+ #include <dt-bindings/mfd/mediatek,mt6370.h>
+ #include <dt-bindings/iio/adc/mediatek,mt6370_adc.h>
+ #include <dt-bindings/usb/pd.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mt6370@34 {
+ compatible = "mediatek,mt6370";
+ reg = <0x34>;
+ wakeup-source;
+ interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ mt6370_adc: adc {
+ compatible = "mediatek,mt6370-adc";
+ #io-channel-cells = <1>;
+ };
+
+ backlight {
+ compatible = "mediatek,mt6370-backlight";
+ mediatek,bled-channel-use = /bits/ 8 <15>;
+ };
+
+ charger {
+ compatible = "mediatek,mt6370-charger";
+ interrupts = <MT6370_IRQ_ATTACH>, <MT6370_IRQ_OVPCTRL_UVP_D>,
+ <MT6370_IRQ_CHG_MIVR>;
+ interrupt-names = "attach_i", "uvp_d_evt", "mivr";
+ io-channels = <&mt6370_adc MT6370_CHAN_IBUS>;
+
+ mt6370_otg_vbus: usb-otg-vbus {
+ regulator-compatible = "mt6370,otg-vbus";
+ regulator-name = "usb-otg-vbus";
+ regulator-min-microvolt = <4350000>;
+ regulator-max-microvolt = <5800000>;
+ regulator-min-microamp = <500000>;
+ regulator-max-microamp = <3000000>;
+ };
+ };
+
+ indicator {
+ compatible = "mediatek,mt6370-indicator";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ multi-led@0 {
+ reg = <0>;
+ function = LED_FUNCTION_INDICATOR;
+ color = <LED_COLOR_ID_RGB>;
+ led-max-microamp = <24000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ mediatek,soft-start = <3>;
+ led@0 {
+ reg = <0>;
+ color = <LED_COLOR_ID_RED>;
+ };
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_BLUE>;
+ };
+ };
+ led@3 {
+ reg = <3>;
+ function = LED_FUNCTION_INDICATOR;
+ color = <LED_COLOR_ID_WHITE>;
+ led-max-microamp = <6000>;
+ };
+ };
+
+ flashlight {
+ compatible = "mediatek,mt6370-flashlight";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ led@0 {
+ reg = <0>;
+ led-sources = <0>;
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ function-enumerator = <1>;
+ led-max-microamp = <200000>;
+ flash-max-microamp = <500000>;
+ flash-max-timeout-us = <1248000>;
+ };
+ led@1 {
+ reg = <1>;
+ led-sources = <1>;
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ function-enumerator = <2>;
+ led-max-microamp = <200000>;
+ flash-max-microamp = <500000>;
+ flash-max-timeout-us = <1248000>;
+ };
+ };
+
+ tcpc {
+ compatible = "mediatek,mt6370-tcpc";
+ interrupts-extended = <&gpio26 4 IRQ_TYPE_LEVEL_LOW>;
+
+ connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ vbus-supply = <&mt6370_otg_vbus>;
+ data-role = "dual";
+ power-role = "dual";
+ try-power-role = "sink";
+ source-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
+ sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
+ op-sink-microwatt = <10000000>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ endpoint {
+ remote-endpoint = <&usb_hs>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ endpoint {
+ remote-endpoint = <&usb_ss>;
+ };
+ };
+ port@2 {
+ reg = <2>;
+ endpoint {
+ remote-endpoint = <&dp_aux>;
+ };
+ };
+ };
+ };
+ };
+
+ regulators {
+ dsvbst {
+ regulator-name = "mt6370-dsv-vbst";
+ regulator-min-microvolt = <4000000>;
+ regulator-max-microvolt = <6200000>;
+ };
+ dsvpos {
+ regulator-name = "mt6370-dsv-vpos";
+ regulator-min-microvolt = <4000000>;
+ regulator-max-microvolt = <6000000>;
+ regulator-boot-on;
+ };
+ dsvneg {
+ regulator-name = "mt6370-dsv-vneg";
+ regulator-min-microvolt = <4000000>;
+ regulator-max-microvolt = <6000000>;
+ regulator-boot-on;
+ };
+ vibldo {
+ regulator-name = "mt6370-vib-ldo";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <4000000>;
+ };
+ };
+ };
+ };
diff --git a/include/dt-bindings/iio/adc/mediatek,mt6370_adc.h b/include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
new file mode 100644
index 000000000000..18ce2fef8f9e
--- /dev/null
+++ b/include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__
+#define __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__
+
+/* ADC Channel Index */
+#define MT6370_CHAN_VBUSDIV5 0
+#define MT6370_CHAN_VBUSDIV2 1
+#define MT6370_CHAN_VSYS 2
+#define MT6370_CHAN_VBAT 3
+#define MT6370_CHAN_TS_BAT 4
+#define MT6370_CHAN_IBUS 5
+#define MT6370_CHAN_IBAT 6
+#define MT6370_CHAN_CHG_VDDP 7
+#define MT6370_CHAN_TEMP_JC 8
+#define MT6370_CHAN_MAX 9
+
+#endif
diff --git a/include/dt-bindings/mfd/mediatek,mt6370.h b/include/dt-bindings/mfd/mediatek,mt6370.h
new file mode 100644
index 000000000000..df641e5d651f
--- /dev/null
+++ b/include/dt-bindings/mfd/mediatek,mt6370.h
@@ -0,0 +1,83 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __DT_BINDINGS_MEDIATEK_MT6370_H__
+#define __DT_BINDINGS_MEDIATEK_MT6370_H__
+
+/* IRQ definitions */
+#define MT6370_IRQ_DIRCHGON 0
+#define MT6370_IRQ_CHG_TREG 4
+#define MT6370_IRQ_CHG_AICR 5
+#define MT6370_IRQ_CHG_MIVR 6
+#define MT6370_IRQ_PWR_RDY 7
+#define MT6370_IRQ_FL_CHG_VINOVP 11
+#define MT6370_IRQ_CHG_VSYSUV 12
+#define MT6370_IRQ_CHG_VSYSOV 13
+#define MT6370_IRQ_CHG_VBATOV 14
+#define MT6370_IRQ_CHG_VINOVPCHG 15
+#define MT6370_IRQ_TS_BAT_COLD 20
+#define MT6370_IRQ_TS_BAT_COOL 21
+#define MT6370_IRQ_TS_BAT_WARM 22
+#define MT6370_IRQ_TS_BAT_HOT 23
+#define MT6370_IRQ_TS_STATC 24
+#define MT6370_IRQ_CHG_FAULT 25
+#define MT6370_IRQ_CHG_STATC 26
+#define MT6370_IRQ_CHG_TMR 27
+#define MT6370_IRQ_CHG_BATABS 28
+#define MT6370_IRQ_CHG_ADPBAD 29
+#define MT6370_IRQ_CHG_RVP 30
+#define MT6370_IRQ_TSHUTDOWN 31
+#define MT6370_IRQ_CHG_IINMEAS 32
+#define MT6370_IRQ_CHG_ICCMEAS 33
+#define MT6370_IRQ_CHGDET_DONE 34
+#define MT6370_IRQ_WDTMR 35
+#define MT6370_IRQ_SSFINISH 36
+#define MT6370_IRQ_CHG_RECHG 37
+#define MT6370_IRQ_CHG_TERM 38
+#define MT6370_IRQ_CHG_IEOC 39
+#define MT6370_IRQ_ADC_DONE 40
+#define MT6370_IRQ_PUMPX_DONE 41
+#define MT6370_IRQ_BST_BATUV 45
+#define MT6370_IRQ_BST_MIDOV 46
+#define MT6370_IRQ_BST_OLP 47
+#define MT6370_IRQ_ATTACH 48
+#define MT6370_IRQ_DETACH 49
+#define MT6370_IRQ_HVDCP_STPDONE 51
+#define MT6370_IRQ_HVDCP_VBUSDET_DONE 52
+#define MT6370_IRQ_HVDCP_DET 53
+#define MT6370_IRQ_CHGDET 54
+#define MT6370_IRQ_DCDT 55
+#define MT6370_IRQ_DIRCHG_VGOK 59
+#define MT6370_IRQ_DIRCHG_WDTMR 60
+#define MT6370_IRQ_DIRCHG_UC 61
+#define MT6370_IRQ_DIRCHG_OC 62
+#define MT6370_IRQ_DIRCHG_OV 63
+#define MT6370_IRQ_OVPCTRL_SWON 67
+#define MT6370_IRQ_OVPCTRL_UVP_D 68
+#define MT6370_IRQ_OVPCTRL_UVP 69
+#define MT6370_IRQ_OVPCTRL_OVP_D 70
+#define MT6370_IRQ_OVPCTRL_OVP 71
+#define MT6370_IRQ_FLED_STRBPIN 72
+#define MT6370_IRQ_FLED_TORPIN 73
+#define MT6370_IRQ_FLED_TX 74
+#define MT6370_IRQ_FLED_LVF 75
+#define MT6370_IRQ_FLED2_SHORT 78
+#define MT6370_IRQ_FLED1_SHORT 79
+#define MT6370_IRQ_FLED2_STRB 80
+#define MT6370_IRQ_FLED1_STRB 81
+#define mT6370_IRQ_FLED2_STRB_TO 82
+#define MT6370_IRQ_FLED1_STRB_TO 83
+#define MT6370_IRQ_FLED2_TOR 84
+#define MT6370_IRQ_FLED1_TOR 85
+#define MT6370_IRQ_OTP 93
+#define MT6370_IRQ_VDDA_OVP 94
+#define MT6370_IRQ_VDDA_UV 95
+#define MT6370_IRQ_LDO_OC 103
+#define MT6370_IRQ_BLED_OCP 118
+#define MT6370_IRQ_BLED_OVP 119
+#define MT6370_IRQ_DSV_VNEG_OCP 123
+#define MT6370_IRQ_DSV_VPOS_OCP 124
+#define MT6370_IRQ_DSV_BST_OCP 125
+#define MT6370_IRQ_DSV_VNEG_SCP 126
+#define MT6370_IRQ_DSV_VPOS_SCP 127
+
+#endif /* __DT_BINDINGS_MEDIATEK_MT6370_H__ */
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight binding documentation
2022-05-31 10:27 [PATCH 00/14] Add Mediatek MT6370 PMIC support ChiaEn Wu
@ 2022-05-31 10:28 ` ChiaEn Wu
2022-06-01 7:34 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: ChiaEn Wu @ 2022-05-31 10:28 UTC (permalink / raw)
To: lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
From: ChiYuan Huang <cy_huang@richtek.com>
Add mt6370 backlight binding documentation.
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
.../backlight/mediatek,mt6370-backlight.yaml | 110 ++++++++++++++++++
1 file changed, 110 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
diff --git a/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
new file mode 100644
index 000000000000..81d72ed44be4
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
@@ -0,0 +1,110 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT6370 Backlight
+
+maintainers:
+ - ChiaEn Wu <chiaen_wu@richtek.com>
+
+description: |
+ MT6370 is a highly-integrated smart power management IC, which includes a
+ single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
+ Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
+ driver, a backlight WLED driver, a display bias driver and a general LDO for
+ portable devices.
+
+ For the LCD backlight, it can provide 4 channel WLED driving capability.
+ Each channel driving current is up to 30mA
+
+allOf:
+ - $ref: common.yaml#
+
+properties:
+ compatible:
+ const: mediatek,mt6370-backlight
+
+ default-brightness:
+ minimum: 0
+ maximum: 2048
+
+ max-brightness:
+ minimum: 0
+ maximum: 2048
+
+ enable-gpios:
+ description: External backlight 'enable' pin
+ maxItems: 1
+
+ mediatek,bled-pwm-enable:
+ description: |
+ Enable external PWM input for backlight dimming
+ type: boolean
+
+ mediatek,bled-pwm-hys-enable:
+ description: |
+ Enable the backlight input-hysteresis for PWM mode
+ type: boolean
+
+ mediatek,bled-pwm-hys-sel:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ enum: [0, 1, 2, 3]
+ description: |
+ Backlight PWM hysteresis input level selection.
+ value mapping:
+ - 0: 1bit
+ - 1: 2bit
+ - 2: 4bit
+ - 3: 6bit
+
+ mediatek,bled-ovp-shutdown:
+ description: |
+ Enable the backlight shutdown when OVP level triggered
+ type: boolean
+
+ mediatek,bled-ovp-level-sel:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ enum: [0, 1, 2, 3]
+ description: |
+ Backlight OVP level selection.
+ value mapping:
+ - 0: 17V
+ - 1: 21V
+ - 2: 25V
+ - 3: 29V
+
+ mediatek,bled-ocp-shutdown:
+ description: |
+ Enable the backlight shutdown when OCP level triggerred.
+ type: boolean
+
+ mediatek,bled-ocp-level-sel:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ enum: [0, 1, 2, 3]
+ description: |
+ Backlight OC level selection.
+ value mapping:
+ - 0: 900mA
+ - 1: 1200mA
+ - 2: 1500mA
+ - 3: 1800mA
+
+ mediatek,bled-channel-use:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ description: |
+ Backlight LED channel to be used.
+ Each bit mapping to:
+ - 0: CH4
+ - 1: CH3
+ - 2: CH2
+ - 3: CH1
+ minimum: 1
+ maximum: 15
+
+required:
+ - compatible
+ - mediatek,bled-channel-use
+
+additionalProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight binding documentation
2022-05-31 10:28 ` [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight binding documentation ChiaEn Wu
@ 2022-06-01 7:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-01 7:34 UTC (permalink / raw)
To: ChiaEn Wu, lee.jones, daniel.thompson, jingoohan1, pavel, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, sre, chunfeng.yun, gregkh,
jic23, lars, lgirdwood, broonie, linux, heikki.krogerus, deller
Cc: cy_huang, alice_chen, chiaen_wu, dri-devel, linux-leds,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, linux-usb, linux-iio, linux-fbdev
On 31/05/2022 12:28, ChiaEn Wu wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add mt6370 backlight binding documentation.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> .../backlight/mediatek,mt6370-backlight.yaml | 110 ++++++++++++++++++
> 1 file changed, 110 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> new file mode 100644
> index 000000000000..81d72ed44be4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6370 Backlight
> +
> +maintainers:
> + - ChiaEn Wu <chiaen_wu@richtek.com>
> +
> +description: |
> + MT6370 is a highly-integrated smart power management IC, which includes a
> + single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
> + Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
> + driver, a backlight WLED driver, a display bias driver and a general LDO for
> + portable devices.
Do not repeat entire device description, but describe only this part.
Your other pieces of MFD were doing it correctly, so why here it is
different?
> +
> + For the LCD backlight, it can provide 4 channel WLED driving capability.
> + Each channel driving current is up to 30mA
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-backlight
> +
> + default-brightness:
> + minimum: 0
> + maximum: 2048
> +
> + max-brightness:
> + minimum: 0
> + maximum: 2048
> +
> + enable-gpios:
> + description: External backlight 'enable' pin
> + maxItems: 1
> +
> + mediatek,bled-pwm-enable:
> + description: |
> + Enable external PWM input for backlight dimming
> + type: boolean
> +
> + mediatek,bled-pwm-hys-enable:
> + description: |
> + Enable the backlight input-hysteresis for PWM mode
> + type: boolean
> +
> + mediatek,bled-pwm-hys-sel:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + enum: [0, 1, 2, 3]
> + description: |
> + Backlight PWM hysteresis input level selection.
> + value mapping:
> + - 0: 1bit
> + - 1: 2bit
> + - 2: 4bit
> + - 3: 6bit
Please explain what is this input level and what is the meaning of
6bit... In any case you cannot have values mapping, but instead you
should use the logical values (so 1, 2, 4, and 6).
If "sel" is shortcut of "selection" please drop it.
> +
> + mediatek,bled-ovp-shutdown:
> + description: |
> + Enable the backlight shutdown when OVP level triggered
> + type: boolean
> +
> + mediatek,bled-ovp-level-sel:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + enum: [0, 1, 2, 3]
> + description: |
> + Backlight OVP level selection.
> + value mapping:
> + - 0: 17V
> + - 1: 21V
> + - 2: 25V
> + - 3: 29V
Logical values in microvolts. Name it according to unit suffices and
drop any useless parts of property name like "level selection". It is
simply - mediatek,bled-ovp-microvolt.
> +
> + mediatek,bled-ocp-shutdown:
> + description: |
> + Enable the backlight shutdown when OCP level triggerred.
> + type: boolean
> +
> + mediatek,bled-ocp-level-sel:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + enum: [0, 1, 2, 3]
> + description: |
> + Backlight OC level selection.
> + value mapping:
> + - 0: 900mA
> + - 1: 1200mA
> + - 2: 1500mA
> + - 3: 1800mA
Same comments.
> +
> + mediatek,bled-channel-use:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: |
> + Backlight LED channel to be used.
> + Each bit mapping to:
> + - 0: CH4
> + - 1: CH3
> + - 2: CH2
> + - 3: CH1> + minimum: 1
> + maximum: 15
> +
> +required:
> + - compatible
> + - mediatek,bled-channel-use
> +
> +additionalProperties: false
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread