From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08C5C433EF for ; Wed, 8 Jun 2022 14:36:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241489AbiFHOgy (ORCPT ); Wed, 8 Jun 2022 10:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241497AbiFHOgx (ORCPT ); Wed, 8 Jun 2022 10:36:53 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DECB3A3383 for ; Wed, 8 Jun 2022 07:36:46 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id a15so20128483wrh.2 for ; Wed, 08 Jun 2022 07:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=khBUE53X9QuO6dWoSeEXJmXd2fMLigTEjdoQDhHw9mU=; b=Zygb11Po3xDFIHW2f+svcZVUL+ZvG2ZRBoGgdGzKTr0Kbk0U0KLEHUhPGDjn9UDod4 8YdMOQoEFnHaWsA9c5BtdfJEyOk8qA79OEExEabcm92kdN2REqzYhAYxAIChyKgBKBJv xrbalNL9qXh0cL+SlrXMWypEq4ZFjxKCenwUsuTr/6K5Z+dSWKaDcVR/mNHdUZzcM5Lz 68FzKB6yp9pt75OTd1dPBnsuNgW7aiCn7Nk2BfEaBgWn9U1tT+btkuzh3xO0izONkRPh WLU3dkz0/JaRYem8VX/l+AWseou10xPiimxGawgdHEPTjDJunaaRhJf58Y6PIua/vQAk z0Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=khBUE53X9QuO6dWoSeEXJmXd2fMLigTEjdoQDhHw9mU=; b=wNiLk5z7Nt2hnHv1xrHAFpoLiv6aERcjr7KSc197YQS7CptkFgdewaBsE+pDO7DbeP cz9XfFSpU+2c2b0lZsQ/EnSGuJBNX4a4H40+JoNwv9VmJaxH2DwKvehFr4Z8OOPgbTO0 p9vqT6uoXHmH45emkMZE4M0POnbZxqOZiSHaGrUnilP8dTZoT8LpcO/aIS0olJ3QxHLP pvnvJHl4Z1AjOjmlF8+hybCTT4/3Fkj1zD8q5ib2LGaeVXK4bfGKuvu4u0bSyOQWz8hf NFiUoOM9UORG2MxI/Zv4T9gJr0RcbzWhdAlHIJ3nIbFEzezoRD0B9zcr8qL/eYYLncDd vZtA== X-Gm-Message-State: AOAM532c94UGVgsOWPRBDKo+FQkeausoxCs9I0N1SZtR8WKe2oHfMrJK y3opR+5gybolHa5ykNAYxiH6nQ== X-Google-Smtp-Source: ABdhPJyihLbbU649/VAE29N/msO4G2EkXgHbveOzoAedQSvWja/dqHMy6G3ndT8k+NvEQCDLvtz6Vg== X-Received: by 2002:a5d:6d8b:0:b0:218:4de1:25a0 with SMTP id l11-20020a5d6d8b000000b002184de125a0mr10508544wrs.8.1654699005239; Wed, 08 Jun 2022 07:36:45 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id k2-20020a5d5182000000b0020c5253d8fcsm21942007wrv.72.2022.06.08.07.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 07:36:44 -0700 (PDT) Date: Wed, 8 Jun 2022 15:36:43 +0100 From: Daniel Thompson To: Stephen Kitt Cc: Lee Jones , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] backlight: tosa: Use backlight helper Message-ID: <20220608143643.km7eainfqvttuoqe@maple.lan> References: <20220607190925.1134737-1-steve@sk2.org> <20220607190925.1134737-5-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607190925.1134737-5-steve@sk2.org> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Jun 07, 2022 at 09:09:25PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Helge Deller > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org Reviewed-by: Daniel Thompson ... and, wowzer, the code before your change wasn't much fun to read! > static int tosa_bl_update_status(struct backlight_device *dev) > { > - struct backlight_properties *props = &dev->props; > struct tosa_bl_data *data = bl_get_data(dev); > - int power = max(props->power, props->fb_blank); > - int brightness = props->brightness; > - > - if (power) > - brightness = 0; > + int brightness = backlight_get_brightness(dev); > > tosa_bl_set_backlight(data, brightness); Daniel.