From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3531CCA48F for ; Tue, 28 Jun 2022 02:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244775AbiF1C3v (ORCPT ); Mon, 27 Jun 2022 22:29:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244567AbiF1C10 (ORCPT ); Mon, 27 Jun 2022 22:27:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D018825C59; Mon, 27 Jun 2022 19:24:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8867DB81C18; Tue, 28 Jun 2022 02:24:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69DF4C341CB; Tue, 28 Jun 2022 02:24:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656383089; bh=ChdpymeB3TsEFGpqxL1k20A2RoBePNdIlStDwn97s5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hOrjheNBZBfgx6pp1aMHeYTsGcaHOegKXOTrTmtcZQXaOKxm54v4F214S5eMn8AME wS3usjX90tTJ6bDo83+kE1+tSmjBu3M4TJffB15uk0Sp/+kBNHJDi3SSsJDmuBa6pR nBigfb67SAsq+MfIpI11Qe6iSt53LSnAeYXa3Q7SfRYQ1/s0vYhkIPEMO9LUdtTIxz z5BIRR+lQ0Prjr8oQ29NKlPfzNPpbr5crYy7w574kYpEkNNvaMwDK3zloNxe4cFmyZ /Qq4CAl5QeKuU0wmuiGz3OFLqTcko4n96lTwALkCjIpNH1bQorndKFaRtKuvdN3e+7 UoC5cBO2G9wxA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yihao Han , Hans de Goede , Helge Deller , Sasha Levin , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.4 14/27] video: fbdev: simplefb: Check before clk_put() not needed Date: Mon, 27 Jun 2022 22:24:00 -0400 Message-Id: <20220628022413.596341-14-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022413.596341-1-sashal@kernel.org> References: <20220628022413.596341-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org From: Yihao Han [ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ] clk_put() already checks the clk ptr using !clk and IS_ERR() so there is no need to check it again before calling it. Signed-off-by: Yihao Han Reviewed-by: Hans de Goede Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/simplefb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index 7dc0105f700d..f03705666983 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -225,8 +225,7 @@ static int simplefb_clocks_get(struct simplefb_par *par, if (IS_ERR(clock)) { if (PTR_ERR(clock) == -EPROBE_DEFER) { while (--i >= 0) { - if (par->clks[i]) - clk_put(par->clks[i]); + clk_put(par->clks[i]); } kfree(par->clks); return -EPROBE_DEFER; -- 2.35.1